You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tomee.apache.org by David Blevins <da...@visi.com> on 2010/07/03 00:01:59 UTC

Re: Stateless Pooling options

On Mar 25, 2010, at 2:14 AM, David Blevins wrote:

> Ok.  Think I'm totally done with all our new fancy stateless pooling options.

Not quite :)

>  # [...] Pool "shrinking" is achived through SoftReferences
>  # and natural vm garbage collection. All but the minimum are allowed
>  # to be garbage collected by the VM when memory is needed.

Looks like we may want a couple features here.

  1.  The ability to shut-off the garbage collection feature.
  2.  We don't currently invoke PreDestroy callbacks on garbage collected instances -- they just go away.

Will be hacking on both of those.

-David


Re: Stateless Pooling options

Posted by David Blevins <da...@visi.com>.
On Jul 2, 2010, at 3:01 PM, David Blevins wrote:

> 
> On Mar 25, 2010, at 2:14 AM, David Blevins wrote:
> 
>> Ok.  Think I'm totally done with all our new fancy stateless pooling options.
> 
> Not quite :)
> 
>> # [...] Pool "shrinking" is achived through SoftReferences
>> # and natural vm garbage collection. All but the minimum are allowed
>> # to be garbage collected by the VM when memory is needed.
> 
> Looks like we may want a couple features here.
> 
>  1.  The ability to shut-off the garbage collection feature.
>  2.  We don't currently invoke PreDestroy callbacks on garbage collected instances -- they just go away.
> 
> Will be hacking on both of those.

Got those in.  Took the opportunity to clean up the new config option names and doc as long as I was at it -- in some cases the related JMX attribute name and the configuration option name were different which is needlessly confusing.  Here's a summary of the change:

Added the following pool config options: 
  GarbageCollection
  ReplaceFlushed
Renamed the following pool config options:
  PoolMin -> MinSize
  PoolMax -> MaxSize
  PollInterval -> SweepInterval

Pool will also now call @PreDestroy callbacks on garbage collected instances

Added the following pool JMX attributes:
  GarbageCollection
  ReplaceFlushed
  InstancesIdle
  InstancesActive
Renamed the following pool JMX attributes:
  PollInterval -> SweepInterval
  Available -> AvailablePermits
  Instances -> InstancesPooled

Fixed all remaining pooling stats issues as well.


Still need to merge this into the 3.1.3 branch, but once that is done we should be good on the pooling/stats front!


-David