You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@guacamole.apache.org by "eugen-keeper (via GitHub)" <gi...@apache.org> on 2024/11/26 15:52:19 UTC
[PR] GUACAMOLE-2002: Allow connection clipboard limits to be configured [guacamole-client]
eugen-keeper opened a new pull request, #1035:
URL: https://github.com/apache/guacamole-client/pull/1035
[Jira Discussion](https://issues.apache.org/jira/browse/GUACAMOLE-2002)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@guacamole.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GUACAMOLE-2002: Allow connection clipboard limits to be configured [guacamole-client]
Posted by "mike-jumper (via GitHub)" <gi...@apache.org>.
mike-jumper commented on code in PR #1035:
URL: https://github.com/apache/guacamole-client/pull/1035#discussion_r1859051303
##########
guacamole-ext/src/main/resources/org/apache/guacamole/protocols/rdp.json:
##########
@@ -191,6 +191,11 @@
"type" : "ENUM",
"options" : [ "", "preserve", "unix", "windows" ]
},
+ {
+ "name" : "clipboard-buffer-size",
+ "type" : "ENUM",
+ "options" : [ "262144", "1048576", "10485760" ]
Review Comment:
There should also be a `""` option to permit the default value to be selected and represented (same for the other protocols).
##########
guacamole/src/main/frontend/src/translations/en.json:
##########
@@ -826,6 +842,7 @@
"FIELD_HEADER_COLOR_SCHEME" : "Color scheme:",
"FIELD_HEADER_CREATE_RECORDING_PATH" : "Automatically create recording path:",
"FIELD_HEADER_CREATE_TYPESCRIPT_PATH" : "Automatically create typescript path:",
+ "FIELD_HEADER_CLIPBOARD_BUFFER_SIZE" : "Clipboard data size limit:",
Review Comment:
Please maintain established alphabetical ordering of the translation keys (same for other protocols).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@guacamole.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GUACAMOLE-2002: Allow connection clipboard limits to be configured. [guacamole-client]
Posted by "mike-jumper (via GitHub)" <gi...@apache.org>.
mike-jumper merged PR #1035:
URL: https://github.com/apache/guacamole-client/pull/1035
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@guacamole.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GUACAMOLE-2002: Allow connection clipboard limits to be configured [guacamole-client]
Posted by "eugen-keeper (via GitHub)" <gi...@apache.org>.
eugen-keeper commented on code in PR #1035:
URL: https://github.com/apache/guacamole-client/pull/1035#discussion_r1866280999
##########
guacamole-ext/src/main/resources/org/apache/guacamole/protocols/rdp.json:
##########
@@ -191,6 +191,11 @@
"type" : "ENUM",
"options" : [ "", "preserve", "unix", "windows" ]
},
+ {
+ "name" : "clipboard-buffer-size",
+ "type" : "ENUM",
+ "options" : [ "262144", "1048576", "10485760" ]
Review Comment:
Fixed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@guacamole.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GUACAMOLE-2002: Allow connection clipboard limits to be configured [guacamole-client]
Posted by "eugen-keeper (via GitHub)" <gi...@apache.org>.
eugen-keeper commented on code in PR #1035:
URL: https://github.com/apache/guacamole-client/pull/1035#discussion_r1866281524
##########
guacamole/src/main/frontend/src/translations/en.json:
##########
@@ -826,6 +842,7 @@
"FIELD_HEADER_COLOR_SCHEME" : "Color scheme:",
"FIELD_HEADER_CREATE_RECORDING_PATH" : "Automatically create recording path:",
"FIELD_HEADER_CREATE_TYPESCRIPT_PATH" : "Automatically create typescript path:",
+ "FIELD_HEADER_CLIPBOARD_BUFFER_SIZE" : "Clipboard data size limit:",
Review Comment:
Fixed (?).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@guacamole.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org