[jira] [Commented] (KAFKA-19033) FindCoordinator API always return COORDINATOR_NOT_AVAILABLE for CoordinatorType.SHARE

["Chia-Ping Tsai (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/KAFKA-19033?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17937944#comment-17937944 ] 

Chia-Ping Tsai commented on KAFKA-19033:
----------------------------------------

I identified this issue during code review, rather than through failed test cases. Therefore, it would be better that we implement a test to specifically address this.

> FindCoordinator API always return COORDINATOR_NOT_AVAILABLE for CoordinatorType.SHARE 
> --------------------------------------------------------------------------------------
>
>                 Key: KAFKA-19033
>                 URL: https://issues.apache.org/jira/browse/KAFKA-19033
>             Project: Kafka
>          Issue Type: Bug
>            Reporter: Chia-Ping Tsai
>            Assignee: Chia-Ping Tsai
>            Priority: Major
>
> https://github.com/apache/kafka/blob/trunk/core/src/main/scala/kafka/server/KafkaApis.scala#L1183
> *before*
> {code:java}
>           (shareCoordinator.foreach(coordinator => coordinator.partitionFor(SharePartitionKey.getInstance(key))), SHARE_GROUP_STATE_TOPIC_NAME)
> {code}
> *after*
> {code:java}
> (shareCoordinator.get.partitionFor(SharePartitionKey.getInstance(key)), SHARE_GROUP_STATE_TOPIC_NAME)
> {code}
> noted that the existence of shareCoordinator is already checked before.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)