[jira] [Commented] (KAFKA-1123) Broker IPv6 addresses parsed incorrectly

["Jun Rao (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/KAFKA-1123?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14100956#comment-14100956 ] 

Jun Rao commented on KAFKA-1123:
--------------------------------

Thanks for the patch. Some comments.

1. Utils.parseHostPort(): Should we just move the logic into org.apache.kafka.common.utils.ClientUtils and reuse it in parseAndValidateAddresses()? That way, we have only one way of parsing the hostAndPort.

2. Do we need to wrap the ipv6 address with "[]"? It seems that InetSocketAddress can take that format. However, I am not sure if this is the standard representation. When specifying ipv6-based broker list, do we expect the user to wrap the address part with "[]"?



> Broker IPv6 addresses parsed incorrectly
> ----------------------------------------
>
>                 Key: KAFKA-1123
>                 URL: https://issues.apache.org/jira/browse/KAFKA-1123
>             Project: Kafka
>          Issue Type: Bug
>          Components: producer 
>    Affects Versions: 0.8.2
>            Reporter: Andrew Otto
>              Labels: newbie
>         Attachments: KAFKA-1123.patch
>
>
> It seems that broker addresses are parsed incorrectly when IPv6 addresses are supplied.  IPv6 addresses have colons in them, and Kafka seems to be interpreting the first : as the address:port separator.
> I have only tried this with the console-producer --broker-list option, so I don't know if this affects anything deeper than the CLI.



--
This message was sent by Atlassian JIRA
(v6.2#6252)