[PR] test(desktop): scope slash-menu mutation watch to the menu and read once [maka]

["yunaremaia (via GitHub)" <gi...@apache.org>]

yunaremaia opened a new pull request, #3737:
URL: https://github.com/apache/maka/pull/3737

   ## Summary
   
   Implements the direction suggested in #3727 for the slash-command-menu flake:
   
   - The mutation watch now observes the menu itself (subtree) plus its parent, instead of `document.body` with `subtree: true`. Overlays elsewhere in the document (toasts, tooltips, other popups) can no longer contribute removals to the counter.
   - The observers disconnect once the refresh rounds have settled (visibility wait + one frame pair), and the count is read exactly once. The old `expect.poll` on a monotonically increasing counter could never retry into success - it only added 3s of latency before failing.
   - No retries are added; the config's fail-loudly stance (`retries: 0`) is untouched.
   
   ## Why this is safe
   
   The guarded property (#2667) is "a same-content projection refresh must not tear down the skills group or the listbox". The new watch counts exactly two things during the refresh window: a `[role="group"]` removed inside the menu, or the listbox element itself removed. Anything else was noise under the old predicate, which counted any removed element *containing* a listbox/group anywhere in the document.
   
   Verified locally under xvfb (Electron 43):
   
   - Spec green: 5/5 tests, six consecutive runs of the target test all passed.
   - Regression check: temporarily injecting a group teardown right after arming makes the rewritten test fail with `removals = 1` - the narrowing does not mute the failure mode the test exists to catch.
   
   ## Note on artifacts
   
   The trace/video artifacts from the five failing runs linked in the issue had already expired, so I could not diff them directly; the code-path analysis above is the basis for the window-scope reading.
   
   Fixes #3727
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@maka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@maka.apache.org
For additional commands, e-mail: commits-help@maka.apache.org

Re: [PR] test(desktop): scope slash-menu mutation watch to the menu and read once [maka]

["Astro-Han (via GitHub)" <gi...@apache.org>]

Astro-Han merged PR #3737:
URL: https://github.com/apache/maka/pull/3737


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@maka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@maka.apache.org
For additional commands, e-mail: commits-help@maka.apache.org