You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@calcite.apache.org by GitBox <gi...@apache.org> on 2020/09/21 21:41:41 UTC

[GitHub] [calcite] julianhyde edited a comment on pull request #2161: [CALCITE-4240] Fix SqlTypeUtil#getMaxPrecisionScaleDecimal returns a decimal that with same precision and scale(Jiatao Tao)

julianhyde edited a comment on pull request #2161:
URL: https://github.com/apache/calcite/pull/2161#issuecomment-696393247


   Remove the word 'fix' from the commit message. Change the message so that it is clear what the bug is.
   
   Add space before '(' in commit message.
   
   Why would `DECIMAL(10, 28)` not be valid? Say if you are measuring a small quantify such as [Avagadro's number](https://en.wikipedia.org/wiki/Avogadro_constant).


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org