You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@avro.apache.org by "kojiromike (via GitHub)" <gi...@apache.org> on 2023/07/18 01:39:19 UTC
[GitHub] [avro] kojiromike opened a new pull request, #2363: Cleanup Unused Imports and Variable Assignments
kojiromike opened a new pull request, #2363:
URL: https://github.com/apache/avro/pull/2363
## What is the purpose of the change
This is a cleanup change to remove unused imports and variable assignments.
## Verifying this change
This change is a trivial rework / code cleanup without any test coverage.
## Documentation
No features or need for additional documentation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@avro.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [avro] kojiromike commented on a diff in pull request #2363: Cleanup Unused Imports and Variable Assignments
Posted by "kojiromike (via GitHub)" <gi...@apache.org>.
kojiromike commented on code in PR #2363:
URL: https://github.com/apache/avro/pull/2363#discussion_r1266784515
##########
lang/py/avro/test/test_tether_task_runner.py:
##########
@@ -47,7 +46,7 @@ def test1(self):
pyfile = avro.test.mock_tether_parent.__file__
proc = subprocess.Popen([sys.executable, pyfile, "start_server", f"{parent_port}"])
- input_port = avro.tether.util.find_port()
+ avro.tether.util.find_port()
Review Comment:
```suggestion
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@avro.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [avro] kojiromike commented on a diff in pull request #2363: Cleanup Unused Imports and Variable Assignments
Posted by "kojiromike (via GitHub)" <gi...@apache.org>.
kojiromike commented on code in PR #2363:
URL: https://github.com/apache/avro/pull/2363#discussion_r1266797337
##########
lang/py/avro/io.py:
##########
@@ -810,7 +799,7 @@ def read_array(self, writers_schema: avro.schema.ArraySchema, readers_schema: av
while block_count != 0:
if block_count < 0:
block_count = -block_count
- block_size = decoder.read_long()
+ decoder.read_long()
Review Comment:
```suggestion
decoder.skip_long()
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@avro.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [avro] kojiromike commented on a diff in pull request #2363: Cleanup Unused Imports and Variable Assignments
Posted by "kojiromike (via GitHub)" <gi...@apache.org>.
kojiromike commented on code in PR #2363:
URL: https://github.com/apache/avro/pull/2363#discussion_r1266798327
##########
lang/py/avro/io.py:
##########
@@ -847,7 +836,7 @@ def read_map(self, writers_schema: avro.schema.MapSchema, readers_schema: avro.s
while block_count != 0:
if block_count < 0:
block_count = -block_count
- block_size = decoder.read_long()
+ decoder.read_long()
Review Comment:
```suggestion
decoder.skip_long()
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@avro.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [avro] kojiromike merged pull request #2363: AVRO-3807 Cleanup Unused Imports and Variable Assignments
Posted by "kojiromike (via GitHub)" <gi...@apache.org>.
kojiromike merged PR #2363:
URL: https://github.com/apache/avro/pull/2363
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@avro.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org