You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@trafficserver.apache.org by GitBox <gi...@apache.org> on 2021/07/15 18:34:59 UTC

[GitHub] [trafficserver] bneradt commented on a change in pull request #8066: Fixing TS_HTTP_REQUEST_BUFFER_READ_COMPLETE_HOOK enum value.

bneradt commented on a change in pull request #8066:
URL: https://github.com/apache/trafficserver/pull/8066#discussion_r670714351



##########
File path: tests/gold_tests/pluginTest/test_hooks/body_buffer.test.py
##########
@@ -0,0 +1,121 @@
+'''
+Verify HTTP body buffering.
+'''
+#  Licensed to the Apache Software Foundation (ASF) under one
+#  or more contributor license agreements.  See the NOTICE file
+#  distributed with this work for additional information
+#  regarding copyright ownership.  The ASF licenses this file
+#  to you under the Apache License, Version 2.0 (the
+#  "License"); you may not use this file except in compliance
+#  with the License.  You may obtain a copy of the License at
+#
+#      http://www.apache.org/licenses/LICENSE-2.0
+#
+#  Unless required by applicable law or agreed to in writing, software
+#  distributed under the License is distributed on an "AS IS" BASIS,
+#  WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+#  See the License for the specific language governing permissions and
+#  limitations under the License.
+
+import os
+

Review comment:
       Remove os and add:
   
   ```
   Test.SkipUnless(
       Condition.PluginExists('request_buffer.so'),
   )
   ```




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org