[GitHub] [beam] lostluck commented on a change in pull request #13434: [BEAM-11357] Add annotations to PTransforms and enable them in Go SDK

[GitBox <gi...@apache.org>]

lostluck commented on a change in pull request #13434:
URL: https://github.com/apache/beam/pull/13434#discussion_r536321232



##########
File path: model/pipeline/src/main/proto/beam_runner_api.proto
##########
@@ -188,6 +188,13 @@ message PTransform {
   // Transforms that are required to be implemented by a runner must omit this.
   // All other transforms are required to specify this.
   string environment_id = 7;
+
+  // (Optional) A map from URNs designating a type of annotation, to the
+  // annotation in binary format. For example, an annotation could indicate
+  // that this PTransform has specific resource preferences.
+  //
+  // A runner MAY ignore types of annotations it doesn't understand.

Review comment:
       I think we should add "Therefore annotations MUST NOT be used for metadata that can affect correct execution of the transform."




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org