You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by "jacktengg (via GitHub)" <gi...@apache.org> on 2026/05/28 06:29:27 UTC

[PR] [fix](insert) enable_insert_strict should not affect semantic of enable_strict_cast [doris]

jacktengg opened a new pull request, #63794:
URL: https://github.com/apache/doris/pull/63794

   ### What problem does this PR solve?
   
   Issue Number: close #xxx
   
   Related PR: #xxx
   
   Problem Summary:
   
   ### Release note
   
   None
   
   ### Check List (For Author)
   
   - Test <!-- At least one of them must be included. -->
       - [ ] Regression test
       - [ ] Unit Test
       - [ ] Manual test (add detailed scripts or steps below)
       - [ ] No need to test or manual test. Explain why:
           - [ ] This is a refactor/code format and no logic has been changed.
           - [ ] Previous test can cover this change.
           - [ ] No code files have been changed.
           - [ ] Other reason <!-- Add your reason?  -->
   
   - Behavior changed:
       - [ ] No.
       - [ ] Yes. <!-- Explain the behavior change -->
   
   - Does this need documentation?
       - [ ] No.
       - [ ] Yes. <!-- Add document PR link here. eg: https://github.com/apache/doris-website/pull/1214 -->
   
   ### Check List (For Reviewer who merge this PR)
   
   - [ ] Confirm the release note
   - [ ] Confirm test cases
   - [ ] Confirm document
   - [ ] Add branch pick label <!-- Add branch pick label that this PR should merge into -->
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [fix](insert) enable_insert_strict should not affect semantic of enable_strict_cast [doris]

Posted by "jacktengg (via GitHub)" <gi...@apache.org>.
jacktengg commented on PR #63794:
URL: https://github.com/apache/doris/pull/63794#issuecomment-4599053498

   run buildall


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [fix](insert) enable_insert_strict should not affect semantic of enable_strict_cast [doris]

Posted by "jacktengg (via GitHub)" <gi...@apache.org>.
jacktengg commented on PR #63794:
URL: https://github.com/apache/doris/pull/63794#issuecomment-4599686821

   run buildall


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [fix](insert) enable_insert_strict should not affect semantic of enable_strict_cast [doris]

Posted by "jacktengg (via GitHub)" <gi...@apache.org>.
jacktengg commented on PR #63794:
URL: https://github.com/apache/doris/pull/63794#issuecomment-4599686283

   /review


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [fix](insert) enable_insert_strict should not affect semantic of enable_strict_cast [doris]

Posted by "jacktengg (via GitHub)" <gi...@apache.org>.
jacktengg commented on PR #63794:
URL: https://github.com/apache/doris/pull/63794#issuecomment-4561365455

   run buildall


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [fix](insert) enable_insert_strict should not affect semantic of enable_strict_cast [doris]

Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #63794:
URL: https://github.com/apache/doris/pull/63794#issuecomment-4561822110

   
   <details>
   <summary>TPC-DS: <b>Total hot run time: 171760 ms</b></summary>
   
   ```
   machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
   scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
   TPC-DS sf100 test result on commit 0d84131c6b670a5844337a143b0e1ef2826e7423, data reload: false
   
   query5	4346	657	514	514
   query6	341	211	207	207
   query7	4333	558	306	306
   query8	327	231	218	218
   query9	8769	4095	4061	4061
   query10	451	373	303	303
   query11	5776	2550	2264	2264
   query12	186	128	127	127
   query13	1291	621	452	452
   query14	6181	5478	5177	5177
   query14_1	4464	4490	4452	4452
   query15	217	206	190	190
   query16	1017	503	449	449
   query17	1144	755	611	611
   query18	2719	496	372	372
   query19	224	213	173	173
   query20	151	144	134	134
   query21	217	142	121	121
   query22	13699	13531	13375	13375
   query23	17375	16458	16182	16182
   query23_1	16382	16237	16408	16237
   query24	7521	1769	1334	1334
   query24_1	1319	1314	1348	1314
   query25	554	493	411	411
   query26	1344	308	170	170
   query27	2713	581	337	337
   query28	4411	1977	1958	1958
   query29	975	600	490	490
   query30	306	230	200	200
   query31	1138	1076	959	959
   query32	92	79	72	72
   query33	534	364	294	294
   query34	1180	1160	657	657
   query35	781	792	698	698
   query36	1404	1402	1254	1254
   query37	151	100	89	89
   query38	3203	3141	3165	3141
   query39	920	923	875	875
   query39_1	870	900	903	900
   query40	222	143	124	124
   query41	65	62	62	62
   query42	111	109	104	104
   query43	334	332	289	289
   query44	
   query45	213	208	198	198
   query46	1065	1196	751	751
   query47	2405	2396	2258	2258
   query48	407	396	303	303
   query49	635	504	380	380
   query50	977	332	264	264
   query51	4403	4337	4257	4257
   query52	103	103	92	92
   query53	247	275	205	205
   query54	311	268	261	261
   query55	96	91	85	85
   query56	303	297	300	297
   query57	1467	1436	1352	1352
   query58	297	270	275	270
   query59	1633	1663	1453	1453
   query60	328	348	337	337
   query61	178	177	175	175
   query62	703	656	590	590
   query63	252	214	206	206
   query64	2437	894	621	621
   query65	
   query66	1666	477	364	364
   query67	29698	29618	29501	29501
   query68	
   query69	472	359	308	308
   query70	1056	1002	1013	1002
   query71	305	262	267	262
   query72	2981	2701	2336	2336
   query73	866	767	431	431
   query74	5099	4991	4752	4752
   query75	2713	2595	2270	2270
   query76	2313	1144	797	797
   query77	405	417	334	334
   query78	12231	12372	11868	11868
   query79	1320	1057	705	705
   query80	577	537	451	451
   query81	455	326	241	241
   query82	315	153	125	125
   query83	361	282	250	250
   query84	253	140	114	114
   query85	888	543	444	444
   query86	400	345	351	345
   query87	3420	3382	3257	3257
   query88	3618	2711	2708	2708
   query89	443	415	349	349
   query90	1975	175	181	175
   query91	179	166	141	141
   query92	77	80	74	74
   query93	1480	1477	861	861
   query94	538	347	313	313
   query95	675	374	354	354
   query96	1052	780	342	342
   query97	2741	2711	2587	2587
   query98	240	243	234	234
   query99	1204	1161	1020	1020
   Total cold run time: 253188 ms
   Total hot run time: 171760 ms
   ```
   </details>
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [fix](insert) enable_insert_strict should not affect semantic of enable_strict_cast [doris]

Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #63794:
URL: https://github.com/apache/doris/pull/63794#issuecomment-4596722682

   # FE Regression Coverage Report
   Increment line coverage `  80.00% (4/5)` :tada:
   [Increment coverage report](http://coverage.selectdb-in.cc/coverage/63794_4fb49ca1dda051475d6603b70ba376073fe49865_merge_fe/increment_report/index.html)
   [Complete coverage report](http://coverage.selectdb-in.cc/coverage/63794_4fb49ca1dda051475d6603b70ba376073fe49865_merge_fe/report/index.html)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [fix](insert) enable_insert_strict should not affect semantic of enable_strict_cast [doris]

Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #63794:
URL: https://github.com/apache/doris/pull/63794#issuecomment-4594997087

   # Cloud UT Coverage Report
   Increment line coverage ` ` :tada:
   
   [Increment coverage report](http://coverage.selectdb-in.cc/coverage/4fb49ca1dda051475d6603b70ba376073fe49865_4fb49ca1dda051475d6603b70ba376073fe49865_cloud/increment_report/index.html)
   [Complete coverage report](http://coverage.selectdb-in.cc/coverage/4fb49ca1dda051475d6603b70ba376073fe49865_4fb49ca1dda051475d6603b70ba376073fe49865_cloud/report/index.html)
   | Category          | Coverage           |
   |-------------------|--------------------|
   | Function Coverage | 78.34% (1906/2433) |
   | Line Coverage     | 64.75% (33975/52468) |
   | Region Coverage   | 65.29% (17520/26833) |
   | Branch Coverage   | 53.93% (9293/17230) |


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [fix](insert) enable_insert_strict should not affect semantic of enable_strict_cast [doris]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on code in PR #63794:
URL: https://github.com/apache/doris/pull/63794#discussion_r3338171845


##########
be/src/storage/tablet_info.cpp:
##########
@@ -297,6 +298,9 @@ Status OlapTableSchemaParam::init(const TOlapTableSchemaParam& tschema) {
     if (tschema.__isset.is_strict_mode) {
         _is_strict_mode = tschema.is_strict_mode;
     }
+    if (tschema.__isset.is_insert) {
+        _is_insert = tschema.is_insert;

Review Comment:
   This leaves `_is_insert` false whenever the schema param comes from an older FE that does not know field 18. New BE then runs the non-insert branch in `OlapTableBlockConvertor`; for a normal old-FE insert, `is_strict_mode` is false unless it is the partial-update special case, while the old `query_options.enable_insert_strict` signal is now ignored. A strict insert from an old FE can therefore be treated as non-strict and truncate overlong strings during rolling upgrade. Please preserve a compatibility fallback for schema params where `is_insert` is unset, or keep using the old query option for that case.



##########
be/src/runtime/runtime_state.h:
##########
@@ -239,8 +239,9 @@ class RuntimeState {
         return _query_options.__isset.enable_strict_cast && _query_options.enable_strict_cast;
     }
 
-    bool enable_insert_strict() const {
-        return _query_options.__isset.enable_insert_strict && _query_options.enable_insert_strict;
+    bool enable_insert_value_auto_cast() const {
+        return _query_options.__isset.enable_insert_value_auto_cast &&
+               _query_options.enable_insert_value_auto_cast;

Review Comment:
   This optional thrift field has a declared default of `true`, but this accessor returns `false` whenever the field is unset. That changes behavior for any path that constructs `TQueryOptions` without explicitly setting the new field, including mixed-version execution where an old FE sends fragments to a new BE. In that case `enable_insert_value_auto_cast` should keep its default-enabled behavior, but `__isset` is false and insert-side truncation is disabled. Please treat unset as the thrift/default value, e.g. `!__isset.enable_insert_value_auto_cast || _query_options.enable_insert_value_auto_cast`.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [fix](insert) enable_insert_strict should not affect semantic of enable_strict_cast [doris]

Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #63794:
URL: https://github.com/apache/doris/pull/63794#issuecomment-4600325943

   # BE UT Coverage Report
   Increment line coverage `65.12% (28/43)` :tada:
   
   [Increment coverage report](http://coverage.selectdb-in.cc/coverage/a7477003ff0b8e904671a043e67b6355ca151862_a7477003ff0b8e904671a043e67b6355ca151862/increment_report/index.html)
   [Complete coverage report](http://coverage.selectdb-in.cc/coverage/a7477003ff0b8e904671a043e67b6355ca151862_a7477003ff0b8e904671a043e67b6355ca151862/report/index.html)
   | Category          | Coverage           |
   |-------------------|--------------------|
   | Function Coverage | 54.10% (21097/38995) |
   | Line Coverage     | 37.60% (199917/531740) |
   | Region Coverage   | 33.81% (156496/462903) |
   | Branch Coverage   | 34.79% (68040/195595) |


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [fix](insert) enable_insert_strict should not affect semantic of enable_strict_cast [doris]

Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #63794:
URL: https://github.com/apache/doris/pull/63794#issuecomment-4624796133

   # FE UT Coverage Report
   Increment line coverage `  0.00% (0/1)` :tada:
   [Increment coverage report](http://coverage.selectdb-in.cc/coverage/63794_86993ac095ccef4e2e75e24343587151c4b5b82a/fe_increment_report/index.html)
   [Complete coverage report](http://coverage.selectdb-in.cc/coverage/63794_86993ac095ccef4e2e75e24343587151c4b5b82a/fe_report/index.html)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [fix](insert) enable_insert_strict should not affect semantic of enable_strict_cast [doris]

Posted by "jacktengg (via GitHub)" <gi...@apache.org>.
jacktengg commented on PR #63794:
URL: https://github.com/apache/doris/pull/63794#issuecomment-4627693648

   run buildall


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [fix](insert) enable_insert_strict should not affect semantic of enable_strict_cast [doris]

Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #63794:
URL: https://github.com/apache/doris/pull/63794#issuecomment-4629439419

   
   <details>
   <summary>TPC-H: <b>Total hot run time: 29399 ms</b></summary>
   
   ```
   machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
   scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
   Tpch sf100 test result on commit 47849b5a12634b460184e08da7d3acaf2dda2614, data reload: false
   
   ------ Round 1 ----------------------------------
   orders	Doris	NULL	NULL	0	0	0	NULL	0	NULL	NULL	2023-12-26 18:27:23	2023-12-26 18:42:55	NULL	utf-8	NULL	NULL	
   ============================================
   q1	17599	4021	4008	4008
   q2	q3	10749	1360	841	841
   q4	4690	482	353	353
   q5	7558	866	580	580
   q6	182	170	136	136
   q7	770	842	620	620
   q8	9335	1576	1633	1576
   q9	5872	4495	4486	4486
   q10	6769	1800	1564	1564
   q11	443	271	251	251
   q12	638	419	296	296
   q13	18111	3313	2792	2792
   q14	278	259	253	253
   q15	q16	791	786	717	717
   q17	953	958	882	882
   q18	6779	5752	5614	5614
   q19	1303	1297	1108	1108
   q20	520	407	262	262
   q21	6541	2823	2738	2738
   q22	461	372	322	322
   Total cold run time: 100342 ms
   Total hot run time: 29399 ms
   
   ----- Round 2, with runtime_filter_mode=off -----
   orders	Doris	NULL	NULL	150000000	42	6422171781	NULL	22778155	NULL	NULL	2023-12-26 18:27:23	2023-12-26 18:42:55	NULL	utf-8	NULL	NULL	
   ============================================
   q1	5140	4727	4827	4727
   q2	q3	4868	5343	4658	4658
   q4	2121	2198	1379	1379
   q5	4793	4787	4646	4646
   q6	226	183	130	130
   q7	1873	1858	1558	1558
   q8	2457	2109	2105	2105
   q9	7963	7559	7370	7370
   q10	4711	4693	4230	4230
   q11	526	379	354	354
   q12	731	729	519	519
   q13	3002	3407	2831	2831
   q14	269	277	248	248
   q15	q16	674	693	607	607
   q17	1272	1254	1242	1242
   q18	7337	6814	6806	6806
   q19	1088	1119	1090	1090
   q20	2218	2197	1945	1945
   q21	5221	4529	4408	4408
   q22	543	464	443	443
   Total cold run time: 57033 ms
   Total hot run time: 51296 ms
   ```
   </details>
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [fix](insert) enable_insert_strict should not affect semantic of enable_strict_cast [doris]

Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #63794:
URL: https://github.com/apache/doris/pull/63794#issuecomment-4625307055

   # FE Regression Coverage Report
   Increment line coverage `  100.00% (1/1)` :tada:
   [Increment coverage report](http://coverage.selectdb-in.cc/coverage/63794_86993ac095ccef4e2e75e24343587151c4b5b82a_merge_fe/increment_report/index.html)
   [Complete coverage report](http://coverage.selectdb-in.cc/coverage/63794_86993ac095ccef4e2e75e24343587151c4b5b82a_merge_fe/report/index.html)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [fix](insert) enable_insert_strict should not affect semantic of enable_strict_cast [doris]

Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #63794:
URL: https://github.com/apache/doris/pull/63794#issuecomment-4572878597

   
   <details>
   <summary>TPC-DS: <b>Total hot run time: 171986 ms</b></summary>
   
   ```
   machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
   scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
   TPC-DS sf100 test result on commit bb5943ab949b2a6819d177dcfc1871fbca65ea8d, data reload: false
   
   query5	4314	668	502	502
   query6	328	215	192	192
   query7	4279	562	318	318
   query8	331	229	215	215
   query9	8777	3967	3966	3966
   query10	475	357	296	296
   query11	5813	2393	2241	2241
   query12	179	127	131	127
   query13	1266	585	429	429
   query14	6148	5446	5175	5175
   query14_1	4506	4457	4487	4457
   query15	215	204	189	189
   query16	1026	463	437	437
   query17	1167	755	614	614
   query18	2756	493	363	363
   query19	244	201	170	170
   query20	141	138	129	129
   query21	216	141	117	117
   query22	13641	13601	13368	13368
   query23	17366	16451	16235	16235
   query23_1	16478	16355	16336	16336
   query24	7550	1811	1310	1310
   query24_1	1355	1338	1323	1323
   query25	572	521	436	436
   query26	1309	331	186	186
   query27	2724	597	361	361
   query28	4459	2023	2010	2010
   query29	975	649	535	535
   query30	304	245	203	203
   query31	1142	1072	967	967
   query32	82	78	73	73
   query33	553	351	285	285
   query34	1217	1158	661	661
   query35	777	810	713	713
   query36	1413	1433	1321	1321
   query37	155	106	91	91
   query38	3272	3253	3124	3124
   query39	984	954	937	937
   query39_1	918	926	924	924
   query40	244	152	126	126
   query41	65	68	63	63
   query42	111	109	110	109
   query43	329	334	314	314
   query44	
   query45	221	211	202	202
   query46	1144	1215	753	753
   query47	2432	2403	2334	2334
   query48	414	426	310	310
   query49	634	494	387	387
   query50	1043	347	260	260
   query51	4424	4376	4358	4358
   query52	107	106	95	95
   query53	258	285	208	208
   query54	317	262	263	262
   query55	95	94	89	89
   query56	319	320	315	315
   query57	1443	1438	1349	1349
   query58	289	270	271	270
   query59	1582	1635	1434	1434
   query60	320	365	316	316
   query61	156	147	154	147
   query62	708	648	576	576
   query63	241	199	205	199
   query64	2379	802	693	693
   query65	
   query66	1671	476	356	356
   query67	29622	29607	29580	29580
   query68	
   query69	475	336	307	307
   query70	1027	975	1009	975
   query71	309	266	266	266
   query72	3016	2706	2398	2398
   query73	852	814	436	436
   query74	5151	4951	4787	4787
   query75	2687	2588	2256	2256
   query76	2291	1185	834	834
   query77	414	409	339	339
   query78	12348	12385	11883	11883
   query79	1457	1077	748	748
   query80	1334	542	454	454
   query81	514	283	242	242
   query82	977	161	119	119
   query83	344	275	255	255
   query84	262	141	107	107
   query85	944	558	461	461
   query86	456	339	337	337
   query87	3432	3397	3252	3252
   query88	3612	2741	2718	2718
   query89	461	399	352	352
   query90	1907	179	181	179
   query91	181	166	142	142
   query92	75	75	73	73
   query93	1702	1463	859	859
   query94	725	352	273	273
   query95	681	398	429	398
   query96	1040	787	337	337
   query97	2720	2720	2654	2654
   query98	237	237	228	228
   query99	1180	1142	1037	1037
   Total cold run time: 255512 ms
   Total hot run time: 171986 ms
   ```
   </details>
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [fix](insert) enable_insert_strict should not affect semantic of enable_strict_cast [doris]

Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #63794:
URL: https://github.com/apache/doris/pull/63794#issuecomment-4602687144

   
   <details>
   <summary>TPC-DS: <b>Total hot run time: 169807 ms</b></summary>
   
   ```
   machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
   scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
   TPC-DS sf100 test result on commit c8cd6e136108e46c661fb2b59f2eb61ee1c449e9, data reload: false
   
   query5	4345	664	513	513
   query6	450	227	192	192
   query7	4835	550	323	323
   query8	370	222	209	209
   query9	8808	4043	4017	4017
   query10	462	318	267	267
   query11	5973	2361	2229	2229
   query12	156	109	99	99
   query13	1275	617	426	426
   query14	6391	5418	5099	5099
   query14_1	4401	4437	4420	4420
   query15	216	201	182	182
   query16	1005	483	454	454
   query17	1151	732	618	618
   query18	2539	485	356	356
   query19	204	190	145	145
   query20	115	110	108	108
   query21	212	138	125	125
   query22	13652	13621	13355	13355
   query23	17465	16535	16190	16190
   query23_1	16407	16432	16382	16382
   query24	7573	1744	1338	1338
   query24_1	1300	1318	1330	1318
   query25	584	472	407	407
   query26	1316	336	170	170
   query27	2654	575	345	345
   query28	4442	2060	2010	2010
   query29	1120	632	500	500
   query30	318	236	201	201
   query31	1128	1091	959	959
   query32	119	64	65	64
   query33	550	336	263	263
   query34	1169	1136	695	695
   query35	758	785	669	669
   query36	1379	1378	1249	1249
   query37	154	106	86	86
   query38	3210	3157	3069	3069
   query39	933	935	910	910
   query39_1	894	869	880	869
   query40	221	123	101	101
   query41	64	62	62	62
   query42	97	94	94	94
   query43	315	324	280	280
   query44	
   query45	199	186	180	180
   query46	1111	1202	714	714
   query47	2350	2431	2272	2272
   query48	361	392	283	283
   query49	631	472	351	351
   query50	950	356	259	259
   query51	4351	4341	4276	4276
   query52	87	87	78	78
   query53	254	267	189	189
   query54	270	222	198	198
   query55	81	76	71	71
   query56	243	224	231	224
   query57	1449	1403	1376	1376
   query58	243	219	214	214
   query59	1607	1661	1463	1463
   query60	281	251	248	248
   query61	158	159	155	155
   query62	697	652	587	587
   query63	231	185	187	185
   query64	2563	792	613	613
   query65	
   query66	1768	476	346	346
   query67	29719	29785	29507	29507
   query68	
   query69	427	315	262	262
   query70	960	967	956	956
   query71	296	229	196	196
   query72	3048	2719	2627	2627
   query73	843	790	434	434
   query74	5118	4926	4767	4767
   query75	2670	2618	2237	2237
   query76	2332	1144	764	764
   query77	358	384	285	285
   query78	12386	12501	11907	11907
   query79	1455	1084	780	780
   query80	591	488	382	382
   query81	447	284	250	250
   query82	584	161	126	126
   query83	358	271	250	250
   query84	265	144	113	113
   query85	867	563	438	438
   query86	369	304	271	271
   query87	3386	3407	3192	3192
   query88	3648	2735	2728	2728
   query89	448	383	330	330
   query90	1865	187	177	177
   query91	179	164	137	137
   query92	67	75	59	59
   query93	1561	1488	819	819
   query94	545	371	308	308
   query95	681	382	355	355
   query96	1026	784	348	348
   query97	2727	2710	2572	2572
   query98	216	212	200	200
   query99	1191	1168	1041	1041
   Total cold run time: 251499 ms
   Total hot run time: 169807 ms
   ```
   </details>
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [fix](insert) enable_insert_strict should not affect semantic of enable_strict_cast [doris]

Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #63794:
URL: https://github.com/apache/doris/pull/63794#issuecomment-4602720780

   
   <details>
   <summary>TPC-H: <b>Total hot run time: 29171 ms</b></summary>
   
   ```
   machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
   scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
   Tpch sf100 test result on commit edea4f7d83cdb6670ad2794b49e2dec676a3cf67, data reload: false
   
   ------ Round 1 ----------------------------------
   orders	Doris	NULL	NULL	0	0	0	NULL	0	NULL	NULL	2023-12-26 18:27:23	2023-12-26 18:42:55	NULL	utf-8	NULL	NULL	
   ============================================
   q1	17198	4059	4035	4035
   q2	q3	10537	1401	847	847
   q4	4680	483	358	358
   q5	7673	884	628	628
   q6	191	181	138	138
   q7	808	836	638	638
   q8	9441	1622	1586	1586
   q9	5863	4565	4511	4511
   q10	6771	1817	1564	1564
   q11	460	269	257	257
   q12	638	422	290	290
   q13	18124	3421	2784	2784
   q14	269	266	241	241
   q15	q16	819	802	708	708
   q17	996	986	900	900
   q18	7018	5872	5561	5561
   q19	2184	1326	1128	1128
   q20	504	413	265	265
   q21	5861	2567	2418	2418
   q22	437	364	314	314
   Total cold run time: 100472 ms
   Total hot run time: 29171 ms
   
   ----- Round 2, with runtime_filter_mode=off -----
   orders	Doris	NULL	NULL	150000000	42	6422171781	NULL	22778155	NULL	NULL	2023-12-26 18:27:23	2023-12-26 18:42:55	NULL	utf-8	NULL	NULL	
   ============================================
   q1	4477	4478	4351	4351
   q2	q3	4551	4976	4372	4372
   q4	2071	2199	1406	1406
   q5	4466	4364	4359	4359
   q6	230	174	130	130
   q7	1762	1979	1864	1864
   q8	2631	2263	2266	2263
   q9	8243	8348	8013	8013
   q10	4851	4801	4321	4321
   q11	573	422	380	380
   q12	819	750	550	550
   q13	3378	3674	2970	2970
   q14	294	295	279	279
   q15	q16	712	731	643	643
   q17	1378	1352	1507	1352
   q18	7692	7404	7277	7277
   q19	1199	1185	1099	1099
   q20	2239	2214	1949	1949
   q21	5304	4597	4463	4463
   q22	542	454	417	417
   Total cold run time: 57412 ms
   Total hot run time: 52458 ms
   ```
   </details>
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [fix](insert) enable_insert_strict should not affect semantic of enable_strict_cast [doris]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #63794:
URL: https://github.com/apache/doris/pull/63794#issuecomment-4594764609

   OpenCode automated review failed and did not complete.
   
   Error: Review step was skipped (possibly timeout or cancelled)
   Workflow run: https://github.com/apache/doris/actions/runs/26769267529
   
   Please inspect the workflow logs and rerun the review after the underlying issue is resolved.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [fix](insert) enable_insert_strict should not affect semantic of enable_strict_cast [doris]

Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #63794:
URL: https://github.com/apache/doris/pull/63794#issuecomment-4598318952

   # BE UT Coverage Report
   Increment line coverage `60.71% (17/28)` :tada:
   
   [Increment coverage report](http://coverage.selectdb-in.cc/coverage/0d281cab55900ad7146c36e00d8bb89cf304d4b4_0d281cab55900ad7146c36e00d8bb89cf304d4b4/increment_report/index.html)
   [Complete coverage report](http://coverage.selectdb-in.cc/coverage/0d281cab55900ad7146c36e00d8bb89cf304d4b4_0d281cab55900ad7146c36e00d8bb89cf304d4b4/report/index.html)
   | Category          | Coverage           |
   |-------------------|--------------------|
   | Function Coverage | 54.08% (21053/38926) |
   | Line Coverage     | 37.60% (199447/530433) |
   | Region Coverage   | 33.87% (156224/461245) |
   | Branch Coverage   | 34.84% (67928/194955) |


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [fix](insert) enable_insert_strict should not affect semantic of enable_strict_cast [doris]

Posted by "jacktengg (via GitHub)" <gi...@apache.org>.
jacktengg commented on PR #63794:
URL: https://github.com/apache/doris/pull/63794#issuecomment-4572594483

   run buildall


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [fix](insert) enable_insert_strict should not affect semantic of enable_strict_cast [doris]

Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #63794:
URL: https://github.com/apache/doris/pull/63794#issuecomment-4599977196

   # Cloud UT Coverage Report
   Increment line coverage ` ` :tada:
   
   [Increment coverage report](http://coverage.selectdb-in.cc/coverage/edea4f7d83cdb6670ad2794b49e2dec676a3cf67_edea4f7d83cdb6670ad2794b49e2dec676a3cf67_cloud/increment_report/index.html)
   [Complete coverage report](http://coverage.selectdb-in.cc/coverage/edea4f7d83cdb6670ad2794b49e2dec676a3cf67_edea4f7d83cdb6670ad2794b49e2dec676a3cf67_cloud/report/index.html)
   | Category          | Coverage           |
   |-------------------|--------------------|
   | Function Coverage | 78.34% (1906/2433) |
   | Line Coverage     | 64.76% (33979/52468) |
   | Region Coverage   | 65.30% (17523/26833) |
   | Branch Coverage   | 53.97% (9299/17230) |


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [fix](insert) enable_insert_strict should not affect semantic of enable_strict_cast [doris]

Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #63794:
URL: https://github.com/apache/doris/pull/63794#issuecomment-4599641119

   # FE UT Coverage Report
   Increment line coverage `  80.00% (4/5)` :tada:
   [Increment coverage report](http://coverage.selectdb-in.cc/coverage/63794_a7477003ff0b8e904671a043e67b6355ca151862/fe_increment_report/index.html)
   [Complete coverage report](http://coverage.selectdb-in.cc/coverage/63794_a7477003ff0b8e904671a043e67b6355ca151862/fe_report/index.html)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [fix](insert) enable_insert_strict should not affect semantic of enable_strict_cast [doris]

Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #63794:
URL: https://github.com/apache/doris/pull/63794#issuecomment-4602601982

   
   <details>
   <summary>TPC-H: <b>Total hot run time: 29051 ms</b></summary>
   
   ```
   machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
   scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
   Tpch sf100 test result on commit c8cd6e136108e46c661fb2b59f2eb61ee1c449e9, data reload: false
   
   ------ Round 1 ----------------------------------
   orders	Doris	NULL	NULL	0	0	0	NULL	0	NULL	NULL	2023-12-26 18:27:23	2023-12-26 18:42:55	NULL	utf-8	NULL	NULL	
   ============================================
   q1	17626	4065	4023	4023
   q2	q3	10764	1425	847	847
   q4	4742	486	352	352
   q5	8097	919	606	606
   q6	288	175	136	136
   q7	888	860	662	662
   q8	10891	1569	1537	1537
   q9	7452	4519	4500	4500
   q10	6878	1849	1580	1580
   q11	441	275	252	252
   q12	642	430	290	290
   q13	18077	3391	2736	2736
   q14	267	255	241	241
   q15	q16	822	800	709	709
   q17	1003	919	979	919
   q18	6945	5729	5561	5561
   q19	1175	1258	1037	1037
   q20	516	417	267	267
   q21	5485	2571	2495	2495
   q22	434	357	301	301
   Total cold run time: 103433 ms
   Total hot run time: 29051 ms
   
   ----- Round 2, with runtime_filter_mode=off -----
   orders	Doris	NULL	NULL	150000000	42	6422171781	NULL	22778155	NULL	NULL	2023-12-26 18:27:23	2023-12-26 18:42:55	NULL	utf-8	NULL	NULL	
   ============================================
   q1	4378	4310	4284	4284
   q2	q3	4570	5041	4372	4372
   q4	2104	2229	1382	1382
   q5	4479	4336	4380	4336
   q6	232	177	134	134
   q7	2364	1946	1699	1699
   q8	2638	2223	2206	2206
   q9	8320	7925	8010	7925
   q10	4834	4768	4328	4328
   q11	595	437	394	394
   q12	744	759	557	557
   q13	3302	3707	2935	2935
   q14	310	306	290	290
   q15	q16	736	743	647	647
   q17	1364	1338	1514	1338
   q18	8042	7451	7232	7232
   q19	1180	1117	1110	1110
   q20	2233	2253	1934	1934
   q21	5332	4639	4500	4500
   q22	508	449	409	409
   Total cold run time: 58265 ms
   Total hot run time: 52012 ms
   ```
   </details>
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [fix](insert) enable_insert_strict should not affect semantic of enable_strict_cast [doris]

Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #63794:
URL: https://github.com/apache/doris/pull/63794#issuecomment-4624349256

   
   <details>
   <summary>TPC-H: <b>Total hot run time: 29504 ms</b></summary>
   
   ```
   machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
   scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
   Tpch sf100 test result on commit 86993ac095ccef4e2e75e24343587151c4b5b82a, data reload: false
   
   ------ Round 1 ----------------------------------
   orders	Doris	NULL	NULL	0	0	0	NULL	0	NULL	NULL	2023-12-26 18:27:23	2023-12-26 18:42:55	NULL	utf-8	NULL	NULL	
   ============================================
   q1	17662	4259	4282	4259
   q2	q3	10772	1459	913	913
   q4	4684	475	347	347
   q5	7523	876	594	594
   q6	178	176	142	142
   q7	766	871	640	640
   q8	9376	1528	1576	1528
   q9	5873	4457	4461	4457
   q10	6777	1804	1551	1551
   q11	450	274	252	252
   q12	634	446	303	303
   q13	18105	3421	2746	2746
   q14	271	261	255	255
   q15	q16	826	778	712	712
   q17	1001	888	930	888
   q18	6802	5896	5465	5465
   q19	1362	1333	1110	1110
   q20	529	431	282	282
   q21	6249	2846	2744	2744
   q22	477	410	316	316
   Total cold run time: 100317 ms
   Total hot run time: 29504 ms
   
   ----- Round 2, with runtime_filter_mode=off -----
   orders	Doris	NULL	NULL	150000000	42	6422171781	NULL	22778155	NULL	NULL	2023-12-26 18:27:23	2023-12-26 18:42:55	NULL	utf-8	NULL	NULL	
   ============================================
   q1	5429	5114	5134	5114
   q2	q3	4884	5266	4789	4789
   q4	2151	2215	1430	1430
   q5	4777	4874	4722	4722
   q6	239	182	142	142
   q7	1932	1735	1660	1660
   q8	2496	2218	2176	2176
   q9	8021	7904	7413	7413
   q10	4764	4651	4205	4205
   q11	543	391	354	354
   q12	733	738	530	530
   q13	3002	3410	2789	2789
   q14	286	287	254	254
   q15	q16	695	704	610	610
   q17	1277	1261	1275	1261
   q18	7218	6721	7028	6721
   q19	1135	1111	1086	1086
   q20	2231	2234	1956	1956
   q21	5361	4724	4544	4544
   q22	531	470	406	406
   Total cold run time: 57705 ms
   Total hot run time: 52162 ms
   ```
   </details>
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [fix](insert) enable_insert_strict should not affect semantic of enable_strict_cast [doris]

Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #63794:
URL: https://github.com/apache/doris/pull/63794#issuecomment-4630832386

   # FE Regression Coverage Report
   Increment line coverage `  1.02% (1/98)` :tada:
   [Increment coverage report](http://coverage.selectdb-in.cc/coverage/63794_47849b5a12634b460184e08da7d3acaf2dda2614_merge_fe/increment_report/index.html)
   [Complete coverage report](http://coverage.selectdb-in.cc/coverage/63794_47849b5a12634b460184e08da7d3acaf2dda2614_merge_fe/report/index.html)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [fix](insert) enable_insert_strict should not affect semantic of enable_strict_cast [doris]

Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #63794:
URL: https://github.com/apache/doris/pull/63794#issuecomment-4572776692

   
   <details>
   <summary>TPC-H: <b>Total hot run time: 31027 ms</b></summary>
   
   ```
   machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
   scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
   Tpch sf100 test result on commit bb5943ab949b2a6819d177dcfc1871fbca65ea8d, data reload: false
   
   ------ Round 1 ----------------------------------
   orders	Doris	NULL	NULL	0	0	0	NULL	0	NULL	NULL	2023-12-26 18:27:23	2023-12-26 18:42:55	NULL	utf-8	NULL	NULL	
   ============================================
   q1	17629	4006	4003	4003
   q2	q3	10761	1348	819	819
   q4	4683	484	350	350
   q5	7590	2418	2101	2101
   q6	253	177	136	136
   q7	915	786	637	637
   q8	9372	1635	1511	1511
   q9	6218	4995	4917	4917
   q10	6433	2213	1884	1884
   q11	433	272	245	245
   q12	692	433	294	294
   q13	18209	3397	2781	2781
   q14	271	259	234	234
   q15	q16	814	767	702	702
   q17	1105	919	951	919
   q18	7342	5860	5549	5549
   q19	1352	1350	1102	1102
   q20	515	390	253	253
   q21	5615	2621	2290	2290
   q22	427	355	300	300
   Total cold run time: 100629 ms
   Total hot run time: 31027 ms
   
   ----- Round 2, with runtime_filter_mode=off -----
   orders	Doris	NULL	NULL	150000000	42	6422171781	NULL	22778155	NULL	NULL	2023-12-26 18:27:23	2023-12-26 18:42:55	NULL	utf-8	NULL	NULL	
   ============================================
   q1	4388	4357	4261	4261
   q2	q3	4563	4966	4328	4328
   q4	2098	2223	1399	1399
   q5	4424	4295	4608	4295
   q6	264	225	155	155
   q7	1945	1875	1625	1625
   q8	2519	2133	2189	2133
   q9	8051	8023	8007	8007
   q10	4887	4836	4303	4303
   q11	560	400	375	375
   q12	744	772	564	564
   q13	3279	3594	3017	3017
   q14	317	323	278	278
   q15	q16	739	734	658	658
   q17	1368	1348	1344	1344
   q18	7864	7361	6716	6716
   q19	1137	1105	1160	1105
   q20	2210	2228	1951	1951
   q21	5286	4642	4465	4465
   q22	512	457	420	420
   Total cold run time: 57155 ms
   Total hot run time: 51399 ms
   ```
   </details>
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [fix](insert) enable_insert_strict should not affect semantic of enable_strict_cast [doris]

Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #63794:
URL: https://github.com/apache/doris/pull/63794#issuecomment-4602938811

   # BE Regression && UT Coverage Report
   Increment line coverage `100.00% (43/43)` :tada:
   
   [Increment coverage report](http://coverage.selectdb-in.cc/coverage/63794_edea4f7d83cdb6670ad2794b49e2dec676a3cf67_merge/increment_report/index.html)
   [Complete coverage report](http://coverage.selectdb-in.cc/coverage/63794_edea4f7d83cdb6670ad2794b49e2dec676a3cf67_merge/report/index.html)
   | Category          | Coverage           |
   |-------------------|--------------------|
   | Function Coverage | 72.23% (27603/38217) |
   | Line Coverage     | 55.57% (295209/531237) |
   | Region Coverage   | 52.32% (246782/471699) |
   | Branch Coverage   | 53.51% (106541/199116) |


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [fix](insert) enable_insert_strict should not affect semantic of enable_strict_cast [doris]

Posted by "jacktengg (via GitHub)" <gi...@apache.org>.
jacktengg commented on PR #63794:
URL: https://github.com/apache/doris/pull/63794#issuecomment-4598588628

   run buildall


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [fix](insert) enable_insert_strict should not affect semantic of enable_strict_cast [doris]

Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #63794:
URL: https://github.com/apache/doris/pull/63794#issuecomment-4629520741

   
   <details>
   <summary>TPC-DS: <b>Total hot run time: 170997 ms</b></summary>
   
   ```
   machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
   scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
   TPC-DS sf100 test result on commit 47849b5a12634b460184e08da7d3acaf2dda2614, data reload: false
   
   query5	4349	623	470	470
   query6	428	196	201	196
   query7	4895	552	298	298
   query8	388	224	220	220
   query9	8814	4149	4131	4131
   query10	458	339	266	266
   query11	5938	2378	2166	2166
   query12	159	103	97	97
   query13	1293	634	415	415
   query14	6404	5466	5200	5200
   query14_1	4550	4455	4455	4455
   query15	208	203	179	179
   query16	997	433	455	433
   query17	1131	715	604	604
   query18	2484	483	354	354
   query19	210	187	153	153
   query20	118	109	107	107
   query21	216	141	121	121
   query22	13660	13628	13426	13426
   query23	17434	16658	16239	16239
   query23_1	16409	16394	16448	16394
   query24	7430	1780	1319	1319
   query24_1	1322	1349	1334	1334
   query25	580	503	414	414
   query26	1299	323	176	176
   query27	2727	563	345	345
   query28	4455	2072	2068	2068
   query29	1100	635	507	507
   query30	316	236	209	209
   query31	1125	1087	973	973
   query32	113	65	65	65
   query33	537	350	290	290
   query34	1194	1115	654	654
   query35	772	780	686	686
   query36	1392	1384	1216	1216
   query37	149	101	89	89
   query38	3212	3203	3080	3080
   query39	933	935	892	892
   query39_1	887	872	877	872
   query40	220	121	100	100
   query41	68	62	61	61
   query42	93	93	90	90
   query43	321	323	282	282
   query44	
   query45	198	181	183	181
   query46	1080	1199	755	755
   query47	2373	2374	2255	2255
   query48	401	426	293	293
   query49	630	472	375	375
   query50	1029	348	277	277
   query51	4406	4458	4201	4201
   query52	88	89	77	77
   query53	241	272	190	190
   query54	262	234	200	200
   query55	80	74	70	70
   query56	233	218	226	218
   query57	1433	1399	1304	1304
   query58	247	217	212	212
   query59	1614	1657	1472	1472
   query60	280	244	226	226
   query61	162	157	158	157
   query62	701	668	586	586
   query63	231	188	185	185
   query64	2552	778	608	608
   query65	
   query66	1778	454	345	345
   query67	29941	29742	29605	29605
   query68	
   query69	434	322	261	261
   query70	981	1007	966	966
   query71	311	227	206	206
   query72	2995	2759	2431	2431
   query73	874	773	451	451
   query74	5137	4952	4810	4810
   query75	2694	2571	2255	2255
   query76	2305	1156	782	782
   query77	358	373	288	288
   query78	12529	12574	11795	11795
   query79	1410	1063	797	797
   query80	784	472	409	409
   query81	486	280	246	246
   query82	572	158	125	125
   query83	342	281	260	260
   query84	253	144	109	109
   query85	916	534	437	437
   query86	408	302	288	288
   query87	3434	3340	3198	3198
   query88	3643	2771	2745	2745
   query89	439	390	334	334
   query90	1904	175	177	175
   query91	178	164	135	135
   query92	67	63	57	57
   query93	1439	1519	884	884
   query94	632	364	296	296
   query95	715	373	362	362
   query96	1089	790	345	345
   query97	2719	2694	2600	2600
   query98	217	207	204	204
   query99	1174	1202	1035	1035
   Total cold run time: 252390 ms
   Total hot run time: 170997 ms
   ```
   </details>
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [fix](insert) enable_insert_strict should not affect semantic of enable_strict_cast [doris]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #63794:
URL: https://github.com/apache/doris/pull/63794#issuecomment-4646272187

   PR approved by anyone and no changes requested.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [fix](insert) enable_insert_strict should not affect semantic of enable_strict_cast [doris]

Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #63794:
URL: https://github.com/apache/doris/pull/63794#issuecomment-4601947133

   # FE Regression Coverage Report
   Increment line coverage `  1.06% (4/379)` :tada:
   [Increment coverage report](http://coverage.selectdb-in.cc/coverage/63794_edea4f7d83cdb6670ad2794b49e2dec676a3cf67_merge_fe/increment_report/index.html)
   [Complete coverage report](http://coverage.selectdb-in.cc/coverage/63794_edea4f7d83cdb6670ad2794b49e2dec676a3cf67_merge_fe/report/index.html)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [fix](insert) enable_insert_strict should not affect semantic of enable_strict_cast [doris]

Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #63794:
URL: https://github.com/apache/doris/pull/63794#issuecomment-4628796513

   # FE Regression Coverage Report
   Increment line coverage `  100.00% (1/1)` :tada:
   [Increment coverage report](http://coverage.selectdb-in.cc/coverage/63794_47849b5a12634b460184e08da7d3acaf2dda2614_merge_fe/increment_report/index.html)
   [Complete coverage report](http://coverage.selectdb-in.cc/coverage/63794_47849b5a12634b460184e08da7d3acaf2dda2614_merge_fe/report/index.html)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [fix](insert) enable_insert_strict should not affect semantic of enable_strict_cast [doris]

Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #63794:
URL: https://github.com/apache/doris/pull/63794#issuecomment-4624436216

   
   <details>
   <summary>TPC-DS: <b>Total hot run time: 168853 ms</b></summary>
   
   ```
   machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
   scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
   TPC-DS sf100 test result on commit 86993ac095ccef4e2e75e24343587151c4b5b82a, data reload: false
   
   query5	4341	633	469	469
   query6	437	204	177	177
   query7	4823	580	315	315
   query8	372	214	210	210
   query9	8745	4015	3981	3981
   query10	439	306	243	243
   query11	5948	2339	2193	2193
   query12	153	103	111	103
   query13	1259	622	429	429
   query14	6418	5408	5019	5019
   query14_1	4353	4319	4379	4319
   query15	202	196	175	175
   query16	985	444	415	415
   query17	919	703	580	580
   query18	2427	488	342	342
   query19	195	181	142	142
   query20	123	105	107	105
   query21	212	138	116	116
   query22	13657	13520	13414	13414
   query23	17275	16441	16020	16020
   query23_1	16248	16283	16291	16283
   query24	7508	1782	1303	1303
   query24_1	1320	1356	1330	1330
   query25	571	449	452	449
   query26	1305	326	164	164
   query27	2680	574	355	355
   query28	4499	2058	2006	2006
   query29	1070	605	481	481
   query30	317	242	197	197
   query31	1112	1064	950	950
   query32	96	61	57	57
   query33	516	313	248	248
   query34	1209	1172	654	654
   query35	743	809	675	675
   query36	1396	1423	1233	1233
   query37	154	106	90	90
   query38	3195	3119	3053	3053
   query39	927	956	895	895
   query39_1	884	880	885	880
   query40	222	120	103	103
   query41	64	63	65	63
   query42	96	95	92	92
   query43	313	320	276	276
   query44	
   query45	193	181	183	181
   query46	1130	1199	749	749
   query47	2376	2336	2233	2233
   query48	407	418	294	294
   query49	624	469	358	358
   query50	1025	364	272	272
   query51	4317	4300	4277	4277
   query52	88	90	79	79
   query53	246	271	185	185
   query54	272	229	203	203
   query55	78	77	71	71
   query56	257	232	212	212
   query57	1416	1393	1324	1324
   query58	265	231	228	228
   query59	1593	1693	1462	1462
   query60	306	264	249	249
   query61	182	185	183	183
   query62	688	658	584	584
   query63	225	191	191	191
   query64	2625	836	693	693
   query65	
   query66	1810	475	386	386
   query67	29747	29716	29543	29543
   query68	
   query69	423	304	264	264
   query70	979	964	888	888
   query71	304	229	212	212
   query72	2990	2521	2344	2344
   query73	868	840	409	409
   query74	5114	4978	4757	4757
   query75	2644	2568	2252	2252
   query76	2309	1174	791	791
   query77	350	375	295	295
   query78	12336	12537	11751	11751
   query79	1261	1079	799	799
   query80	538	475	399	399
   query81	449	284	244	244
   query82	224	153	119	119
   query83	350	308	256	256
   query84	311	145	117	117
   query85	836	524	426	426
   query86	323	325	292	292
   query87	3357	3336	3148	3148
   query88	3666	2760	2744	2744
   query89	422	380	332	332
   query90	2209	181	172	172
   query91	176	174	136	136
   query92	66	62	61	61
   query93	1467	1428	826	826
   query94	550	367	330	330
   query95	685	387	368	368
   query96	1022	849	376	376
   query97	2684	2703	2564	2564
   query98	208	202	203	202
   query99	1153	1169	1042	1042
   Total cold run time: 250086 ms
   Total hot run time: 168853 ms
   ```
   </details>
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [fix](insert) enable_insert_strict should not affect semantic of enable_strict_cast [doris]

Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #63794:
URL: https://github.com/apache/doris/pull/63794#issuecomment-4561364957

   
   Thank you for your contribution to Apache Doris.
   Don't know what should be done next? See [How to process your PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+your+PR).
   
   Please clearly describe your PR:
   1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
   2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
   3. What features were added. Why was this function added?
   4. Which code was refactored and why was this part of the code refactored?
   5. Which functions were optimized and what is the difference before and after the optimization?
       


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [fix](insert) enable_insert_strict should not affect semantic of enable_strict_cast [doris]

Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #63794:
URL: https://github.com/apache/doris/pull/63794#issuecomment-4561888367

   # FE UT Coverage Report
   Increment line coverage `` :tada:
   [Increment coverage report](http://coverage.selectdb-in.cc/coverage/63794_0d84131c6b670a5844337a143b0e1ef2826e7423/fe_increment_report/index.html)
   [Complete coverage report](http://coverage.selectdb-in.cc/coverage/63794_0d84131c6b670a5844337a143b0e1ef2826e7423/fe_report/index.html)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [fix](insert) enable_insert_strict should not affect semantic of enable_strict_cast [doris]

Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #63794:
URL: https://github.com/apache/doris/pull/63794#issuecomment-4562553328

   # FE Regression Coverage Report
   Increment line coverage `  0.00% (0/61)` :tada:
   [Increment coverage report](http://coverage.selectdb-in.cc/coverage/63794_0d84131c6b670a5844337a143b0e1ef2826e7423_merge_fe/increment_report/index.html)
   [Complete coverage report](http://coverage.selectdb-in.cc/coverage/63794_0d84131c6b670a5844337a143b0e1ef2826e7423_merge_fe/report/index.html)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [fix](insert) enable_insert_strict should not affect semantic of enable_strict_cast [doris]

Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #63794:
URL: https://github.com/apache/doris/pull/63794#issuecomment-4573264016

   # BE UT Coverage Report
   Increment line coverage `100.00% (1/1)` :tada:
   
   [Increment coverage report](http://coverage.selectdb-in.cc/coverage/bb5943ab949b2a6819d177dcfc1871fbca65ea8d_bb5943ab949b2a6819d177dcfc1871fbca65ea8d/increment_report/index.html)
   [Complete coverage report](http://coverage.selectdb-in.cc/coverage/bb5943ab949b2a6819d177dcfc1871fbca65ea8d_bb5943ab949b2a6819d177dcfc1871fbca65ea8d/report/index.html)
   | Category          | Coverage           |
   |-------------------|--------------------|
   | Function Coverage | 53.99% (20997/38891) |
   | Line Coverage     | 37.53% (199001/530184) |
   | Region Coverage   | 33.83% (156056/461234) |
   | Branch Coverage   | 34.81% (67903/195059) |


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [fix](insert) enable_insert_strict should not affect semantic of enable_strict_cast [doris]

Posted by "jacktengg (via GitHub)" <gi...@apache.org>.
jacktengg commented on PR #63794:
URL: https://github.com/apache/doris/pull/63794#issuecomment-4598002487

   /review


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [fix](insert) enable_insert_strict should not affect semantic of enable_strict_cast [doris]

Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #63794:
URL: https://github.com/apache/doris/pull/63794#issuecomment-4595512763

   
   <details>
   <summary>TPC-H: <b>Total hot run time: 29442 ms</b></summary>
   
   ```
   machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
   scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
   Tpch sf100 test result on commit 4fb49ca1dda051475d6603b70ba376073fe49865, data reload: false
   
   ------ Round 1 ----------------------------------
   orders	Doris	NULL	NULL	0	0	0	NULL	0	NULL	NULL	2023-12-26 18:27:23	2023-12-26 18:42:55	NULL	utf-8	NULL	NULL	
   ============================================
   q1	17639	4063	4000	4000
   q2	q3	10740	1436	839	839
   q4	4689	483	349	349
   q5	7654	896	589	589
   q6	183	174	139	139
   q7	781	878	651	651
   q8	9369	1670	1628	1628
   q9	6040	4502	4579	4502
   q10	6745	1841	1578	1578
   q11	434	279	257	257
   q12	632	430	289	289
   q13	18097	3309	2844	2844
   q14	271	262	237	237
   q15	q16	796	784	709	709
   q17	966	1049	1028	1028
   q18	7290	5656	5580	5580
   q19	1175	1289	972	972
   q20	516	413	261	261
   q21	5906	2836	2675	2675
   q22	474	390	315	315
   Total cold run time: 100397 ms
   Total hot run time: 29442 ms
   
   ----- Round 2, with runtime_filter_mode=off -----
   orders	Doris	NULL	NULL	150000000	42	6422171781	NULL	22778155	NULL	NULL	2023-12-26 18:27:23	2023-12-26 18:42:55	NULL	utf-8	NULL	NULL	
   ============================================
   q1	5175	4752	4775	4752
   q2	q3	4874	5302	4705	4705
   q4	2104	2172	1443	1443
   q5	4816	4825	4673	4673
   q6	230	180	135	135
   q7	1860	1760	1571	1571
   q8	2394	2182	2114	2114
   q9	7965	7963	7349	7349
   q10	4761	4692	4190	4190
   q11	537	384	357	357
   q12	740	731	533	533
   q13	3017	3356	2760	2760
   q14	269	280	264	264
   q15	q16	684	704	612	612
   q17	1275	1255	1249	1249
   q18	7257	6668	6789	6668
   q19	1145	1102	1094	1094
   q20	2225	2203	1941	1941
   q21	5347	4591	4445	4445
   q22	543	455	417	417
   Total cold run time: 57218 ms
   Total hot run time: 51272 ms
   ```
   </details>
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [fix](insert) enable_insert_strict should not affect semantic of enable_strict_cast [doris]

Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #63794:
URL: https://github.com/apache/doris/pull/63794#issuecomment-4595589072

   
   <details>
   <summary>TPC-DS: <b>Total hot run time: 170890 ms</b></summary>
   
   ```
   machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
   scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
   TPC-DS sf100 test result on commit 4fb49ca1dda051475d6603b70ba376073fe49865, data reload: false
   
   query5	4321	686	530	530
   query6	328	224	199	199
   query7	4313	585	319	319
   query8	330	237	236	236
   query9	8815	4019	4020	4019
   query10	450	340	301	301
   query11	5768	2359	2230	2230
   query12	196	132	129	129
   query13	1283	608	426	426
   query14	6134	5470	5185	5185
   query14_1	4481	4491	4452	4452
   query15	214	206	184	184
   query16	1013	463	423	423
   query17	1123	715	592	592
   query18	2721	497	342	342
   query19	225	208	178	178
   query20	144	137	129	129
   query21	214	133	116	116
   query22	13600	13571	13399	13399
   query23	17493	16433	16273	16273
   query23_1	16377	16371	16400	16371
   query24	7476	1756	1327	1327
   query24_1	1297	1305	1314	1305
   query25	563	492	442	442
   query26	1303	319	172	172
   query27	2684	579	349	349
   query28	4392	2033	2051	2033
   query29	963	628	538	538
   query30	315	231	198	198
   query31	1134	1061	958	958
   query32	86	77	76	76
   query33	549	373	288	288
   query34	1172	1143	648	648
   query35	791	798	692	692
   query36	1382	1462	1278	1278
   query37	175	105	90	90
   query38	3214	3158	3080	3080
   query39	934	926	898	898
   query39_1	877	875	871	871
   query40	228	148	127	127
   query41	66	61	60	60
   query42	113	111	111	111
   query43	336	331	291	291
   query44	
   query45	218	202	198	198
   query46	1105	1164	720	720
   query47	2410	2385	2262	2262
   query48	430	410	294	294
   query49	630	507	385	385
   query50	1011	358	252	252
   query51	4309	4277	4237	4237
   query52	108	107	98	98
   query53	260	284	209	209
   query54	309	283	258	258
   query55	94	95	88	88
   query56	314	322	312	312
   query57	1446	1417	1303	1303
   query58	310	278	275	275
   query59	1543	1699	1458	1458
   query60	335	329	309	309
   query61	166	157	156	156
   query62	698	668	549	549
   query63	244	205	208	205
   query64	2399	864	696	696
   query65	
   query66	1682	485	381	381
   query67	29052	29620	29584	29584
   query68	
   query69	475	388	300	300
   query70	1088	1014	1017	1014
   query71	329	275	275	275
   query72	2964	2714	2432	2432
   query73	842	776	420	420
   query74	5172	4946	4772	4772
   query75	2694	2595	2265	2265
   query76	2272	1159	798	798
   query77	406	409	321	321
   query78	12309	12335	11916	11916
   query79	1268	1023	800	800
   query80	581	540	479	479
   query81	452	278	241	241
   query82	241	153	133	133
   query83	281	276	275	275
   query84	257	139	113	113
   query85	854	553	453	453
   query86	351	347	340	340
   query87	3456	3389	3254	3254
   query88	3640	2740	2724	2724
   query89	426	397	341	341
   query90	2183	179	180	179
   query91	173	164	138	138
   query92	78	79	77	77
   query93	1350	1521	918	918
   query94	545	344	302	302
   query95	657	495	348	348
   query96	1108	809	322	322
   query97	2727	2715	2583	2583
   query98	239	229	224	224
   query99	1173	1188	1041	1041
   Total cold run time: 252028 ms
   Total hot run time: 170890 ms
   ```
   </details>
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [fix](insert) enable_insert_strict should not affect semantic of enable_strict_cast [doris]

Posted by "jacktengg (via GitHub)" <gi...@apache.org>.
jacktengg commented on PR #63794:
URL: https://github.com/apache/doris/pull/63794#issuecomment-4599025608

   /review


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [fix](insert) enable_insert_strict should not affect semantic of enable_strict_cast [doris]

Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #63794:
URL: https://github.com/apache/doris/pull/63794#issuecomment-4602905591

   # BE UT Coverage Report
   Increment line coverage `39.53% (17/43)` :tada:
   
   [Increment coverage report](http://coverage.selectdb-in.cc/coverage/edea4f7d83cdb6670ad2794b49e2dec676a3cf67_edea4f7d83cdb6670ad2794b49e2dec676a3cf67/increment_report/index.html)
   [Complete coverage report](http://coverage.selectdb-in.cc/coverage/edea4f7d83cdb6670ad2794b49e2dec676a3cf67_edea4f7d83cdb6670ad2794b49e2dec676a3cf67/report/index.html)
   | Category          | Coverage           |
   |-------------------|--------------------|
   | Function Coverage | 54.18% (21146/39028) |
   | Line Coverage     | 37.71% (200882/532678) |
   | Region Coverage   | 33.81% (158023/467332) |
   | Branch Coverage   | 34.80% (69029/198386) |


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [fix](insert) enable_insert_strict should not affect semantic of enable_strict_cast [doris]

Posted by "yiguolei (via GitHub)" <gi...@apache.org>.
yiguolei merged PR #63794:
URL: https://github.com/apache/doris/pull/63794


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [fix](insert) enable_insert_strict should not affect semantic of enable_strict_cast [doris]

Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #63794:
URL: https://github.com/apache/doris/pull/63794#issuecomment-4561747704

   
   <details>
   <summary>TPC-H: <b>Total hot run time: 31650 ms</b></summary>
   
   ```
   machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
   scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
   Tpch sf100 test result on commit 0d84131c6b670a5844337a143b0e1ef2826e7423, data reload: false
   
   ------ Round 1 ----------------------------------
   orders	Doris	NULL	NULL	0	0	0	NULL	0	NULL	NULL	2023-12-26 18:27:23	2023-12-26 18:42:55	NULL	utf-8	NULL	NULL	
   ============================================
   q1	17825	4153	4119	4119
   q2	q3	10759	1402	817	817
   q4	4695	512	344	344
   q5	7704	2272	2112	2112
   q6	255	191	138	138
   q7	972	772	651	651
   q8	9386	1770	1617	1617
   q9	5212	5001	5030	5001
   q10	6380	2223	1894	1894
   q11	441	285	246	246
   q12	635	439	296	296
   q13	18104	3439	2814	2814
   q14	265	258	230	230
   q15	q16	810	772	710	710
   q17	878	938	953	938
   q18	7228	5733	5617	5617
   q19	1170	1261	1081	1081
   q20	527	411	263	263
   q21	5664	2582	2462	2462
   q22	435	361	300	300
   Total cold run time: 99345 ms
   Total hot run time: 31650 ms
   
   ----- Round 2, with runtime_filter_mode=off -----
   orders	Doris	NULL	NULL	150000000	42	6422171781	NULL	22778155	NULL	NULL	2023-12-26 18:27:23	2023-12-26 18:42:55	NULL	utf-8	NULL	NULL	
   ============================================
   q1	4440	4390	4367	4367
   q2	q3	4538	4948	4353	4353
   q4	2140	2210	1382	1382
   q5	4531	4355	4534	4355
   q6	304	210	165	165
   q7	2157	2017	1684	1684
   q8	2666	2349	2292	2292
   q9	8393	8012	8056	8012
   q10	4843	4726	4317	4317
   q11	637	434	406	406
   q12	756	761	536	536
   q13	3347	3595	3000	3000
   q14	308	299	283	283
   q15	q16	714	738	652	652
   q17	1419	1370	1496	1370
   q18	7968	7455	7244	7244
   q19	1165	1130	1103	1103
   q20	2224	2203	1945	1945
   q21	5343	4519	4455	4455
   q22	518	463	402	402
   Total cold run time: 58411 ms
   Total hot run time: 52323 ms
   ```
   </details>
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [fix](insert) enable_insert_strict should not affect semantic of enable_strict_cast [doris]

Posted by "jacktengg (via GitHub)" <gi...@apache.org>.
jacktengg commented on PR #63794:
URL: https://github.com/apache/doris/pull/63794#issuecomment-4624190359

   run buildall


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [fix](insert) enable_insert_strict should not affect semantic of enable_strict_cast [doris]

Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #63794:
URL: https://github.com/apache/doris/pull/63794#issuecomment-4574182221

   # BE Regression && UT Coverage Report
   Increment line coverage `100.00% (1/1)` :tada:
   
   [Increment coverage report](http://coverage.selectdb-in.cc/coverage/63794_bb5943ab949b2a6819d177dcfc1871fbca65ea8d_merge/increment_report/index.html)
   [Complete coverage report](http://coverage.selectdb-in.cc/coverage/63794_bb5943ab949b2a6819d177dcfc1871fbca65ea8d_merge/report/index.html)
   | Category          | Coverage           |
   |-------------------|--------------------|
   | Function Coverage | 57.94% (22070/38089) |
   | Line Coverage     | 41.23% (218024/528836) |
   | Region Coverage   | 37.53% (174755/465654) |
   | Branch Coverage   | 38.41% (75210/195789) |


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [fix](insert) enable_insert_strict should not affect semantic of enable_strict_cast [doris]

Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #63794:
URL: https://github.com/apache/doris/pull/63794#issuecomment-4655601805

   /review


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [fix](insert) enable_insert_strict should not affect semantic of enable_strict_cast [doris]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #63794:
URL: https://github.com/apache/doris/pull/63794#issuecomment-4646271897

   PR approved by at least one committer and no changes requested.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [fix](insert) enable_insert_strict should not affect semantic of enable_strict_cast [doris]

Posted by "jacktengg (via GitHub)" <gi...@apache.org>.
jacktengg commented on PR #63794:
URL: https://github.com/apache/doris/pull/63794#issuecomment-4594712843

   /review


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [fix](insert) enable_insert_strict should not affect semantic of enable_strict_cast [doris]

Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #63794:
URL: https://github.com/apache/doris/pull/63794#issuecomment-4596071468

   # BE UT Coverage Report
   Increment line coverage `60.71% (17/28)` :tada:
   
   [Increment coverage report](http://coverage.selectdb-in.cc/coverage/4fb49ca1dda051475d6603b70ba376073fe49865_4fb49ca1dda051475d6603b70ba376073fe49865/increment_report/index.html)
   [Complete coverage report](http://coverage.selectdb-in.cc/coverage/4fb49ca1dda051475d6603b70ba376073fe49865_4fb49ca1dda051475d6603b70ba376073fe49865/report/index.html)
   | Category          | Coverage           |
   |-------------------|--------------------|
   | Function Coverage | 54.08% (21053/38926) |
   | Line Coverage     | 37.60% (199441/530433) |
   | Region Coverage   | 33.87% (156214/461245) |
   | Branch Coverage   | 34.84% (67915/194955) |


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [fix](insert) enable_insert_strict should not affect semantic of enable_strict_cast [doris]

Posted by "jacktengg (via GitHub)" <gi...@apache.org>.
jacktengg commented on PR #63794:
URL: https://github.com/apache/doris/pull/63794#issuecomment-4597986229

   run buildall


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [fix](insert) enable_insert_strict should not affect semantic of enable_strict_cast [doris]

Posted by "jacktengg (via GitHub)" <gi...@apache.org>.
jacktengg commented on PR #63794:
URL: https://github.com/apache/doris/pull/63794#issuecomment-4594712049

   run buildall


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [fix](insert) enable_insert_strict should not affect semantic of enable_strict_cast [doris]

Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #63794:
URL: https://github.com/apache/doris/pull/63794#issuecomment-4596672110

   # BE Regression && UT Coverage Report
   Increment line coverage `100.00% (28/28)` :tada:
   
   [Increment coverage report](http://coverage.selectdb-in.cc/coverage/63794_4fb49ca1dda051475d6603b70ba376073fe49865_merge/increment_report/index.html)
   [Complete coverage report](http://coverage.selectdb-in.cc/coverage/63794_4fb49ca1dda051475d6603b70ba376073fe49865_merge/report/index.html)
   | Category          | Coverage           |
   |-------------------|--------------------|
   | Function Coverage | 73.90% (28168/38115) |
   | Line Coverage     | 57.81% (305849/529056) |
   | Region Coverage   | 54.78% (255110/465672) |
   | Branch Coverage   | 56.43% (110438/195705) |


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [fix](insert) enable_insert_strict should not affect semantic of enable_strict_cast [doris]

Posted by "jacktengg (via GitHub)" <gi...@apache.org>.
jacktengg commented on PR #63794:
URL: https://github.com/apache/doris/pull/63794#issuecomment-4572255427

   /review


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [fix](insert) enable_insert_strict should not affect semantic of enable_strict_cast [doris]

Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #63794:
URL: https://github.com/apache/doris/pull/63794#issuecomment-4574232668

   # FE Regression Coverage Report
   Increment line coverage `  100.00% (1/1)` :tada:
   [Increment coverage report](http://coverage.selectdb-in.cc/coverage/63794_bb5943ab949b2a6819d177dcfc1871fbca65ea8d_merge_fe/increment_report/index.html)
   [Complete coverage report](http://coverage.selectdb-in.cc/coverage/63794_bb5943ab949b2a6819d177dcfc1871fbca65ea8d_merge_fe/report/index.html)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [fix](insert) enable_insert_strict should not affect semantic of enable_strict_cast [doris]

Posted by "jacktengg (via GitHub)" <gi...@apache.org>.
jacktengg commented on code in PR #63794:
URL: https://github.com/apache/doris/pull/63794#discussion_r3338518500


##########
be/src/storage/tablet_info.cpp:
##########
@@ -297,6 +298,9 @@ Status OlapTableSchemaParam::init(const TOlapTableSchemaParam& tschema) {
     if (tschema.__isset.is_strict_mode) {
         _is_strict_mode = tschema.is_strict_mode;
     }
+    if (tschema.__isset.is_insert) {
+        _is_insert = tschema.is_insert;

Review Comment:
   /review how to solve this compatibility issue during rolling upgrade, without affecti stream load semantics?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [fix](insert) enable_insert_strict should not affect semantic of enable_strict_cast [doris]

Posted by "jacktengg (via GitHub)" <gi...@apache.org>.
jacktengg commented on PR #63794:
URL: https://github.com/apache/doris/pull/63794#issuecomment-4598606112

   run buildall


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [fix](insert) enable_insert_strict should not affect semantic of enable_strict_cast [doris]

Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #63794:
URL: https://github.com/apache/doris/pull/63794#issuecomment-4599633115

   # BE UT Coverage Report
   Increment line coverage `60.71% (17/28)` :tada:
   
   [Increment coverage report](http://coverage.selectdb-in.cc/coverage/c8cd6e136108e46c661fb2b59f2eb61ee1c449e9_c8cd6e136108e46c661fb2b59f2eb61ee1c449e9/increment_report/index.html)
   [Complete coverage report](http://coverage.selectdb-in.cc/coverage/c8cd6e136108e46c661fb2b59f2eb61ee1c449e9_c8cd6e136108e46c661fb2b59f2eb61ee1c449e9/report/index.html)
   | Category          | Coverage           |
   |-------------------|--------------------|
   | Function Coverage | 54.13% (21108/38993) |
   | Line Coverage     | 37.62% (200028/531716) |
   | Region Coverage   | 33.87% (156756/462872) |
   | Branch Coverage   | 34.82% (68096/195567) |


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [fix](insert) enable_insert_strict should not affect semantic of enable_strict_cast [doris]

Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #63794:
URL: https://github.com/apache/doris/pull/63794#issuecomment-4602817076

   
   <details>
   <summary>TPC-DS: <b>Total hot run time: 169724 ms</b></summary>
   
   ```
   machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
   scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
   TPC-DS sf100 test result on commit edea4f7d83cdb6670ad2794b49e2dec676a3cf67, data reload: false
   
   query5	4343	629	475	475
   query6	448	212	196	196
   query7	4812	595	316	316
   query8	374	215	199	199
   query9	8749	4066	4111	4066
   query10	493	323	262	262
   query11	5905	2371	2157	2157
   query12	154	104	104	104
   query13	1326	612	436	436
   query14	7073	5422	5122	5122
   query14_1	4446	4421	4435	4421
   query15	214	197	183	183
   query16	1018	493	468	468
   query17	1268	717	605	605
   query18	2723	496	365	365
   query19	258	191	153	153
   query20	115	107	107	107
   query21	222	139	121	121
   query22	13733	13567	13444	13444
   query23	17444	16615	16198	16198
   query23_1	16287	16355	16350	16350
   query24	7488	1779	1305	1305
   query24_1	1283	1328	1340	1328
   query25	584	469	418	418
   query26	1317	324	176	176
   query27	2606	576	359	359
   query28	4297	2033	2001	2001
   query29	1096	651	514	514
   query30	314	236	203	203
   query31	1161	1088	978	978
   query32	109	64	62	62
   query33	538	335	298	298
   query34	1143	1180	653	653
   query35	760	776	704	704
   query36	1402	1422	1237	1237
   query37	159	104	87	87
   query38	3208	3145	3062	3062
   query39	937	928	899	899
   query39_1	884	876	890	876
   query40	218	122	101	101
   query41	65	63	61	61
   query42	98	95	97	95
   query43	316	327	273	273
   query44	
   query45	198	188	180	180
   query46	1082	1193	744	744
   query47	2357	2371	2208	2208
   query48	403	429	316	316
   query49	629	481	351	351
   query50	1019	357	254	254
   query51	4331	4403	4304	4304
   query52	90	88	78	78
   query53	246	270	193	193
   query54	289	227	205	205
   query55	79	78	72	72
   query56	244	234	218	218
   query57	1455	1402	1310	1310
   query58	247	205	199	199
   query59	1602	1696	1466	1466
   query60	283	249	244	244
   query61	163	159	161	159
   query62	701	647	588	588
   query63	233	187	194	187
   query64	2491	827	627	627
   query65	
   query66	1735	463	351	351
   query67	29845	29699	29561	29561
   query68	
   query69	419	303	265	265
   query70	963	973	931	931
   query71	299	235	216	216
   query72	2990	2656	2412	2412
   query73	866	790	401	401
   query74	5143	4983	4763	4763
   query75	2669	2583	2244	2244
   query76	2254	1142	789	789
   query77	353	375	301	301
   query78	12530	12574	11878	11878
   query79	1429	1054	782	782
   query80	1288	480	404	404
   query81	538	287	239	239
   query82	648	167	121	121
   query83	394	277	243	243
   query84	271	139	110	110
   query85	948	535	429	429
   query86	440	310	282	282
   query87	3414	3380	3191	3191
   query88	3657	2755	2765	2755
   query89	435	377	346	346
   query90	1918	189	189	189
   query91	176	165	138	138
   query92	65	66	55	55
   query93	1646	1423	904	904
   query94	725	363	296	296
   query95	699	479	347	347
   query96	1017	815	365	365
   query97	2720	2677	2543	2543
   query98	213	210	208	208
   query99	1153	1171	1042	1042
   Total cold run time: 253731 ms
   Total hot run time: 169724 ms
   ```
   </details>
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org