You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Nate Cole <nc...@hortonworks.com> on 2015/01/21 21:14:12 UTC
Review Request 30135: Wrong stack version of Service installed
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30135/
-----------------------------------------------------------
Review request for Ambari, Alejandro Fernandez, Jonathan Hurley, and John Speidel.
Bugs: AMBARI-9247
https://issues.apache.org/jira/browse/AMBARI-9247
Repository: ambari
Description
-------
Issue when loading the latestUrl. The code was checking to see if the defaultUrl was the same as the baseUrl, and if it was, would set the baseUrl to the latest. This caused an issue when actually using the defaultUrl as the baseUrl. The baseUrl was saved to the db correctly, but since they were equal, it would always be overridden. This meant when we sent the baseUrl to the host to install new bits, the latest would ALWAYS be used.
Diffs
-----
ambari-server/src/main/java/org/apache/ambari/server/api/services/AmbariMetaInfo.java 1b7e2fe
ambari-server/src/main/java/org/apache/ambari/server/stack/StackModule.java 933f187
ambari-server/src/main/java/org/apache/ambari/server/state/RepositoryInfo.java 5347682
ambari-server/src/main/java/org/apache/ambari/server/state/stack/LatestRepoCallable.java 608637c
ambari-server/src/test/java/org/apache/ambari/server/api/services/AmbariMetaInfoTest.java 5579db3
Diff: https://reviews.apache.org/r/30135/diff/
Testing
-------
Pending results.
Thanks,
Nate Cole
Re: Review Request 30135: Wrong stack version of Service installed
Posted by Jonathan Hurley <jh...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30135/#review69003
-----------------------------------------------------------
Ship it!
Ship It!
- Jonathan Hurley
On Jan. 21, 2015, 3:14 p.m., Nate Cole wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/30135/
> -----------------------------------------------------------
>
> (Updated Jan. 21, 2015, 3:14 p.m.)
>
>
> Review request for Ambari, Alejandro Fernandez, Jonathan Hurley, and John Speidel.
>
>
> Bugs: AMBARI-9247
> https://issues.apache.org/jira/browse/AMBARI-9247
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Issue when loading the latestUrl. The code was checking to see if the defaultUrl was the same as the baseUrl, and if it was, would set the baseUrl to the latest. This caused an issue when actually using the defaultUrl as the baseUrl. The baseUrl was saved to the db correctly, but since they were equal, it would always be overridden. This meant when we sent the baseUrl to the host to install new bits, the latest would ALWAYS be used.
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/api/services/AmbariMetaInfo.java 1b7e2fe
> ambari-server/src/main/java/org/apache/ambari/server/stack/StackModule.java 933f187
> ambari-server/src/main/java/org/apache/ambari/server/state/RepositoryInfo.java 5347682
> ambari-server/src/main/java/org/apache/ambari/server/state/stack/LatestRepoCallable.java 608637c
> ambari-server/src/test/java/org/apache/ambari/server/api/services/AmbariMetaInfoTest.java 5579db3
>
> Diff: https://reviews.apache.org/r/30135/diff/
>
>
> Testing
> -------
>
> Pending results.
>
>
> Thanks,
>
> Nate Cole
>
>
Re: Review Request 30135: Wrong stack version of Service installed
Posted by John Speidel <js...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30135/#review69025
-----------------------------------------------------------
Ship it!
- John Speidel
On Jan. 21, 2015, 8:51 p.m., Nate Cole wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/30135/
> -----------------------------------------------------------
>
> (Updated Jan. 21, 2015, 8:51 p.m.)
>
>
> Review request for Ambari, Alejandro Fernandez, Jonathan Hurley, and John Speidel.
>
>
> Bugs: AMBARI-9247
> https://issues.apache.org/jira/browse/AMBARI-9247
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Issue when loading the latestUrl. The code was checking to see if the defaultUrl was the same as the baseUrl, and if it was, would set the baseUrl to the latest. This caused an issue when actually using the defaultUrl as the baseUrl. The baseUrl was saved to the db correctly, but since they were equal, it would always be overridden. This meant when we sent the baseUrl to the host to install new bits, the latest would ALWAYS be used.
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/api/services/AmbariMetaInfo.java 1b7e2fe
> ambari-server/src/main/java/org/apache/ambari/server/stack/StackModule.java 933f187
> ambari-server/src/main/java/org/apache/ambari/server/state/RepositoryInfo.java 5347682
> ambari-server/src/main/java/org/apache/ambari/server/state/stack/LatestRepoCallable.java 608637c
> ambari-server/src/test/java/org/apache/ambari/server/api/services/AmbariMetaInfoTest.java 5579db3
>
> Diff: https://reviews.apache.org/r/30135/diff/
>
>
> Testing
> -------
>
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 19:45.423s
> [INFO] Finished at: Wed Jan 21 15:30:11 EST 2015
> [INFO] Final Memory: 34M/342M
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Nate Cole
>
>
Re: Review Request 30135: Wrong stack version of Service installed
Posted by Nate Cole <nc...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30135/
-----------------------------------------------------------
(Updated Jan. 21, 2015, 3:51 p.m.)
Review request for Ambari, Alejandro Fernandez, Jonathan Hurley, and John Speidel.
Changes
-------
updated test results
Bugs: AMBARI-9247
https://issues.apache.org/jira/browse/AMBARI-9247
Repository: ambari
Description
-------
Issue when loading the latestUrl. The code was checking to see if the defaultUrl was the same as the baseUrl, and if it was, would set the baseUrl to the latest. This caused an issue when actually using the defaultUrl as the baseUrl. The baseUrl was saved to the db correctly, but since they were equal, it would always be overridden. This meant when we sent the baseUrl to the host to install new bits, the latest would ALWAYS be used.
Diffs
-----
ambari-server/src/main/java/org/apache/ambari/server/api/services/AmbariMetaInfo.java 1b7e2fe
ambari-server/src/main/java/org/apache/ambari/server/stack/StackModule.java 933f187
ambari-server/src/main/java/org/apache/ambari/server/state/RepositoryInfo.java 5347682
ambari-server/src/main/java/org/apache/ambari/server/state/stack/LatestRepoCallable.java 608637c
ambari-server/src/test/java/org/apache/ambari/server/api/services/AmbariMetaInfoTest.java 5579db3
Diff: https://reviews.apache.org/r/30135/diff/
Testing (updated)
-------
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 19:45.423s
[INFO] Finished at: Wed Jan 21 15:30:11 EST 2015
[INFO] Final Memory: 34M/342M
[INFO] ------------------------------------------------------------------------
Thanks,
Nate Cole
Re: Review Request 30135: Wrong stack version of Service installed
Posted by Alejandro Fernandez <af...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30135/#review69000
-----------------------------------------------------------
Ship it!
ambari-server/src/main/java/org/apache/ambari/server/api/services/AmbariMetaInfo.java
<https://reviews.apache.org/r/30135/#comment113574>
May want to remove whitespace characters first.
- Alejandro Fernandez
On Jan. 21, 2015, 8:14 p.m., Nate Cole wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/30135/
> -----------------------------------------------------------
>
> (Updated Jan. 21, 2015, 8:14 p.m.)
>
>
> Review request for Ambari, Alejandro Fernandez, Jonathan Hurley, and John Speidel.
>
>
> Bugs: AMBARI-9247
> https://issues.apache.org/jira/browse/AMBARI-9247
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Issue when loading the latestUrl. The code was checking to see if the defaultUrl was the same as the baseUrl, and if it was, would set the baseUrl to the latest. This caused an issue when actually using the defaultUrl as the baseUrl. The baseUrl was saved to the db correctly, but since they were equal, it would always be overridden. This meant when we sent the baseUrl to the host to install new bits, the latest would ALWAYS be used.
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/api/services/AmbariMetaInfo.java 1b7e2fe
> ambari-server/src/main/java/org/apache/ambari/server/stack/StackModule.java 933f187
> ambari-server/src/main/java/org/apache/ambari/server/state/RepositoryInfo.java 5347682
> ambari-server/src/main/java/org/apache/ambari/server/state/stack/LatestRepoCallable.java 608637c
> ambari-server/src/test/java/org/apache/ambari/server/api/services/AmbariMetaInfoTest.java 5579db3
>
> Diff: https://reviews.apache.org/r/30135/diff/
>
>
> Testing
> -------
>
> Pending results.
>
>
> Thanks,
>
> Nate Cole
>
>