You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@nifi.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2017/04/26 19:22:04 UTC
[jira] [Commented] (NIFI-3746) CaptureChangeMySQL processor commits
session only when a "commit" event is received
[ https://issues.apache.org/jira/browse/NIFI-3746?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15985409#comment-15985409 ]
ASF GitHub Bot commented on NIFI-3746:
--------------------------------------
GitHub user mattyb149 opened a pull request:
https://github.com/apache/nifi/pull/1702
NIFI-3746: Fixed DDL event transfer when outside a transaction in CaptureChangeMySQL
Thank you for submitting a contribution to Apache NiFi.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [x] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
- [x] Does your PR title start with NIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
- [x] Has your PR been rebased against the latest commit within the target branch (typically master)?
- [x] Is your initial contribution a single, squashed commit?
### For code changes:
- [x] Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder?
- [x] Have you written or updated unit tests to verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-assembly?
- [ ] If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-assembly?
- [ ] If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties?
### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in which it is rendered?
### Note:
Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/mattyb149/nifi NIFI-3746
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/nifi/pull/1702.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1702
----
commit b5545a1513caeb01f41ee475bf92643466ae6f97
Author: Matt Burgess <ma...@apache.org>
Date: 2017-04-26T19:19:12Z
NIFI-3746: Fixed DDL event transfer when outside a transaction in CaptureChangeMySQL
----
> CaptureChangeMySQL processor commits session only when a "commit" event is received
> -----------------------------------------------------------------------------------
>
> Key: NIFI-3746
> URL: https://issues.apache.org/jira/browse/NIFI-3746
> Project: Apache NiFi
> Issue Type: Bug
> Components: Extensions
> Affects Versions: 1.2.0
> Reporter: Andrew Lim
> Assignee: Matt Burgess
> Fix For: 1.2.0
>
>
> An example of why this is problematic:
> If only a CREATE exists in the MySQL bin log no flow file to be generated by the CaptureChangeMySQL processor.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)