You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2021/06/21 05:00:48 UTC

[GitHub] [shardingsphere] soulasuna opened a new issue #10891: Suggestions on the example project

soulasuna opened a new issue #10891:
URL: https://github.com/apache/shardingsphere/issues/10891


   ## Suggestions on the example project
   
   When using the example project, I found that some startup classes with different functions have the same name (ExampleMain).
   
   It is not friendly for developers who use the example project to understand the corresponding functions,In the UI display in the IDE is not very recognizable.
   
   At the same time, the jdbc_url link parameter configuration in the unified configuration file of all sample projects.
   
   #### 1. Start class name 
   
   Basic format: 
   
   function + project nature + [configuration type] + end of Example
   
   For example in the governance-example project:
   
   ```java 
   JavaConfigurationExampleMain --> GovernanceRawJavaConfigurationExample
   YamlConfigurationExampleMain --> GovernanceRawYamlConfigurationExample
   ExampleMain --> GovernanceSpringBootExample
   ExampleMain --> GovernanceSpringNamespaceExample
   ``` 
   
   #### 2. Configuration file changed
   
   Parameter jdbc_url request parameters are unified:
   
   ```shell
   ?serverTimezone=UTC&useSSL=false&useUnicode=true&characterEncoding=UTF-8
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] taojintianxia edited a comment on issue #10891: Suggestions on the example project

Posted by GitBox <gi...@apache.org>.
taojintianxia edited a comment on issue #10891:
URL: https://github.com/apache/shardingsphere/issues/10891#issuecomment-864736717


   what I believe, is that make the demo / example as "stupid" as it could be.
   no lambda, no abstraction, no design pattern, no programming skill show off .
   
   to make the people who has less than 1 year Java experience could easily understand is the best.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] soulasuna closed issue #10891: Suggestions on the example project

Posted by GitBox <gi...@apache.org>.
soulasuna closed issue #10891:
URL: https://github.com/apache/shardingsphere/issues/10891


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] taojintianxia commented on issue #10891: Suggestions on the example project

Posted by GitBox <gi...@apache.org>.
taojintianxia commented on issue #10891:
URL: https://github.com/apache/shardingsphere/issues/10891#issuecomment-864736717


   what I believe, is that make the demo / example as"stupid" as it could be.
   no lambda, no abstraction, no design pattern, no programming skill show off .
   
   to make the people who has less than 1 year Java experience could easily understand is the best.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] tristaZero commented on issue #10891: Suggestions on the example project

Posted by GitBox <gi...@apache.org>.
tristaZero commented on issue #10891:
URL: https://github.com/apache/shardingsphere/issues/10891#issuecomment-864742191


   Hi @soulasuna ,
   
   Thanks for your first issue here. It looks fine with me, please go ahead. Also, you can give some consideration on @taojintianxia 's suggestion. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org