You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2022/08/18 20:06:34 UTC

[GitHub] [airflow] eladkal commented on a diff in pull request #25802: Added a note about MySQLToS3Operator backward incompatible changes

eladkal commented on code in PR #25802:
URL: https://github.com/apache/airflow/pull/25802#discussion_r949549607


##########
RELEASE_NOTES.rst:
##########
@@ -502,6 +502,12 @@ Airflow 2.3.0 restores the original meaning to the parameter. If you set it to "
 can be embedded in an iframe (no header is added), but when you set it to "false" the header is added
 and Airflow cannot be embedded in an iframe.
 
+``MySQLToS3Operator`` argument `pd_csv_kwargs` has beed replaced with `pd_kwargs` (#20807)
+""""""""""""""""""""""""""""""""""""""""""""""""""""""""""""""""""""""""""""""""""""""""""
+
+Although the old one (``pd_csv_kwargs``) is still accepted but no longer taken into account. Considering
+``MySQLToS3Operator`` deprecation it is recommeded to switch to ``SqlToS3Operator``. Doing this keep in mind
+that ``index`` and ``header`` arguments should be moved into ``pd_kwargs`` dict.

Review Comment:
   This is not the right place.
   The note needs to be in the provider change log not in the Airflow core release notes



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org