You are viewing a plain text version of this content. The canonical link for it is here.
Posted to yarn-issues@hadoop.apache.org by "Szilard Nemeth (Jira)" <ji...@apache.org> on 2021/08/03 14:21:00 UTC
[jira] [Resolved] (YARN-10874) Refactor NM
ContainerLaunch#getEnvDependencies's unit tests
[ https://issues.apache.org/jira/browse/YARN-10874?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Szilard Nemeth resolved YARN-10874.
-----------------------------------
Hadoop Flags: Reviewed
Resolution: Fixed
> Refactor NM ContainerLaunch#getEnvDependencies's unit tests
> -----------------------------------------------------------
>
> Key: YARN-10874
> URL: https://issues.apache.org/jira/browse/YARN-10874
> Project: Hadoop YARN
> Issue Type: Improvement
> Components: yarn
> Reporter: Tamas Domok
> Assignee: Tamas Domok
> Priority: Minor
> Labels: pull-request-available
> Fix For: 3.4.0
>
> Time Spent: 50m
> Remaining Estimate: 0h
>
> The YARN-10355 ticket states that the unit tests contains repeated code and the test methods are too long. We decided to split that ticket into two parts. The YARN-10355 will contain only the production code change (for the windows variant, the linux variant refactor is not feasible with regex, the original code is not the nicest, but it does it's thing).
>
> Acceptance criteria:
> * refactor the unit tests (e.g.: parameterised tests)
> * extend the tests with extra checks
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: yarn-issues-help@hadoop.apache.org