You are viewing a plain text version of this content. The canonical link for it is here.

Posted to codereview@trafodion.apache.org by DaveBirdsall <gi...@git.apache.org> on 2017/12/13 21:07:19 UTC

[GitHub] incubator-trafodion pull request #1340: [TRAFODION-2843] Fix outer join on a...

GitHub user DaveBirdsall opened a pull request:

    https://github.com/apache/incubator-trafodion/pull/1340

    [TRAFODION-2843] Fix outer join on aggregate bug

    Formerly, the code was allowing an uncovered aggregate expression to be generated as a before join predicate. This lead to a Generator assert. The test for uncovered expressions in Join::preCodeGen has been tightened up so this does not happen.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/DaveBirdsall/incubator-trafodion Trafodion2843

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-trafodion/pull/1340.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1340
    
----
commit ccb17c28e7fa74b5c58dbf37a02239316184bdd5
Author: Dave Birdsall <db...@apache.org>
Date:   2017-12-13T21:04:44Z

    [TRAFODION-2843] Fix outer join on aggregate bug

----


---

[GitHub] incubator-trafodion pull request #1340: [TRAFODION-2843] Fix outer join on a...

Posted by asfgit <gi...@git.apache.org>.

Github user asfgit closed the pull request at:

    https://github.com/apache/incubator-trafodion/pull/1340


---