[GitHub] [netbeans] junichi11 commented on a change in pull request #1617: [NETBEANS-3335] Enhance robustness of HTML Lexer

[GitBox <gi...@apache.org>]

junichi11 commented on a change in pull request #1617: [NETBEANS-3335] Enhance robustness of HTML Lexer
URL: https://github.com/apache/netbeans/pull/1617#discussion_r342930191
 
 

 ##########
 File path: ide/html.lexer/src/org/netbeans/lib/html/lexer/HtmlLexer.java
 ##########
 @@ -1552,8 +1552,12 @@ public void release() {
 
     /** @param optimized - first sequence is lowercase, one call to Character.toLowerCase() */
     private static boolean equals(CharSequence text1, CharSequence text2, boolean ignoreCase, boolean optimized) {
-        assert text1 != null : "text1 arg is null";
-        assert text2 != null : "text2 arg is null";
+        if(text1 == text2) {
 
 Review comment:
   Nitpick: should add whitespace behind `if`

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists