You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sentry.apache.org by Alexander Kolbasov <ak...@gmail.com> on 2017/02/21 02:34:32 UTC

Review Request 56861: SENTRY-1636 Remove thrift dependency on fb303

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56861/
-----------------------------------------------------------

Review request for sentry, Hao Hao, kalyan kumar kalvagadda, Vamsee Yarlagadda, and Vadim Spector.


Bugs: SENTRY-1636
    https://issues.apache.org/jira/browse/SENTRY-1636


Repository: sentry


Description
-------

SENTRY-1636 Remove thrift dependency on fb303


Diffs
-----

  sentry-hdfs/sentry-hdfs-common/src/main/resources/sentry_hdfs_service.thrift 5f9cf3137465f08cde99df146e643b1762f695dc 
  sentry-hdfs/sentry-hdfs-service/pom.xml b890dd5647e4556d3d0e9dfb54b3b02bc8683359 
  sentry-service/sentry-service-common/pom.xml bac8c650a3e28821df4abcbda15035b867218b5a 
  sentry-service/sentry-service-common/src/main/resources/sentry_common_service.thrift 65c6934bc57b5b979c1d757b51f6785178398bd0 
  sentry-service/sentry-service-common/src/main/resources/sentry_generic_policy_service.thrift db107bfdeaf6a47f599f7d779c91396ecc53ee7a 
  sentry-service/sentry-service-common/src/main/resources/sentry_policy_service.thrift 82cd947f3d5a077a0f9aab553a7c65c6efa05228 
  sentry-service/sentry-service-server/pom.xml e8098be4476684e84fc34c81dbb7203b9e1666ea 
  sentry-tests/sentry-tests-sqoop/src/test/java/org/apache/sentry/tests/e2e/sqoop/TomcatSqoopRunner.java cea9acc58fb54aed353b91537f5a9c70326f1d29 

Diff: https://reviews.apache.org/r/56861/diff/


Testing
-------

I re-generated all Thrift files to verify that there are no actual changes in the generated code.


Thanks,

Alexander Kolbasov

Re: Review Request 56861: SENTRY-1636 Remove thrift dependency on fb303

Posted by Vamsee Yarlagadda <va...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56861/#review166176
-----------------------------------------------------------


Ship it!




Ship It!

- Vamsee Yarlagadda


On Feb. 21, 2017, 2:34 a.m., Alexander Kolbasov wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56861/
> -----------------------------------------------------------
> 
> (Updated Feb. 21, 2017, 2:34 a.m.)
> 
> 
> Review request for sentry, Hao Hao, kalyan kumar kalvagadda, Vamsee Yarlagadda, and Vadim Spector.
> 
> 
> Bugs: SENTRY-1636
>     https://issues.apache.org/jira/browse/SENTRY-1636
> 
> 
> Repository: sentry
> 
> 
> Description
> -------
> 
> SENTRY-1636 Remove thrift dependency on fb303
> 
> 
> Diffs
> -----
> 
>   sentry-hdfs/sentry-hdfs-common/src/main/resources/sentry_hdfs_service.thrift 5f9cf3137465f08cde99df146e643b1762f695dc 
>   sentry-hdfs/sentry-hdfs-service/pom.xml b890dd5647e4556d3d0e9dfb54b3b02bc8683359 
>   sentry-service/sentry-service-common/pom.xml bac8c650a3e28821df4abcbda15035b867218b5a 
>   sentry-service/sentry-service-common/src/main/resources/sentry_common_service.thrift 65c6934bc57b5b979c1d757b51f6785178398bd0 
>   sentry-service/sentry-service-common/src/main/resources/sentry_generic_policy_service.thrift db107bfdeaf6a47f599f7d779c91396ecc53ee7a 
>   sentry-service/sentry-service-common/src/main/resources/sentry_policy_service.thrift 82cd947f3d5a077a0f9aab553a7c65c6efa05228 
>   sentry-service/sentry-service-server/pom.xml e8098be4476684e84fc34c81dbb7203b9e1666ea 
>   sentry-tests/sentry-tests-sqoop/src/test/java/org/apache/sentry/tests/e2e/sqoop/TomcatSqoopRunner.java cea9acc58fb54aed353b91537f5a9c70326f1d29 
> 
> Diff: https://reviews.apache.org/r/56861/diff/
> 
> 
> Testing
> -------
> 
> I re-generated all Thrift files to verify that there are no actual changes in the generated code.
> 
> 
> Thanks,
> 
> Alexander Kolbasov
> 
>