You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@maven.apache.org by mi...@apache.org on 2022/12/11 20:20:06 UTC
[maven-surefire] 01/01: [SUREFIRE-2133] Make anchors start *before* the headings
This is an automated email from the ASF dual-hosted git repository.
michaelo pushed a commit to branch SUREFIRE-2133
in repository https://gitbox.apache.org/repos/asf/maven-surefire.git
commit fd6953bde79d91bf7abf078e67796d0b65c7eb45
Author: Michael Osipov <mi...@apache.org>
AuthorDate: Sun Dec 11 21:19:21 2022 +0100
[SUREFIRE-2133] Make anchors start *before* the headings
This closes #582
---
.../surefire/report/SurefireReportGenerator.java | 30 +++++++++++++---------
1 file changed, 18 insertions(+), 12 deletions(-)
diff --git a/maven-surefire-report-plugin/src/main/java/org/apache/maven/plugins/surefire/report/SurefireReportGenerator.java b/maven-surefire-report-plugin/src/main/java/org/apache/maven/plugins/surefire/report/SurefireReportGenerator.java
index b4d9d2436..5e21fcd58 100644
--- a/maven-surefire-report-plugin/src/main/java/org/apache/maven/plugins/surefire/report/SurefireReportGenerator.java
+++ b/maven-surefire-report-plugin/src/main/java/org/apache/maven/plugins/surefire/report/SurefireReportGenerator.java
@@ -120,12 +120,13 @@ public final class SurefireReportGenerator
Map<String, String> summary = report.getSummary( testSuites );
sink.section1();
+
+ sinkAnchor( sink, "Summary" );
+
sink.sectionTitle1();
sink.text( bundle.getReportLabelSummary() );
sink.sectionTitle1_();
- sinkAnchor( sink, "Summary" );
-
constructHotLinks( sink, bundle );
sinkLineBreak( sink );
@@ -187,12 +188,13 @@ public final class SurefireReportGenerator
NumberFormat numberFormat = report.getNumberFormat();
sink.section1();
+
+ sinkAnchor( sink, "Package_List" );
+
sink.sectionTitle1();
sink.text( bundle.getReportLabelPackageList() );
sink.sectionTitle1_();
- sinkAnchor( sink, "Package_List" );
-
constructHotLinks( sink, bundle );
sinkLineBreak( sink );
@@ -263,12 +265,13 @@ public final class SurefireReportGenerator
List<ReportTestSuite> testSuiteList = entry.getValue();
sink.section2();
+
+ sinkAnchor( sink, packageName );
+
sink.sectionTitle2();
sink.text( packageName );
sink.sectionTitle2_();
- sinkAnchor( sink, packageName );
-
boolean showTable = false;
for ( ReportTestSuite suite : testSuiteList )
@@ -381,12 +384,13 @@ public final class SurefireReportGenerator
NumberFormat numberFormat = report.getNumberFormat();
sink.section1();
+
+ sinkAnchor( sink, "Test_Cases" );
+
sink.sectionTitle1();
sink.text( bundle.getReportLabelTestCases() );
sink.sectionTitle1_();
- sinkAnchor( sink, "Test_Cases" );
-
constructHotLinks( sink, bundle );
for ( ReportTestSuite suite : testSuites )
@@ -396,12 +400,13 @@ public final class SurefireReportGenerator
if ( !testCases.isEmpty() )
{
sink.section2();
+
+ sinkAnchor( sink, suite.getPackageName() + '.' + suite.getName() );
+
sink.sectionTitle2();
sink.text( suite.getName() );
sink.sectionTitle2_();
- sinkAnchor( sink, suite.getPackageName() + '.' + suite.getName() );
-
boolean showTable = false;
for ( ReportTestCase testCase : testCases )
@@ -551,12 +556,13 @@ public final class SurefireReportGenerator
private void constructFailureDetails( Sink sink, LocalizedProperties bundle, List<ReportTestCase> failures )
{
sink.section1();
+
+ sinkAnchor( sink, "Failure_Details" );
+
sink.sectionTitle1();
sink.text( bundle.getReportLabelFailureDetails() );
sink.sectionTitle1_();
- sinkAnchor( sink, "Failure_Details" );
-
constructHotLinks( sink, bundle );
sinkLineBreak( sink );