You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@myfaces.apache.org by we...@apache.org on 2019/08/23 09:23:35 UTC

[myfaces-tobago] branch tobago-2.x updated: TOBAGO-2003 - Tobago 2: Confirmation facet should not render if isRendered evals to false

This is an automated email from the ASF dual-hosted git repository.

weber pushed a commit to branch tobago-2.x
in repository https://gitbox.apache.org/repos/asf/myfaces-tobago.git


The following commit(s) were added to refs/heads/tobago-2.x by this push:
     new fb15fc6  TOBAGO-2003 - Tobago 2: Confirmation facet should not render if isRendered evals to false
fb15fc6 is described below

commit fb15fc6eacf0254041251d64451b71afa6334e31
Author: Volker Weber <v....@inexso.de>
AuthorDate: Fri Aug 23 11:22:17 2019 +0200

    TOBAGO-2003 - Tobago 2: Confirmation facet should not render if isRendered evals to false
---
 .../src/main/java/org/apache/myfaces/tobago/renderkit/html/Command.java | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tobago-theme/tobago-theme-standard/src/main/java/org/apache/myfaces/tobago/renderkit/html/Command.java b/tobago-theme/tobago-theme-standard/src/main/java/org/apache/myfaces/tobago/renderkit/html/Command.java
index 07cb655..0e97b9f 100644
--- a/tobago-theme/tobago-theme-standard/src/main/java/org/apache/myfaces/tobago/renderkit/html/Command.java
+++ b/tobago-theme/tobago-theme-standard/src/main/java/org/apache/myfaces/tobago/renderkit/html/Command.java
@@ -136,7 +136,7 @@ public class Command {
 
   private static String getConfirmation(final AbstractUICommand command) {
     final ValueHolder facet = (ValueHolder) command.getFacet(Facets.CONFIRMATION);
-    return facet != null ? "" + facet.getValue() : null;
+    return facet != null && ((UIComponent) facet).isRendered() ? "" + facet.getValue() : null;
   }
 
   public String getAction() {