You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@trafficserver.apache.org by Sudheer Vinukonda <su...@yahoo-inc.com.INVALID> on 2015/04/03 02:10:19 UTC
duplicate TS API TSHttpIsInternalRequest as TSHttpTxnIsInternal for
consistency in naming
The naming of the API TSHttpIsInternalRequest() is a confusing, since it takes in a txnp parameter. It would perhaps be clearer if the API were called TSHttpTxnIsInternal (incidentally, there's a condition in header_rewrite plugin that is also named INTERNAL-TRANSACTION).To remove the confusion, Leif suggested to duplicate the existing TS API TSHttpIsInternalRequest() as TSHttpTxnIsInternal() and eventually retire the TSHttpIsInternalRequest() API. This is tracked with jira TS-3449.Please let me know if there are any comments/concerns.
Thanks,
Sudheer
Re: duplicate TS API TSHttpIsInternalRequest as TSHttpTxnIsInternal
for consistency in naming
Posted by Sudheer Vinukonda <su...@yahoo-inc.com.INVALID>.
Sure, will do - will wait until Monday and make the changes if there are no other concerns.
Thanks,
Sudheer
On Friday, April 3, 2015 8:18 AM, James Peach <jp...@apache.org> wrote:
> On Apr 2, 2015, at 5:10 PM, Sudheer Vinukonda <su...@yahoo-inc.com.INVALID> wrote:
>
> The naming of the API TSHttpIsInternalRequest() is a confusing, since it takes in a txnp parameter. It would perhaps be clearer if the API were called TSHttpTxnIsInternal (incidentally, there's a condition in header_rewrite plugin that is also named INTERNAL-TRANSACTION).To remove the confusion, Leif suggested to duplicate the existing TS API TSHttpIsInternalRequest() as TSHttpTxnIsInternal() and eventually retire the TSHttpIsInternalRequest() API. This is tracked with jira TS-3449.Please let me know if there are any comments/concerns.
Please also make the corresponding changes to TSHttpIsInternalSession() and add deprecated attributes to the old APIs.
thanks,
James
Re: duplicate TS API TSHttpIsInternalRequest as TSHttpTxnIsInternal for consistency in naming
Posted by James Peach <jp...@apache.org>.
> On Apr 2, 2015, at 5:10 PM, Sudheer Vinukonda <su...@yahoo-inc.com.INVALID> wrote:
>
> The naming of the API TSHttpIsInternalRequest() is a confusing, since it takes in a txnp parameter. It would perhaps be clearer if the API were called TSHttpTxnIsInternal (incidentally, there's a condition in header_rewrite plugin that is also named INTERNAL-TRANSACTION).To remove the confusion, Leif suggested to duplicate the existing TS API TSHttpIsInternalRequest() as TSHttpTxnIsInternal() and eventually retire the TSHttpIsInternalRequest() API. This is tracked with jira TS-3449.Please let me know if there are any comments/concerns.
Please also make the corresponding changes to TSHttpIsInternalSession() and add deprecated attributes to the old APIs.
thanks,
James