You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by haosdent huang <ha...@gmail.com> on 2015/06/23 12:14:20 UTC
Review Request 35782: fix web UI shows "YYYY" for year instead of year
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35782/
-----------------------------------------------------------
Review request for mesos, Adam B and Marco Massenzio.
Bugs: MESOS-2894
https://issues.apache.org/jira/browse/MESOS-2894
Repository: mesos
Description
-------
fix web UI shows "YYYY" for year instead of year
Diffs
-----
src/webui/master/static/js/app.js 4ccff6314c684ae4e917345fe41a95ccc0eb5803
Diff: https://reviews.apache.org/r/35782/diff/
Testing
-------
Thanks,
haosdent huang
Re: Review Request 35782: fix web UI shows "YYYY" for year instead of
year
Posted by Adam B <ad...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35782/#review89141
-----------------------------------------------------------
Ship it!
Ship It!
- Adam B
On June 23, 2015, 3:14 a.m., haosdent huang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35782/
> -----------------------------------------------------------
>
> (Updated June 23, 2015, 3:14 a.m.)
>
>
> Review request for mesos, Adam B and Marco Massenzio.
>
>
> Bugs: MESOS-2894
> https://issues.apache.org/jira/browse/MESOS-2894
>
>
> Repository: mesos
>
>
> Description
> -------
>
> fix web UI shows "YYYY" for year instead of year
>
>
> Diffs
> -----
>
> src/webui/master/static/js/app.js 4ccff6314c684ae4e917345fe41a95ccc0eb5803
>
> Diff: https://reviews.apache.org/r/35782/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> haosdent huang
>
>
Re: Review Request 35782: fix web UI shows "YYYY" for year instead of
year
Posted by haosdent huang <ha...@gmail.com>.
> On June 24, 2015, 7:17 a.m., Adam B wrote:
> > Looks good to me, but I'm no js expert. Matches what Brian suggested in the ticket.
> > haosdent, did you do any (manual) testing on this? Maybe you could link to a before/after screenshot?
Yes, I upload the screenshots to https://issues.apache.org/jira/browse/MESOS-2894
- haosdent
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35782/#review89136
-----------------------------------------------------------
On June 23, 2015, 10:14 a.m., haosdent huang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35782/
> -----------------------------------------------------------
>
> (Updated June 23, 2015, 10:14 a.m.)
>
>
> Review request for mesos, Adam B and Marco Massenzio.
>
>
> Bugs: MESOS-2894
> https://issues.apache.org/jira/browse/MESOS-2894
>
>
> Repository: mesos
>
>
> Description
> -------
>
> fix web UI shows "YYYY" for year instead of year
>
>
> Diffs
> -----
>
> src/webui/master/static/js/app.js 4ccff6314c684ae4e917345fe41a95ccc0eb5803
>
> Diff: https://reviews.apache.org/r/35782/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> haosdent huang
>
>
Re: Review Request 35782: fix web UI shows "YYYY" for year instead of
year
Posted by Adam B <ad...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35782/#review89136
-----------------------------------------------------------
Looks good to me, but I'm no js expert. Matches what Brian suggested in the ticket.
haosdent, did you do any (manual) testing on this? Maybe you could link to a before/after screenshot?
- Adam B
On June 23, 2015, 3:14 a.m., haosdent huang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35782/
> -----------------------------------------------------------
>
> (Updated June 23, 2015, 3:14 a.m.)
>
>
> Review request for mesos, Adam B and Marco Massenzio.
>
>
> Bugs: MESOS-2894
> https://issues.apache.org/jira/browse/MESOS-2894
>
>
> Repository: mesos
>
>
> Description
> -------
>
> fix web UI shows "YYYY" for year instead of year
>
>
> Diffs
> -----
>
> src/webui/master/static/js/app.js 4ccff6314c684ae4e917345fe41a95ccc0eb5803
>
> Diff: https://reviews.apache.org/r/35782/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> haosdent huang
>
>
Re: Review Request 35782: fix web UI shows "YYYY" for year instead of
year
Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35782/#review88971
-----------------------------------------------------------
Patch looks great!
Reviews applied: [35782]
All tests passed.
- Mesos ReviewBot
On June 23, 2015, 10:14 a.m., haosdent huang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35782/
> -----------------------------------------------------------
>
> (Updated June 23, 2015, 10:14 a.m.)
>
>
> Review request for mesos, Adam B and Marco Massenzio.
>
>
> Bugs: MESOS-2894
> https://issues.apache.org/jira/browse/MESOS-2894
>
>
> Repository: mesos
>
>
> Description
> -------
>
> fix web UI shows "YYYY" for year instead of year
>
>
> Diffs
> -----
>
> src/webui/master/static/js/app.js 4ccff6314c684ae4e917345fe41a95ccc0eb5803
>
> Diff: https://reviews.apache.org/r/35782/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> haosdent huang
>
>