You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2019/08/08 18:47:34 UTC

[GitHub] [airflow] kaxil commented on a change in pull request #5760: AIRFLOW-5139 Allow custom ES configs

kaxil commented on a change in pull request #5760: AIRFLOW-5139 Allow custom ES configs
URL: https://github.com/apache/airflow/pull/5760#discussion_r312189867
 
 

 ##########
 File path: airflow/utils/log/es_task_handler.py
 ##########
 @@ -54,7 +55,8 @@ class ElasticsearchTaskHandler(FileTaskHandler, LoggingMixin):
     def __init__(self, base_log_folder, filename_template,
                  log_id_template, end_of_log_mark,
                  write_stdout, json_format, json_fields,
-                 host='localhost:9200'):
+                 host='localhost:9200',
+                 es_kwargs=conf.getsection("elasticsearch_configs") or {}):
 
 Review comment:
   Can we add this to `https://github.com/apache/airflow/blob/master/airflow/config_templates/default_airflow.cfg` as well, please?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services