You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sqoop.apache.org by Abraham Fine <ab...@brightroll.com> on 2015/10/13 23:11:46 UTC

Review Request 39292: SQOOP-2615

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39292/
-----------------------------------------------------------

Review request for Sqoop.


Bugs: SQOOP-2615
    https://issues.apache.org/jira/browse/SQOOP-2615


Repository: sqoop-sqoop2


Description
-------

Sqoop2: We should have a validator to test if an Integer input is within a range


Diffs
-----

  common/src/main/java/org/apache/sqoop/error/code/CoreError.java bc3076c 
  common/src/main/java/org/apache/sqoop/validation/validators/InRange.java PRE-CREATION 
  common/src/test/java/org/apache/sqoop/validation/validators/TestInRange.java PRE-CREATION 

Diff: https://reviews.apache.org/r/39292/diff/


Testing
-------


Thanks,

Abraham Fine

Re: Review Request 39292: SQOOP-2615

Posted by Jarek Cecho <ja...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39292/#review102556
-----------------------------------------------------------

Ship it!


Ship It!

- Jarek Cecho


On Oct. 13, 2015, 9:11 p.m., Abraham Fine wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39292/
> -----------------------------------------------------------
> 
> (Updated Oct. 13, 2015, 9:11 p.m.)
> 
> 
> Review request for Sqoop.
> 
> 
> Bugs: SQOOP-2615
>     https://issues.apache.org/jira/browse/SQOOP-2615
> 
> 
> Repository: sqoop-sqoop2
> 
> 
> Description
> -------
> 
> Sqoop2: We should have a validator to test if an Integer input is within a range
> 
> 
> Diffs
> -----
> 
>   common/src/main/java/org/apache/sqoop/error/code/CoreError.java bc3076c 
>   common/src/main/java/org/apache/sqoop/validation/validators/InRange.java PRE-CREATION 
>   common/src/test/java/org/apache/sqoop/validation/validators/TestInRange.java PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/39292/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Abraham Fine
> 
>