You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Alex Clemmer <cl...@gmail.com> on 2016/04/07 23:55:01 UTC

Review Request 45898: CMake: Place master files that moved into the correct directories.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45898/
-----------------------------------------------------------

Review request for mesos, Alex Naparu, Daniel Pravat, Artem Harutyunyan, Joris Van Remoortere, Michael Park, M Lawindi, and Yi Sun.


Repository: mesos


Description
-------

CMake: Place master files that moved into the correct directories.


Diffs
-----

  src/CMakeLists.txt 9a4cffa952a452d5df70ea42949142e534067cd6 

Diff: https://reviews.apache.org/r/45898/diff/


Testing
-------


Thanks,

Alex Clemmer


Re: Review Request 45898: CMake: Place master files that moved into the correct directories.

Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45898/#review127699
-----------------------------------------------------------



Patch looks great!

Reviews applied: [45898]

Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh

- Mesos ReviewBot


On April 7, 2016, 9:55 p.m., Alex Clemmer wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45898/
> -----------------------------------------------------------
> 
> (Updated April 7, 2016, 9:55 p.m.)
> 
> 
> Review request for mesos, Alex Naparu, Daniel Pravat, Artem Harutyunyan, Joris Van Remoortere, Michael Park, M Lawindi, and Yi Sun.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> CMake: Place master files that moved into the correct directories.
> 
> 
> Diffs
> -----
> 
>   src/CMakeLists.txt 9a4cffa952a452d5df70ea42949142e534067cd6 
> 
> Diff: https://reviews.apache.org/r/45898/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Alex Clemmer
> 
>


Re: Review Request 45898: CMake: Place master files that moved into the correct directories.

Posted by Michael Park <mp...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45898/#review127920
-----------------------------------------------------------


Ship it!




Ship It!

- Michael Park


On April 7, 2016, 9:55 p.m., Alex Clemmer wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45898/
> -----------------------------------------------------------
> 
> (Updated April 7, 2016, 9:55 p.m.)
> 
> 
> Review request for mesos, Alex Naparu, Daniel Pravat, Artem Harutyunyan, Joris Van Remoortere, Michael Park, M Lawindi, and Yi Sun.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> CMake: Place master files that moved into the correct directories.
> 
> 
> Diffs
> -----
> 
>   src/CMakeLists.txt 9a4cffa952a452d5df70ea42949142e534067cd6 
> 
> Diff: https://reviews.apache.org/r/45898/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Alex Clemmer
> 
>