You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2019/04/18 10:31:48 UTC
[GitHub] [flink] JingsongLi commented on a change in pull request #8206:
[FLINK-12248][table-planner-blink] Support e2e over window in blink batch
JingsongLi commented on a change in pull request #8206: [FLINK-12248][table-planner-blink] Support e2e over window in blink batch
URL: https://github.com/apache/flink/pull/8206#discussion_r276607019
##########
File path: flink-table/flink-table-planner-blink/src/main/java/org/apache/flink/table/expressions/RexNodeConverter.java
##########
@@ -67,6 +67,16 @@ public RexNodeConverter(RelBuilder relBuilder) {
@Override
public RexNode visitCall(CallExpression call) {
+ if (call.getFunctionDefinition().equals(BuiltInFunctionDefinitions.CAST)) {
Review comment:
OK, I will take code into `visitScalarFunc`.
The reason I haven't done this before is that `TypeLiteralExpression` can't be converted. I will do a little refactoring and move the code to `visitScalarFunc`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services