You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@spark.apache.org by gatorsmile <gi...@git.apache.org> on 2017/10/20 04:39:42 UTC

[GitHub] spark pull request #19517: [WIP][SPARK-20396][SQL][PySpark][FOLLOW-UP] group...

Github user gatorsmile commented on a diff in the pull request:

    https://github.com/apache/spark/pull/19517#discussion_r145877442
  
    --- Diff: python/pyspark/sql/functions.py ---
    @@ -2038,13 +2038,22 @@ def _wrap_function(sc, func, returnType):
                                       sc.pythonVer, broadcast_vars, sc._javaAccumulator)
     
     
    +class PythonUdfType(object):
    +    # row-based UDFs
    --- End diff --
    
    Nit: Please update all `row-based UDFs` to `row-at-a-time UDFs`


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org