You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2022/08/03 02:53:39 UTC
[GitHub] [shardingsphere] shining-stars-lk opened a new pull request, #19822: Fixed the problem that the H2 driver dependency could not be found wh…
shining-stars-lk opened a new pull request, #19822:
URL: https://github.com/apache/shardingsphere/pull/19822
…en the Example module started
Fixes #19398 .
Changes proposed in this pull request:
- H2 driver Maven dependency test range changed to default
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] mabaiwan commented on pull request #19822: Fixed the problem that the H2 driver dependency could not be found wh…
Posted by GitBox <gi...@apache.org>.
mabaiwan commented on PR #19822:
URL: https://github.com/apache/shardingsphere/pull/19822#issuecomment-1203433959
@shining-stars-lk H2 should not be global, you can see why the module depends on H2.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] shining-stars-lk closed pull request #19822: Fixed the problem that the H2 driver dependency could not be found wh…
Posted by GitBox <gi...@apache.org>.
shining-stars-lk closed pull request #19822: Fixed the problem that the H2 driver dependency could not be found wh…
URL: https://github.com/apache/shardingsphere/pull/19822
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] codecov-commenter commented on pull request #19822: Fixed the problem that the H2 driver dependency could not be found wh…
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on PR #19822:
URL: https://github.com/apache/shardingsphere/pull/19822#issuecomment-1203445532
# [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/19822?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#19822](https://codecov.io/gh/apache/shardingsphere/pull/19822?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (913b8e4) into [master](https://codecov.io/gh/apache/shardingsphere/commit/2e654172a58d9dc64da951d985be34dd776a5742?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (2e65417) will **decrease** coverage by `0.05%`.
> The diff coverage is `39.04%`.
```diff
@@ Coverage Diff @@
## master #19822 +/- ##
============================================
- Coverage 60.07% 60.02% -0.06%
- Complexity 2399 2408 +9
============================================
Files 3856 3856
Lines 54920 54860 -60
Branches 7681 7684 +3
============================================
- Hits 32993 32927 -66
- Misses 19098 19104 +6
Partials 2829 2829
```
| [Impacted Files](https://codecov.io/gh/apache/shardingsphere/pull/19822?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...ing/data/pipeline/ShardingRuleAlteredDetector.java](https://codecov.io/gh/apache/shardingsphere/pull/19822/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtZmVhdHVyZXMvc2hhcmRpbmdzcGhlcmUtc2hhcmRpbmcvc2hhcmRpbmdzcGhlcmUtc2hhcmRpbmctY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvc2hhcmRpbmcvZGF0YS9waXBlbGluZS9TaGFyZGluZ1J1bGVBbHRlcmVkRGV0ZWN0b3IuamF2YQ==) | `0.00% <ø> (ø)` | |
| [...ml/swapper/ShardingRuleConfigurationConverter.java](https://codecov.io/gh/apache/shardingsphere/pull/19822/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtZmVhdHVyZXMvc2hhcmRpbmdzcGhlcmUtc2hhcmRpbmcvc2hhcmRpbmdzcGhlcmUtc2hhcmRpbmctY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvc2hhcmRpbmcveWFtbC9zd2FwcGVyL1NoYXJkaW5nUnVsZUNvbmZpZ3VyYXRpb25Db252ZXJ0ZXIuamF2YQ==) | `80.00% <ø> (ø)` | |
| [.../infra/yaml/config/pojo/YamlRootConfiguration.java](https://codecov.io/gh/apache/shardingsphere/pull/19822/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtaW5mcmEvc2hhcmRpbmdzcGhlcmUtaW5mcmEtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9pbmZyYS95YW1sL2NvbmZpZy9wb2pvL1lhbWxSb290Q29uZmlndXJhdGlvbi5qYXZh) | `0.00% <ø> (ø)` | |
| [...ojo/rule/YamlOnRuleAlteredActionConfiguration.java](https://codecov.io/gh/apache/shardingsphere/pull/19822/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtaW5mcmEvc2hhcmRpbmdzcGhlcmUtaW5mcmEtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9pbmZyYS95YW1sL2NvbmZpZy9wb2pvL3J1bGUvWWFtbE9uUnVsZUFsdGVyZWRBY3Rpb25Db25maWd1cmF0aW9uLmphdmE=) | `40.00% <ø> (ø)` | |
| [...ig/swapper/YamlRuleConfigurationSwapperEngine.java](https://codecov.io/gh/apache/shardingsphere/pull/19822/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtaW5mcmEvc2hhcmRpbmdzcGhlcmUtaW5mcmEtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9pbmZyYS95YW1sL2NvbmZpZy9zd2FwcGVyL1lhbWxSdWxlQ29uZmlndXJhdGlvblN3YXBwZXJFbmdpbmUuamF2YQ==) | `78.57% <ø> (ø)` | |
| [...d/OnRuleAlteredActionConfigurationYamlSwapper.java](https://codecov.io/gh/apache/shardingsphere/pull/19822/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtaW5mcmEvc2hhcmRpbmdzcGhlcmUtaW5mcmEtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9pbmZyYS95YW1sL2NvbmZpZy9zd2FwcGVyL3J1bGVhbHRlcmVkL09uUnVsZUFsdGVyZWRBY3Rpb25Db25maWd1cmF0aW9uWWFtbFN3YXBwZXIuamF2YQ==) | `82.22% <ø> (ø)` | |
| [.../executor/advanced/AdvancedFederationExecutor.java](https://codecov.io/gh/apache/shardingsphere/pull/19822/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtaW5mcmEvc2hhcmRpbmdzcGhlcmUtaW5mcmEtZmVkZXJhdGlvbi9zaGFyZGluZ3NwaGVyZS1pbmZyYS1mZWRlcmF0aW9uLWV4ZWN1dG9yL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9pbmZyYS9mZWRlcmF0aW9uL2V4ZWN1dG9yL2FkdmFuY2VkL0FkdmFuY2VkRmVkZXJhdGlvbkV4ZWN1dG9yLmphdmE=) | `30.00% <0.00%> (+0.96%)` | :arrow_up: |
| [.../executor/original/OriginalFederationExecutor.java](https://codecov.io/gh/apache/shardingsphere/pull/19822/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtaW5mcmEvc2hhcmRpbmdzcGhlcmUtaW5mcmEtZmVkZXJhdGlvbi9zaGFyZGluZ3NwaGVyZS1pbmZyYS1mZWRlcmF0aW9uLWV4ZWN1dG9yL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9pbmZyYS9mZWRlcmF0aW9uL2V4ZWN1dG9yL29yaWdpbmFsL09yaWdpbmFsRmVkZXJhdGlvbkV4ZWN1dG9yLmphdmE=) | `0.00% <0.00%> (ø)` | |
| [...executor/original/database/FilterableDatabase.java](https://codecov.io/gh/apache/shardingsphere/pull/19822/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtaW5mcmEvc2hhcmRpbmdzcGhlcmUtaW5mcmEtZmVkZXJhdGlvbi9zaGFyZGluZ3NwaGVyZS1pbmZyYS1mZWRlcmF0aW9uLWV4ZWN1dG9yL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9pbmZyYS9mZWRlcmF0aW9uL2V4ZWN1dG9yL29yaWdpbmFsL2RhdGFiYXNlL0ZpbHRlcmFibGVEYXRhYmFzZS5qYXZh) | `0.00% <0.00%> (ø)` | |
| [...ion/executor/original/schema/FilterableSchema.java](https://codecov.io/gh/apache/shardingsphere/pull/19822/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtaW5mcmEvc2hhcmRpbmdzcGhlcmUtaW5mcmEtZmVkZXJhdGlvbi9zaGFyZGluZ3NwaGVyZS1pbmZyYS1mZWRlcmF0aW9uLWV4ZWN1dG9yL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9pbmZyYS9mZWRlcmF0aW9uL2V4ZWN1dG9yL29yaWdpbmFsL3NjaGVtYS9GaWx0ZXJhYmxlU2NoZW1hLmphdmE=) | `0.00% <0.00%> (ø)` | |
| ... and [99 more](https://codecov.io/gh/apache/shardingsphere/pull/19822/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org