You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hudi.apache.org by GitBox <gi...@apache.org> on 2022/10/28 15:29:13 UTC
[GitHub] [hudi] jonvex opened a new pull request, #7086: [HUDI-4624] Implement Closable for S3EventsSource
jonvex opened a new pull request, #7086:
URL: https://github.com/apache/hudi/pull/7086
### Change Logs
We are not freeing resources properly in S3EventsSource. The SQS queue is now shutdown in close()
### Impact
_Describe any public API or user-facing feature change or any performance impact._
### Risk level (write none, low medium or high below)
_If medium or high, explain what verification was done to mitigate the risks._
### Documentation Update
_Describe any necessary documentation update if there is any new feature, config, or user-facing change_
- _The config description must be updated if new configs are added or the default value of the configs are changed_
- _Any new feature or user-facing change requires updating the Hudi website. Please create a Jira ticket, attach the
ticket number here and follow the [instruction](https://hudi.apache.org/contribute/developer-setup#website) to make
changes to the website._
### Contributor's checklist
- [ ] Read through [contributor's guide](https://hudi.apache.org/contribute/how-to-contribute)
- [ ] Change Logs and Impact were stated clearly
- [ ] Adequate tests were added if applicable
- [ ] CI passed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #7086: [HUDI-4624] Implement Closable for S3EventsSource
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on PR #7086:
URL: https://github.com/apache/hudi/pull/7086#issuecomment-1299481683
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "7afa3cff8e8157d2962afd482163ac7eca5b021d",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=12653",
"triggerID" : "7afa3cff8e8157d2962afd482163ac7eca5b021d",
"triggerType" : "PUSH"
}, {
"hash" : "937ebe8fa4f817021a36f06b136b271dbbbd8e86",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=12695",
"triggerID" : "937ebe8fa4f817021a36f06b136b271dbbbd8e86",
"triggerType" : "PUSH"
}, {
"hash" : "3fdf983b772e3797f03a2c6fd25d9a1147351a32",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "3fdf983b772e3797f03a2c6fd25d9a1147351a32",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 937ebe8fa4f817021a36f06b136b271dbbbd8e86 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=12695)
* 3fdf983b772e3797f03a2c6fd25d9a1147351a32 UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #7086: [HUDI-4624] Implement Closable for S3EventsSource
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on PR #7086:
URL: https://github.com/apache/hudi/pull/7086#issuecomment-1295202521
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "7afa3cff8e8157d2962afd482163ac7eca5b021d",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "7afa3cff8e8157d2962afd482163ac7eca5b021d",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 7afa3cff8e8157d2962afd482163ac7eca5b021d UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #7086: [HUDI-4624] Implement Closable for S3EventsSource
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on PR #7086:
URL: https://github.com/apache/hudi/pull/7086#issuecomment-1297541527
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "7afa3cff8e8157d2962afd482163ac7eca5b021d",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=12653",
"triggerID" : "7afa3cff8e8157d2962afd482163ac7eca5b021d",
"triggerType" : "PUSH"
}, {
"hash" : "937ebe8fa4f817021a36f06b136b271dbbbd8e86",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "937ebe8fa4f817021a36f06b136b271dbbbd8e86",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 7afa3cff8e8157d2962afd482163ac7eca5b021d Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=12653)
* 937ebe8fa4f817021a36f06b136b271dbbbd8e86 UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #7086: [HUDI-4624] Implement Closable for S3EventsSource
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on PR #7086:
URL: https://github.com/apache/hudi/pull/7086#issuecomment-1297547831
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "7afa3cff8e8157d2962afd482163ac7eca5b021d",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=12653",
"triggerID" : "7afa3cff8e8157d2962afd482163ac7eca5b021d",
"triggerType" : "PUSH"
}, {
"hash" : "937ebe8fa4f817021a36f06b136b271dbbbd8e86",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=12695",
"triggerID" : "937ebe8fa4f817021a36f06b136b271dbbbd8e86",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 7afa3cff8e8157d2962afd482163ac7eca5b021d Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=12653)
* 937ebe8fa4f817021a36f06b136b271dbbbd8e86 Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=12695)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #7086: [HUDI-4624] Implement Closable for S3EventsSource
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on PR #7086:
URL: https://github.com/apache/hudi/pull/7086#issuecomment-1299639400
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "7afa3cff8e8157d2962afd482163ac7eca5b021d",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=12653",
"triggerID" : "7afa3cff8e8157d2962afd482163ac7eca5b021d",
"triggerType" : "PUSH"
}, {
"hash" : "937ebe8fa4f817021a36f06b136b271dbbbd8e86",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=12695",
"triggerID" : "937ebe8fa4f817021a36f06b136b271dbbbd8e86",
"triggerType" : "PUSH"
}, {
"hash" : "3fdf983b772e3797f03a2c6fd25d9a1147351a32",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=12714",
"triggerID" : "3fdf983b772e3797f03a2c6fd25d9a1147351a32",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 3fdf983b772e3797f03a2c6fd25d9a1147351a32 Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=12714)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #7086: [HUDI-4624] Implement Closable for S3EventsSource
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on PR #7086:
URL: https://github.com/apache/hudi/pull/7086#issuecomment-1295429133
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "7afa3cff8e8157d2962afd482163ac7eca5b021d",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=12653",
"triggerID" : "7afa3cff8e8157d2962afd482163ac7eca5b021d",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 7afa3cff8e8157d2962afd482163ac7eca5b021d Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=12653)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #7086: [HUDI-4624] Implement Closable for S3EventsSource
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on PR #7086:
URL: https://github.com/apache/hudi/pull/7086#issuecomment-1297718196
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "7afa3cff8e8157d2962afd482163ac7eca5b021d",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=12653",
"triggerID" : "7afa3cff8e8157d2962afd482163ac7eca5b021d",
"triggerType" : "PUSH"
}, {
"hash" : "937ebe8fa4f817021a36f06b136b271dbbbd8e86",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=12695",
"triggerID" : "937ebe8fa4f817021a36f06b136b271dbbbd8e86",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 937ebe8fa4f817021a36f06b136b271dbbbd8e86 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=12695)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] nsivabalan commented on pull request #7086: [HUDI-4624] Implement Closable for S3EventsSource
Posted by GitBox <gi...@apache.org>.
nsivabalan commented on PR #7086:
URL: https://github.com/apache/hudi/pull/7086#issuecomment-1299471528
rebased w/ latest mster.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #7086: [HUDI-4624] Implement Closable for S3EventsSource
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on PR #7086:
URL: https://github.com/apache/hudi/pull/7086#issuecomment-1295209085
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "7afa3cff8e8157d2962afd482163ac7eca5b021d",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=12653",
"triggerID" : "7afa3cff8e8157d2962afd482163ac7eca5b021d",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 7afa3cff8e8157d2962afd482163ac7eca5b021d Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=12653)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] nsivabalan merged pull request #7086: [HUDI-4624] Implement Closable for S3EventsSource
Posted by GitBox <gi...@apache.org>.
nsivabalan merged PR #7086:
URL: https://github.com/apache/hudi/pull/7086
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] nsivabalan commented on a diff in pull request #7086: [HUDI-4624] Implement Closable for S3EventsSource
Posted by GitBox <gi...@apache.org>.
nsivabalan commented on code in PR #7086:
URL: https://github.com/apache/hudi/pull/7086#discussion_r1008610920
##########
hudi-utilities/src/main/java/org/apache/hudi/utilities/sources/S3EventsSource.java:
##########
@@ -79,6 +81,13 @@ public Pair<Option<Dataset<Row>>, String> fetchNextBatch(Option<String> lastCkpt
}
}
+ @Override
+ public void close() throws IOException {
+ // close resource
+ this.sqs.shutdown();
+
Review Comment:
remove extra lines.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #7086: [HUDI-4624] Implement Closable for S3EventsSource
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on PR #7086:
URL: https://github.com/apache/hudi/pull/7086#issuecomment-1299485761
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "7afa3cff8e8157d2962afd482163ac7eca5b021d",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=12653",
"triggerID" : "7afa3cff8e8157d2962afd482163ac7eca5b021d",
"triggerType" : "PUSH"
}, {
"hash" : "937ebe8fa4f817021a36f06b136b271dbbbd8e86",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=12695",
"triggerID" : "937ebe8fa4f817021a36f06b136b271dbbbd8e86",
"triggerType" : "PUSH"
}, {
"hash" : "3fdf983b772e3797f03a2c6fd25d9a1147351a32",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=12714",
"triggerID" : "3fdf983b772e3797f03a2c6fd25d9a1147351a32",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 937ebe8fa4f817021a36f06b136b271dbbbd8e86 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=12695)
* 3fdf983b772e3797f03a2c6fd25d9a1147351a32 Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=12714)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org