You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Joris Van Remoortere <jo...@gmail.com> on 2014/10/22 20:19:32 UTC
Re: Review Request 27024: Libprocess Socket reduce over-include
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27024/
-----------------------------------------------------------
(Updated Oct. 22, 2014, 6:19 p.m.)
Review request for mesos, Benjamin Hindman and Niklas Nielsen.
Repository: mesos-git
Description
-------
Timeout only uses clock. Reduce inclusion to clock as opposed to all of process.hpp. This helps prevent circular dependency when we include future in socket.hpp.
Diffs
-----
3rdparty/libprocess/include/process/timeout.hpp 40906cb
Diff: https://reviews.apache.org/r/27024/diff/
Testing
-------
Thanks,
Joris Van Remoortere
Re: Review Request 27024: Libprocess Socket reduce over-include
Posted by Dominic Hamon <dh...@twopensource.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27024/#review57863
-----------------------------------------------------------
Ship it!
pending 'testing done' being filled out :)
- Dominic Hamon
On Oct. 22, 2014, 11:19 a.m., Joris Van Remoortere wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27024/
> -----------------------------------------------------------
>
> (Updated Oct. 22, 2014, 11:19 a.m.)
>
>
> Review request for mesos, Benjamin Hindman and Niklas Nielsen.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Timeout only uses clock. Reduce inclusion to clock as opposed to all of process.hpp. This helps prevent circular dependency when we include future in socket.hpp.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/include/process/timeout.hpp 40906cb
>
> Diff: https://reviews.apache.org/r/27024/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Joris Van Remoortere
>
>
Re: Review Request 27024: Libprocess Socket reduce over-include
Posted by Joris Van Remoortere <jo...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27024/
-----------------------------------------------------------
(Updated Oct. 22, 2014, 8:05 p.m.)
Review request for mesos, Benjamin Hindman and Niklas Nielsen.
Changes
-------
filled out testing done.
Repository: mesos-git
Description
-------
Timeout only uses clock. Reduce inclusion to clock as opposed to all of process.hpp. This helps prevent circular dependency when we include future in socket.hpp.
Diffs
-----
3rdparty/libprocess/include/process/timeout.hpp 40906cb
Diff: https://reviews.apache.org/r/27024/diff/
Testing (updated)
-------
make check with this patch and 27025 applied.
Thanks,
Joris Van Remoortere
Re: Review Request 27024: Libprocess Socket reduce over-include
Posted by Mesos ReviewBot <de...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27024/#review57866
-----------------------------------------------------------
Patch looks great!
Reviews applied: [27025, 27024]
All tests passed.
- Mesos ReviewBot
On Oct. 22, 2014, 6:19 p.m., Joris Van Remoortere wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27024/
> -----------------------------------------------------------
>
> (Updated Oct. 22, 2014, 6:19 p.m.)
>
>
> Review request for mesos, Benjamin Hindman and Niklas Nielsen.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Timeout only uses clock. Reduce inclusion to clock as opposed to all of process.hpp. This helps prevent circular dependency when we include future in socket.hpp.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/include/process/timeout.hpp 40906cb
>
> Diff: https://reviews.apache.org/r/27024/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Joris Van Remoortere
>
>