You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@brooklyn.apache.org by ahgittin <gi...@git.apache.org> on 2014/06/26 13:40:23 UTC

[GitHub] incubator-brooklyn pull request: code reviews from #12 and #19

GitHub user ahgittin opened a pull request:

    https://github.com/apache/incubator-brooklyn/pull/22

    code reviews from #12 and #19

    just tests, dead code, and var renames

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/ahgittin/incubator-brooklyn ha-use-last-mod-time

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-brooklyn/pull/22.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #22
    
----
commit bb4366126cc93512d9eda2dbe1bc5651bcd4cc0e
Author: Alex Heneveld <al...@cloudsoftcorp.com>
Date:   2014-06-26T10:52:21Z

    convert integration tests requiring credentials to Live, with some also Live-sanity

commit 6eda1ce2071d8b7a6e58b7d701f1339f617ef645
Author: Alex Heneveld <al...@cloudsoftcorp.com>
Date:   2014-06-26T11:37:39Z

    remove useless code and some renames following code review for #12

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-brooklyn pull request: code reviews from #12 and #19

Posted by aledsage <gi...@git.apache.org>.
Github user aledsage commented on the pull request:

    https://github.com/apache/incubator-brooklyn/pull/22#issuecomment-47218864
  
    Looks good; merging.
    
    Wish we had buildhive set up! @grkvlt are you looking into that?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-brooklyn pull request: code reviews from #12 and #19

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/incubator-brooklyn/pull/22


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---