[GitHub] [pulsar] merlimat commented on a change in pull request #11811: [ISSUE 11779] Get response from cause when completion exception

[GitBox <gi...@apache.org>]

merlimat commented on a change in pull request #11811:
URL: https://github.com/apache/pulsar/pull/11811#discussion_r697513733



##########
File path: pulsar-broker/src/main/resources/log4j2.xml
##########
@@ -0,0 +1,102 @@
+<?xml version="1.0" encoding="UTF-8"?>

Review comment:
       This file shouldn't be added to the PR

##########
File path: pulsar-broker/src/main/java/org/apache/pulsar/broker/web/PulsarWebResource.java
##########
@@ -961,7 +962,7 @@ public void validatePoliciesReadOnlyAccess() {
                             }
                             if (children != null && !children.isEmpty()) {
                                 checkNs.completeExceptionally(
-                                        new RestException(Status.PRECONDITION_FAILED, "Tenant has active namespace"));
+                                        new RestException(Status.CONFLICT, "The tenant still has active namespace"));

Review comment:
       I'm not sure we should change the response code here. Client are expecting the PRECONDITION_FAILED in some of the places.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org