You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@ranger.apache.org by Madhan Neethiraj <ma...@apache.org> on 2022/12/09 19:00:21 UTC

Review Request 74249: RANGER-4011: option to disable creation of default policy per hierarchy

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/74249/
-----------------------------------------------------------

Review request for ranger, Ankita Sinha, Kishor Gollapalliwar, Abhay Kulkarni, Mehul Parikh, Pradeep Agrawal, Ramesh Mani, Siddhesh Phatak, Sailaja Polavarapu, Subhrat Chaudhary, and Velmurugan Periasamy.


Bugs: RANGER-4011
    https://issues.apache.org/jira/browse/RANGER-4011


Repository: ranger


Description
-------

- updated to skip creation of default policy per hierarchy when disabled via following service-config:
  create.default.policy.per.hierarchy=false
- this option can be specified at service-def level as well, which will be the default for all services created for the service-type


Diffs
-----

  agents-common/src/main/java/org/apache/ranger/plugin/service/RangerBaseService.java f8926a905 


Diff: https://reviews.apache.org/r/74249/diff/1/


Testing
-------

- verified that all tests pass successfully
- verified no changes to current behavior by default i.e. default policy per hierarchy is created
- verified that when service-config create.default.policy.per.hierarchy is set to false, these default policies are not created
- verified that when service-config create.default.policy.per.hierarchy is set to true, these default policies are created


Thanks,

Madhan Neethiraj

Re: Review Request 74249: RANGER-4011: option to disable creation of default policy per hierarchy

Posted by Ramesh Mani <rm...@hortonworks.com>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/74249/#review224993
-----------------------------------------------------------


Ship it!




Ship It!

- Ramesh Mani


On Dec. 9, 2022, 7 p.m., Madhan Neethiraj wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/74249/
> -----------------------------------------------------------
> 
> (Updated Dec. 9, 2022, 7 p.m.)
> 
> 
> Review request for ranger, Ankita Sinha, Kishor Gollapalliwar, Abhay Kulkarni, Mehul Parikh, Pradeep Agrawal, Ramesh Mani, Siddhesh Phatak, Sailaja Polavarapu, Subhrat Chaudhary, and Velmurugan Periasamy.
> 
> 
> Bugs: RANGER-4011
>     https://issues.apache.org/jira/browse/RANGER-4011
> 
> 
> Repository: ranger
> 
> 
> Description
> -------
> 
> - updated to skip creation of default policy per hierarchy when disabled via following service-config:
>   create.default.policy.per.hierarchy=false
> - this option can be specified at service-def level as well, which will be the default for all services created for the service-type
> 
> 
> Diffs
> -----
> 
>   agents-common/src/main/java/org/apache/ranger/plugin/service/RangerBaseService.java f8926a905 
> 
> 
> Diff: https://reviews.apache.org/r/74249/diff/1/
> 
> 
> Testing
> -------
> 
> - verified that all tests pass successfully
> - verified no changes to current behavior by default i.e. default policy per hierarchy is created
> - verified that when service-config create.default.policy.per.hierarchy is set to false, these default policies are not created
> - verified that when service-config create.default.policy.per.hierarchy is set to true, these default policies are created
> 
> 
> Thanks,
> 
> Madhan Neethiraj
> 
>

Re: Review Request 74249: RANGER-4011: option to disable creation of default policy per hierarchy

Posted by Abhay Kulkarni <ak...@hortonworks.com>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/74249/#review224992
-----------------------------------------------------------


Ship it!




Ship It!

- Abhay Kulkarni


On Dec. 9, 2022, 7 p.m., Madhan Neethiraj wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/74249/
> -----------------------------------------------------------
> 
> (Updated Dec. 9, 2022, 7 p.m.)
> 
> 
> Review request for ranger, Ankita Sinha, Kishor Gollapalliwar, Abhay Kulkarni, Mehul Parikh, Pradeep Agrawal, Ramesh Mani, Siddhesh Phatak, Sailaja Polavarapu, Subhrat Chaudhary, and Velmurugan Periasamy.
> 
> 
> Bugs: RANGER-4011
>     https://issues.apache.org/jira/browse/RANGER-4011
> 
> 
> Repository: ranger
> 
> 
> Description
> -------
> 
> - updated to skip creation of default policy per hierarchy when disabled via following service-config:
>   create.default.policy.per.hierarchy=false
> - this option can be specified at service-def level as well, which will be the default for all services created for the service-type
> 
> 
> Diffs
> -----
> 
>   agents-common/src/main/java/org/apache/ranger/plugin/service/RangerBaseService.java f8926a905 
> 
> 
> Diff: https://reviews.apache.org/r/74249/diff/1/
> 
> 
> Testing
> -------
> 
> - verified that all tests pass successfully
> - verified no changes to current behavior by default i.e. default policy per hierarchy is created
> - verified that when service-config create.default.policy.per.hierarchy is set to false, these default policies are not created
> - verified that when service-config create.default.policy.per.hierarchy is set to true, these default policies are created
> 
> 
> Thanks,
> 
> Madhan Neethiraj
> 
>