You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "stijndehaes (via GitHub)" <gi...@apache.org> on 2023/05/03 14:58:03 UTC
[GitHub] [spark] stijndehaes opened a new pull request, #41035: [SPARK-43357][SQL] Filter date type quote date
stijndehaes opened a new pull request, #41035:
URL: https://github.com/apache/spark/pull/41035
<!--
Thanks for sending a pull request! Here are some tips for you:
1. If this is your first time, please read our contributor guidelines: https://spark.apache.org/contributing.html
2. Ensure you have added or run the appropriate tests for your PR: https://spark.apache.org/developer-tools.html
3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP][SPARK-XXXX] Your PR title ...'.
4. Be sure to keep the PR description updated to reflect all changes.
5. Please write your PR title to summarize what this PR proposes.
6. If possible, provide a concise example to reproduce the issue for a faster review.
7. If you want to add a new configuration, please read the guideline first for naming configurations in
'core/src/main/scala/org/apache/spark/internal/config/ConfigEntry.scala'.
8. If you want to add or modify an error type or message, please read the guideline first in
'core/src/main/resources/error/README.md'.
-->
### What changes were proposed in this pull request?
<!--
Please clarify what changes you are proposing. The purpose of this section is to outline the changes and how this PR fixes the issue.
If possible, please consider writing useful notes for better and faster reviews in your PR. See the examples below.
1. If you refactor some codes with changing classes, showing the class hierarchy will help reviewers.
2. If you fix some SQL features, you can provide some references of other DBMSes.
3. If there is design documentation, please add the link.
4. If there is a discussion in the mailing list, please add the link.
-->
In this PR the date value is quoted before being sent to the hive metastore
### Why are the changes needed?
<!--
Please clarify why the changes are needed. For instance,
1. If you propose a new API, clarify the use case for a new API.
2. If you fix a bug, you can clarify why it is a bug.
-->
Glue for example expects the dates to be quoted, without quotes we get errors.
### Does this PR introduce _any_ user-facing change?
<!--
Note that it means *any* user-facing change including all aspects such as the documentation fix.
If yes, please clarify the previous behavior and the change this PR proposes - provide the console output, description and/or an example to show the behavior difference if possible.
If possible, please also clarify if this is a user-facing change compared to the released Spark versions or within the unreleased branches such as master.
If no, write 'No'.
-->
No
### How was this patch tested?
<!--
If tests were added, say they were added here. Please make sure to add some test cases that check the changes thoroughly including negative and positive cases if possible.
If it was tested in a way different from regular unit tests, please clarify how you tested step by step, ideally copy and paste-able, so that other reviewers can test and check, and descendants can verify in the future.
If tests were not added, please describe why they were not added and/or why it was difficult to add.
If benchmark tests were added, please run the benchmarks in GitHub Actions for the consistent environment, and the instructions could accord to: https://spark.apache.org/developer-tools.html#github-workflow-benchmarks.
-->
Changed the result of unit tests, also tested by running the fix against glue
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] wangyum commented on a diff in pull request #41035: [SPARK-43357][SQL] Filter date type quote date
Posted by "wangyum (via GitHub)" <gi...@apache.org>.
wangyum commented on code in PR #41035:
URL: https://github.com/apache/spark/pull/41035#discussion_r1188461614
##########
sql/hive/src/test/scala/org/apache/spark/sql/hive/client/FiltersSuite.scala:
##########
@@ -66,17 +66,17 @@ class FiltersSuite extends SparkFunSuite with PlanTest {
filterTest("date filter",
(a("datecol", DateType) === Literal(Date.valueOf("2019-01-01"))) :: Nil,
- "datecol = 2019-01-01")
Review Comment:
It seems it is only used for partition filtering in metastore:
https://github.com/apache/hive/blob/e8076ef41de842b9adceea4f854a92d9d1d1388b/metastore/src/java/org/apache/hadoop/hive/metastore/parser/Filter.g#L48
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on a diff in pull request #41035: [SPARK-43357][SQL] Filter date type quote date
Posted by "cloud-fan (via GitHub)" <gi...@apache.org>.
cloud-fan commented on code in PR #41035:
URL: https://github.com/apache/spark/pull/41035#discussion_r1188380959
##########
sql/hive/src/test/scala/org/apache/spark/sql/hive/client/FiltersSuite.scala:
##########
@@ -66,17 +66,17 @@ class FiltersSuite extends SparkFunSuite with PlanTest {
filterTest("date filter",
(a("datecol", DateType) === Literal(Date.valueOf("2019-01-01"))) :: Nil,
- "datecol = 2019-01-01")
Review Comment:
I'm surprised hive supports this SQL syntax... `datecol = 2019-01-01`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on pull request #41035: [SPARK-43357][SQL] Filter date type quote date
Posted by "cloud-fan (via GitHub)" <gi...@apache.org>.
cloud-fan commented on PR #41035:
URL: https://github.com/apache/spark/pull/41035#issuecomment-1540087266
thanks, merging to master!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] Hisoka-X commented on pull request #41035: [SPARK-43357][SQL] Filter date type quote date
Posted by "Hisoka-X (via GitHub)" <gi...@apache.org>.
Hisoka-X commented on PR #41035:
URL: https://github.com/apache/spark/pull/41035#issuecomment-1537459679
This change is not backward compatible, I'm not sure if this change is necessary, if necessary, also need parameters to control whether to open.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on pull request #41035: [SPARK-43357][SQL] Filter date type quote date
Posted by "cloud-fan (via GitHub)" <gi...@apache.org>.
cloud-fan commented on PR #41035:
URL: https://github.com/apache/spark/pull/41035#issuecomment-1539779576
@wangyum does all hive versions support it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] wangyum commented on pull request #41035: [SPARK-43357][SQL] Filter date type quote date
Posted by "wangyum (via GitHub)" <gi...@apache.org>.
wangyum commented on PR #41035:
URL: https://github.com/apache/spark/pull/41035#issuecomment-1539821190
> @wangyum does all hive versions support it?
Hive 0.13.0 and later support it: https://issues.apache.org/jira/browse/HIVE-5679.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] wangyum commented on pull request #41035: [SPARK-43357][SQL] Filter date type quote date
Posted by "wangyum (via GitHub)" <gi...@apache.org>.
wangyum commented on PR #41035:
URL: https://github.com/apache/spark/pull/41035#issuecomment-1537472631
@stijndehaes Do you have the error message if do not quote date?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] stijndehaes commented on pull request #41035: [SPARK-43357][SQL] Filter date type quote date
Posted by "stijndehaes (via GitHub)" <gi...@apache.org>.
stijndehaes commented on PR #41035:
URL: https://github.com/apache/spark/pull/41035#issuecomment-1538219912
@wangyum @Hisoka-X
There is more info in the issue on JIRA: https://issues.apache.org/jira/browse/SPARK-43357
So basically when integrating we glue we are getting issues:
```
org.apache.hadoop.hive.metastore.api.InvalidObjectException: Unsupported expression '2023 - 05 - 03' (Service: AWSGlue; Status Code: 400; Error Code: InvalidInputException; Request ID: beed68c6-b228-442e-8783-52c25b9d2243; Proxy: null)
```
Now this issue might be on the side of glue, but glue is supposed to be hive compatible. So I think this should also work with a hive catalog. However I do not have access to one, and would net to se one up.
So maybe someone with more experience with that could help me to test compatibility.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan closed pull request #41035: [SPARK-43357][SQL] Filter date type quote date
Posted by "cloud-fan (via GitHub)" <gi...@apache.org>.
cloud-fan closed pull request #41035: [SPARK-43357][SQL] Filter date type quote date
URL: https://github.com/apache/spark/pull/41035
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org