You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@dubbo.apache.org by "vio-lin (GitHub)" <gi...@apache.org> on 2019/04/08 06:51:27 UTC
[GitHub] [incubator-dubbo] vio-lin opened pull request #3825: support
google pb generic invocation
## What is the purpose of the change
Currently, Generic Reference cannot support Google Protobuf. With bride usage of Google PB, we are going to support it via Generic Reference.
## Brief changelog
1. add ProtobufUtil.class to serialize /deserialize Google Protobuf Object
2. modify GenericFilter.class
## feedback wanted
To support Google PB Testing, GenericFilter is part of my change, also Service Metadata have to support that. If the solution is ok, i will continue on the Service Metadata part.
[ Full content available at: https://github.com/apache/incubator-dubbo/pull/3825 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org
[GitHub] [incubator-dubbo] codecov-io commented on issue #3825:
support google pb generic invocation
Posted by "codecov-io (GitHub)" <gi...@apache.org>.
# [Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/3825?src=pr&el=h1) Report
> Merging [#3825](https://codecov.io/gh/apache/incubator-dubbo/pull/3825?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-dubbo/commit/a378a019949d5989e3e8a54e0e02b8a9f68745be?src=pr&el=desc) will **decrease** coverage by `1.51%`.
> The diff coverage is `0.22%`.
[](https://codecov.io/gh/apache/incubator-dubbo/pull/3825?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #3825 +/- ##
============================================
- Coverage 63.6% 62.09% -1.52%
Complexity 71 71
============================================
Files 708 731 +23
Lines 31192 33477 +2285
Branches 5048 5348 +300
============================================
+ Hits 19839 20786 +947
- Misses 9072 10297 +1225
- Partials 2281 2394 +113
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-dubbo/pull/3825?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...c/main/java/org/apache/dubbo/common/Constants.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3825/diff?src=pr&el=tree#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb21tb24vQ29uc3RhbnRzLmphdmE=) | `93.33% <ø> (ø)` | `0 <0> (ø)` | :arrow_down: |
| [...a/org/apache/dubbo/common/utils/ProtobufUtils.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3825/diff?src=pr&el=tree#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb21tb24vdXRpbHMvUHJvdG9idWZVdGlscy5qYXZh) | `0% <0%> (ø)` | `0 <0> (?)` | |
| [...ava/org/apache/dubbo/rpc/filter/GenericFilter.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3825/diff?src=pr&el=tree#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9maWx0ZXIvR2VuZXJpY0ZpbHRlci5qYXZh) | `59.09% <0%> (-9.34%)` | `0 <0> (ø)` | |
| [...a/org/apache/dubbo/demo/protobuf/api/GooglePb.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3825/diff?src=pr&el=tree#diff-ZHViYm8tZGVtby9kdWJiby1kZW1vLXByb3RvYnVmL2R1YmJvLWRlbW8tcHJvdG9idWYtYXBpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9kZW1vL3Byb3RvYnVmL2FwaS9Hb29nbGVQYi5qYXZh) | `0% <0%> (ø)` | `0 <0> (?)` | |
| [...va/org/apache/dubbo/rpc/support/ProtocolUtils.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3825/diff?src=pr&el=tree#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9zdXBwb3J0L1Byb3RvY29sVXRpbHMuamF2YQ==) | `72% <33.33%> (-6.27%)` | `0 <0> (ø)` | |
| [...ng/exchange/support/header/HeartbeatTimerTask.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3825/diff?src=pr&el=tree#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctYXBpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9yZW1vdGluZy9leGNoYW5nZS9zdXBwb3J0L2hlYWRlci9IZWFydGJlYXRUaW1lclRhc2suamF2YQ==) | `73.68% <0%> (-5.27%)` | `0% <0%> (ø)` | |
| [...e/dubbo/remoting/transport/netty/NettyChannel.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3825/diff?src=pr&el=tree#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctbmV0dHkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JlbW90aW5nL3RyYW5zcG9ydC9uZXR0eS9OZXR0eUNoYW5uZWwuamF2YQ==) | `57.64% <0%> (-4.71%)` | `0% <0%> (ø)` | |
| [...he/dubbo/registry/multicast/MulticastRegistry.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3825/diff?src=pr&el=tree#diff-ZHViYm8tcmVnaXN0cnkvZHViYm8tcmVnaXN0cnktbXVsdGljYXN0L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9yZWdpc3RyeS9tdWx0aWNhc3QvTXVsdGljYXN0UmVnaXN0cnkuamF2YQ==) | `67.87% <0%> (-1.81%)` | `0% <0%> (ø)` | |
| [...pache/dubbo/registry/support/AbstractRegistry.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3825/diff?src=pr&el=tree#diff-ZHViYm8tcmVnaXN0cnkvZHViYm8tcmVnaXN0cnktYXBpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9yZWdpc3RyeS9zdXBwb3J0L0Fic3RyYWN0UmVnaXN0cnkuamF2YQ==) | `80.31% <0%> (-0.4%)` | `0% <0%> (ø)` | |
| [...bbo/rpc/protocol/thrift/io/InputStreamWrapper.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3825/diff?src=pr&el=tree#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10aHJpZnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90aHJpZnQvaW8vSW5wdXRTdHJlYW1XcmFwcGVyLmphdmE=) | `0% <0%> (ø)` | `0% <0%> (?)` | |
| ... and [26 more](https://codecov.io/gh/apache/incubator-dubbo/pull/3825/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/3825?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/3825?src=pr&el=footer). Last update [a378a01...70245a2](https://codecov.io/gh/apache/incubator-dubbo/pull/3825?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
[ Full content available at: https://github.com/apache/incubator-dubbo/pull/3825 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org