[GitHub] [incubator-iceberg] rdblue commented on a change in pull request #952: Merge ManifestEntry and DataFile classes

[GitBox <gi...@apache.org>]

rdblue commented on a change in pull request #952:
URL: https://github.com/apache/incubator-iceberg/pull/952#discussion_r413926234



##########
File path: core/src/main/java/org/apache/iceberg/ManifestEntry.java
##########
@@ -54,7 +57,12 @@ static Schema getSchema(StructType partitionType) {
   }
 
   static Schema wrapFileSchema(StructType fileType) {
-    return new Schema(STATUS, SNAPSHOT_ID, SEQUENCE_NUMBER, required(DATA_FILE_ID, "data_file", fileType));
+    // remove ManifestEntry fields from the file type when wrapping to avoid duplication

Review comment:
       I should note that this PR doesn't actually add the manifest entry fields to `DataFile`, it just sets up that change.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org