You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2022/10/11 06:41:32 UTC
[GitHub] [shardingsphere] RaigorJiang opened a new issue, #21485: Unified metadata naming
RaigorJiang opened a new issue, #21485:
URL: https://github.com/apache/shardingsphere/issues/21485
I found some metadata related classes with camel case `MetaData` in their names like
```java
/**
* Meta data contexts.
*/
@RequiredArgsConstructor
@Getter
public final class MetaDataContexts
```
But there are also some that do not use camel case, such as
```java
/**
* SPI metadata aware.
*/
public interface SPIMetadataAware {
```
In fact, `Metadata` is a proper noun, it does not need to be split.
I propose a uniform adjustment to the related names, including related comments.
Ref: https://en.wikipedia.org/wiki/Metadata
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] RaigorJiang commented on issue #21485: Unify metadata naming
Posted by GitBox <gi...@apache.org>.
RaigorJiang commented on issue #21485:
URL: https://github.com/apache/shardingsphere/issues/21485#issuecomment-1311778209
> @RaigorJiang Check my PR #22066
Please hava a look: https://github.com/apache/shardingsphere/pull/22066#pullrequestreview-1177431946
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] RaigorJiang commented on issue #21485: Unified metadata naming
Posted by GitBox <gi...@apache.org>.
RaigorJiang commented on issue #21485:
URL: https://github.com/apache/shardingsphere/issues/21485#issuecomment-1304477689
Hi @Swastyy,
Can we assign the issue to @DivvSaxena ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] DivvSaxena commented on issue #21485: Unified metadata naming
Posted by GitBox <gi...@apache.org>.
DivvSaxena commented on issue #21485:
URL: https://github.com/apache/shardingsphere/issues/21485#issuecomment-1310586946
@RaigorJiang Check my PR #22066
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] terrymanu closed issue #21485: Unify metadata naming
Posted by GitBox <gi...@apache.org>.
terrymanu closed issue #21485: Unify metadata naming
URL: https://github.com/apache/shardingsphere/issues/21485
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] DivvSaxena commented on issue #21485: Unify metadata naming
Posted by GitBox <gi...@apache.org>.
DivvSaxena commented on issue #21485:
URL: https://github.com/apache/shardingsphere/issues/21485#issuecomment-1312768442
Hey @RaigorJiang !
I made PRs and checked all the files and modified it PRs- #22155 #22130
Lets connect on slack and Linkedln please drop your id
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] RaigorJiang commented on issue #21485: Unified metadata naming
Posted by GitBox <gi...@apache.org>.
RaigorJiang commented on issue #21485:
URL: https://github.com/apache/shardingsphere/issues/21485#issuecomment-1304561845
> Alright @RaigorJiang , I am little busy this week too, we can assign it to him.
Well, thank you! @Swastyy @DivvSaxena
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] Swastyy commented on issue #21485: Unified metadata naming
Posted by GitBox <gi...@apache.org>.
Swastyy commented on issue #21485:
URL: https://github.com/apache/shardingsphere/issues/21485#issuecomment-1304500700
Alright @RaigorJiang , I am little busy this week too, we can assign it to him.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] RaigorJiang commented on issue #21485: Unify metadata naming
Posted by GitBox <gi...@apache.org>.
RaigorJiang commented on issue #21485:
URL: https://github.com/apache/shardingsphere/issues/21485#issuecomment-1323324041
@DivvSaxena
Sorry, CI is still failing.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] RaigorJiang commented on issue #21485: Unify metadata naming
Posted by GitBox <gi...@apache.org>.
RaigorJiang commented on issue #21485:
URL: https://github.com/apache/shardingsphere/issues/21485#issuecomment-1312627897
@DivvSaxena
In fact, there are many such files that need to be modified, which is the purpose of this issue.
<img width="671" alt="image" src="https://user-images.githubusercontent.com/5668787/201503778-e9466887-6286-44d7-b8bd-c0b073133986.png">
<img width="1317" alt="image" src="https://user-images.githubusercontent.com/5668787/201503812-ee4470ae-205b-4fa3-82e0-c83307b857b6.png">
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] DivvSaxena commented on issue #21485: Unify metadata naming
Posted by GitBox <gi...@apache.org>.
DivvSaxena commented on issue #21485:
URL: https://github.com/apache/shardingsphere/issues/21485#issuecomment-1312531261
@RaigorJiang I understood that Metadata is a proper noun and it should not be written like "Meta data" or "meta data" , Thus i have updated please check my PR #22130
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] terrymanu commented on issue #21485: Unify metadata naming
Posted by GitBox <gi...@apache.org>.
terrymanu commented on issue #21485:
URL: https://github.com/apache/shardingsphere/issues/21485#issuecomment-1341174687
I just revert the changes of #22704
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] DivvSaxena commented on issue #21485: Unify metadata naming
Posted by GitBox <gi...@apache.org>.
DivvSaxena commented on issue #21485:
URL: https://github.com/apache/shardingsphere/issues/21485#issuecomment-1312756632
@RaigorJiang Ok i will submit PRs for ech module separately.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] RaigorJiang commented on issue #21485: Unify metadata naming
Posted by GitBox <gi...@apache.org>.
RaigorJiang commented on issue #21485:
URL: https://github.com/apache/shardingsphere/issues/21485#issuecomment-1341263381
> It is better to keep consists with the JDBC interface. for example: java.sql.ResultSetMetaData
>
> I prefer to use MetaData
OK.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] terrymanu commented on issue #21485: Unify metadata naming
Posted by GitBox <gi...@apache.org>.
terrymanu commented on issue #21485:
URL: https://github.com/apache/shardingsphere/issues/21485#issuecomment-1341172465
It is better to keep consists with the JDBC interface.
for example: java.sql.ResultSetMetaData
I prefer to use MetaData
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] RaigorJiang commented on issue #21485: Unified metadata naming
Posted by GitBox <gi...@apache.org>.
RaigorJiang commented on issue #21485:
URL: https://github.com/apache/shardingsphere/issues/21485#issuecomment-1274502371
@Swastyy Welcome :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] Swastyy commented on issue #21485: Unified metadata naming
Posted by GitBox <gi...@apache.org>.
Swastyy commented on issue #21485:
URL: https://github.com/apache/shardingsphere/issues/21485#issuecomment-1274303543
I want to work on it :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] DivvSaxena commented on issue #21485: Unified metadata naming
Posted by GitBox <gi...@apache.org>.
DivvSaxena commented on issue #21485:
URL: https://github.com/apache/shardingsphere/issues/21485#issuecomment-1303110576
@RaigorJiang If no one is working on it , can u assign it to me
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org