You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@netbeans.apache.org by GitBox <gi...@apache.org> on 2022/11/01 00:10:56 UTC
[GitHub] [netbeans-tools] javierllorente opened a new pull request, #54: Implement RPM packaging
javierllorente opened a new pull request, #54:
URL: https://github.com/apache/netbeans-tools/pull/54
I have based this on the Debian packaging feature.
RPM built with nbpackage tested on openSUSE and Fedora.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans-tools] neilcsmith-net commented on pull request #54: Implement RPM packaging
Posted by GitBox <gi...@apache.org>.
neilcsmith-net commented on PR #54:
URL: https://github.com/apache/netbeans-tools/pull/54#issuecomment-1298264391
Amazing, thanks! Been on my to-do list for a while. Glad to get contributions to NBPackage. Will review ASAP!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans-tools] javierllorente commented on a diff in pull request #54: Implement RPM packaging
Posted by GitBox <gi...@apache.org>.
javierllorente commented on code in PR #54:
URL: https://github.com/apache/netbeans-tools/pull/54#discussion_r1017129914
##########
nbpackage/src/main/resources/org/apache/netbeans/nbpackage/rpm/rpm.spec.template:
##########
@@ -0,0 +1,23 @@
+Name: ${RPM_PACKAGE}
+Version: ${RPM_VERSION}
+Release: 0
+Summary: ${RPM_SUMMARY}
+License: Apache License 2.0
+Group: Development/Tools/IDE
+URL: https://netbeans.apache.org/
+BuildArch: ${RPM_ARCH}
+Packager: ${RPM_MAINTAINER}
+Vendor: Apache NetBeans
+Requires: java >= 11
Review Comment:
OK, so that line should be written on demand (JDK vs no JDK shipped).
##########
nbpackage/src/main/resources/org/apache/netbeans/nbpackage/rpm/rpm.spec.template:
##########
@@ -0,0 +1,23 @@
+Name: ${RPM_PACKAGE}
+Version: ${RPM_VERSION}
+Release: 0
+Summary: ${RPM_SUMMARY}
+License: Apache License 2.0
+Group: Development/Tools/IDE
+URL: https://netbeans.apache.org/
+BuildArch: ${RPM_ARCH}
+Packager: ${RPM_MAINTAINER}
+Vendor: Apache NetBeans
+Requires: java >= 11
+Recommends: ${RPM_RECOMMENDS}
+AutoReqProv: no
+
+%description
+${RPM_DESCRIPTION}
+
+%files
+%{_bindir}/netbeans
Review Comment:
%{name} resolves to apache-netbeans. That's why I setted it to netbeans.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans-tools] javierllorente commented on a diff in pull request #54: Implement RPM packaging
Posted by GitBox <gi...@apache.org>.
javierllorente commented on code in PR #54:
URL: https://github.com/apache/netbeans-tools/pull/54#discussion_r1017128190
##########
nbpackage/src/main/resources/org/apache/netbeans/nbpackage/rpm/rpm.spec.template:
##########
@@ -0,0 +1,23 @@
+Name: ${RPM_PACKAGE}
+Version: ${RPM_VERSION}
+Release: 0
+Summary: ${RPM_SUMMARY}
+License: Apache License 2.0
+Group: Development/Tools/IDE
+URL: https://netbeans.apache.org/
+BuildArch: ${RPM_ARCH}
+Packager: ${RPM_MAINTAINER}
+Vendor: Apache NetBeans
Review Comment:
Vendor is not needed but I think it is better to include it. Do you mean that if no vendor is given, default to maintainer?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans-tools] javierllorente commented on pull request #54: Implement RPM packaging
Posted by GitBox <gi...@apache.org>.
javierllorente commented on PR #54:
URL: https://github.com/apache/netbeans-tools/pull/54#issuecomment-1320903509
>Looks great, many thanks! Will merge.
Excellent. Thanks to you!
>I've been making a bunch of changes so we can move towards releasing NBPackage. I may look at changing a couple of these options into global ones before then, as they can probably be used in the other packagers (eg. InnoSetup template has a to-do around URLs)
Good idea. There are some repeated variables (maintainer, license, ...).
>As an aside to this, but related to release - as the first person to contribute another packager, did the API make sense? Anything confusing? Thanks!
It's a clean API. I have spent most of the time adjusting rpmbuild.
Some cleaning of unneeded files would be nice, such as netbeans.exe.
NBPackage could be also adapted to package other Java apps (ie: GlassFish); it would extract the zip, skip creating a launcher/copying icons, package all the bits and voilà. A bit out of scope?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans-tools] javierllorente commented on a diff in pull request #54: Implement RPM packaging
Posted by GitBox <gi...@apache.org>.
javierllorente commented on code in PR #54:
URL: https://github.com/apache/netbeans-tools/pull/54#discussion_r1026744394
##########
nbpackage/src/main/resources/org/apache/netbeans/nbpackage/rpm/rpm.spec.template:
##########
@@ -0,0 +1,23 @@
+Name: ${RPM_PACKAGE}
+Version: ${RPM_VERSION}
+Release: 0
+Summary: ${RPM_SUMMARY}
+License: Apache License 2.0
+Group: Development/Tools/IDE
+URL: https://netbeans.apache.org/
+BuildArch: ${RPM_ARCH}
+Packager: ${RPM_MAINTAINER}
+Vendor: Apache NetBeans
Review Comment:
Done. See comment above.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans-tools] neilcsmith-net commented on a diff in pull request #54: Implement RPM packaging
Posted by GitBox <gi...@apache.org>.
neilcsmith-net commented on code in PR #54:
URL: https://github.com/apache/netbeans-tools/pull/54#discussion_r1016647620
##########
nbpackage/src/main/resources/org/apache/netbeans/nbpackage/rpm/rpm.spec.template:
##########
@@ -0,0 +1,23 @@
+Name: ${RPM_PACKAGE}
+Version: ${RPM_VERSION}
+Release: 0
Review Comment:
Should this default to 1?
##########
nbpackage/src/main/resources/org/apache/netbeans/nbpackage/rpm/rpm.spec.template:
##########
@@ -0,0 +1,23 @@
+Name: ${RPM_PACKAGE}
+Version: ${RPM_VERSION}
+Release: 0
+Summary: ${RPM_SUMMARY}
+License: Apache License 2.0
+Group: Development/Tools/IDE
+URL: https://netbeans.apache.org/
Review Comment:
The default template needs to be software neutral. Which fields are required? If we need a license field, it needs to be an option, same with URL. If group needed, can it be the same as the .desktop file group?
##########
nbpackage/src/main/resources/org/apache/netbeans/nbpackage/rpm/rpm.spec.template:
##########
@@ -0,0 +1,23 @@
+Name: ${RPM_PACKAGE}
+Version: ${RPM_VERSION}
+Release: 0
+Summary: ${RPM_SUMMARY}
+License: Apache License 2.0
+Group: Development/Tools/IDE
+URL: https://netbeans.apache.org/
+BuildArch: ${RPM_ARCH}
+Packager: ${RPM_MAINTAINER}
+Vendor: Apache NetBeans
+Requires: java >= 11
Review Comment:
Shouldn't be any requires. Package with runtime has Java. Package without should be covered by Recommends.
##########
nbpackage/src/main/resources/org/apache/netbeans/nbpackage/rpm/rpm.spec.template:
##########
@@ -0,0 +1,23 @@
+Name: ${RPM_PACKAGE}
+Version: ${RPM_VERSION}
+Release: 0
+Summary: ${RPM_SUMMARY}
+License: Apache License 2.0
+Group: Development/Tools/IDE
+URL: https://netbeans.apache.org/
+BuildArch: ${RPM_ARCH}
+Packager: ${RPM_MAINTAINER}
+Vendor: Apache NetBeans
Review Comment:
If vendor needed, possibly default to same as maintainer?
##########
nbpackage/src/main/resources/org/apache/netbeans/nbpackage/rpm/rpm.spec.template:
##########
@@ -0,0 +1,23 @@
+Name: ${RPM_PACKAGE}
+Version: ${RPM_VERSION}
+Release: 0
+Summary: ${RPM_SUMMARY}
+License: Apache License 2.0
+Group: Development/Tools/IDE
+URL: https://netbeans.apache.org/
+BuildArch: ${RPM_ARCH}
+Packager: ${RPM_MAINTAINER}
+Vendor: Apache NetBeans
+Requires: java >= 11
+Recommends: ${RPM_RECOMMENDS}
+AutoReqProv: no
+
+%description
+${RPM_DESCRIPTION}
+
+%files
+%{_bindir}/netbeans
Review Comment:
Can't default to `netbeans` - needs to set the correct binary name.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans-tools] neilcsmith-net commented on a diff in pull request #54: Implement RPM packaging
Posted by GitBox <gi...@apache.org>.
neilcsmith-net commented on code in PR #54:
URL: https://github.com/apache/netbeans-tools/pull/54#discussion_r1018109283
##########
nbpackage/src/main/resources/org/apache/netbeans/nbpackage/rpm/rpm.spec.template:
##########
@@ -0,0 +1,23 @@
+Name: ${RPM_PACKAGE}
+Version: ${RPM_VERSION}
+Release: 0
+Summary: ${RPM_SUMMARY}
+License: Apache License 2.0
+Group: Development/Tools/IDE
+URL: https://netbeans.apache.org/
+BuildArch: ${RPM_ARCH}
+Packager: ${RPM_MAINTAINER}
+Vendor: Apache NetBeans
+Requires: java >= 11
Review Comment:
I assume Recommends works similarly to DEB, in that packaging tools will usually prompt to install, but it can be installed without error if someone did want to use a JDK they'd installed in some other fashion?
If the runtime is bundled, then there is no need for the JDK at all. That's why it's only added in the DEB when no JDK is included.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans-tools] javierllorente commented on a diff in pull request #54: Implement RPM packaging
Posted by GitBox <gi...@apache.org>.
javierllorente commented on code in PR #54:
URL: https://github.com/apache/netbeans-tools/pull/54#discussion_r1026747222
##########
nbpackage/src/main/resources/org/apache/netbeans/nbpackage/rpm/rpm.spec.template:
##########
@@ -0,0 +1,23 @@
+Name: ${RPM_PACKAGE}
+Version: ${RPM_VERSION}
+Release: 0
+Summary: ${RPM_SUMMARY}
+License: Apache License 2.0
+Group: Development/Tools/IDE
+URL: https://netbeans.apache.org/
+BuildArch: ${RPM_ARCH}
+Packager: ${RPM_MAINTAINER}
+Vendor: Apache NetBeans
+Requires: java >= 11
+Recommends: ${RPM_RECOMMENDS}
+AutoReqProv: no
+
+%description
+${RPM_DESCRIPTION}
+
+%files
+%{_bindir}/netbeans
Review Comment:
Fixed. I am now passing execName to setupSpecFile() and using a token as suggested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans-tools] javierllorente commented on a diff in pull request #54: Implement RPM packaging
Posted by GitBox <gi...@apache.org>.
javierllorente commented on code in PR #54:
URL: https://github.com/apache/netbeans-tools/pull/54#discussion_r1026744145
##########
nbpackage/src/main/resources/org/apache/netbeans/nbpackage/rpm/rpm.spec.template:
##########
@@ -0,0 +1,23 @@
+Name: ${RPM_PACKAGE}
+Version: ${RPM_VERSION}
+Release: 0
+Summary: ${RPM_SUMMARY}
+License: Apache License 2.0
+Group: Development/Tools/IDE
+URL: https://netbeans.apache.org/
Review Comment:
I have added the following options: url, group, vendor and license.
License, url and group default to "Unknown", and vendor to maintainer.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans-tools] neilcsmith-net commented on pull request #54: Implement RPM packaging
Posted by GitBox <gi...@apache.org>.
neilcsmith-net commented on PR #54:
URL: https://github.com/apache/netbeans-tools/pull/54#issuecomment-1327279210
Thanks for the feedback. Had to make a few changes to get builds working here, although am building on Ubuntu and testing in a Fedora VM! Can you take a quick look at #57 and make sure I haven't broken anything for your use?
> Some cleaning of unneeded files would be nice, such as netbeans.exe.
There are lots of wrong arch/OS files besides that one, though. I am planning a merge functionality for adding and removing files from the image though - I need that for my own NetBeans platform usage. If removal was based on glob patterns (like the code signing in macOS) that might help here.
> NBPackage could be also adapted to package other Java apps (ie: GlassFish); it would extract the zip, skip creating a launcher/copying icons, package all the bits and voilà. A bit out of scope?
Probably! Although I'm planning on basing something on this for packaging other software related to the above platform application. No point in duplicating JPackage or JReleaser though, neither of which were suitable for NetBeans but could be for other things.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans-tools] javierllorente commented on a diff in pull request #54: Implement RPM packaging
Posted by GitBox <gi...@apache.org>.
javierllorente commented on code in PR #54:
URL: https://github.com/apache/netbeans-tools/pull/54#discussion_r1017128016
##########
nbpackage/src/main/resources/org/apache/netbeans/nbpackage/rpm/rpm.spec.template:
##########
@@ -0,0 +1,23 @@
+Name: ${RPM_PACKAGE}
+Version: ${RPM_VERSION}
+Release: 0
+Summary: ${RPM_SUMMARY}
+License: Apache License 2.0
+Group: Development/Tools/IDE
+URL: https://netbeans.apache.org/
Review Comment:
I think that the required fields are the following ones:
- Name
- Version
- Release
- Summary
- License
The more information, the better :)
OK, license and URL as options.
The .desktop categories cannot be the same as the spec group;
Categories=Development;Java;IDE; vs Group: Development/Tools/IDE
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans-tools] neilcsmith-net commented on a diff in pull request #54: Implement RPM packaging
Posted by GitBox <gi...@apache.org>.
neilcsmith-net commented on code in PR #54:
URL: https://github.com/apache/netbeans-tools/pull/54#discussion_r1018120364
##########
nbpackage/src/main/resources/org/apache/netbeans/nbpackage/rpm/rpm.spec.template:
##########
@@ -0,0 +1,23 @@
+Name: ${RPM_PACKAGE}
+Version: ${RPM_VERSION}
+Release: 0
+Summary: ${RPM_SUMMARY}
+License: Apache License 2.0
+Group: Development/Tools/IDE
+URL: https://netbeans.apache.org/
+BuildArch: ${RPM_ARCH}
+Packager: ${RPM_MAINTAINER}
+Vendor: Apache NetBeans
+Requires: java >= 11
+Recommends: ${RPM_RECOMMENDS}
+AutoReqProv: no
+
+%description
+${RPM_DESCRIPTION}
+
+%files
+%{_bindir}/netbeans
Review Comment:
I understand why `%{name}` can't be used, but the binary launcher will not be called `netbeans` if packaging an rcp application. If you need the name of the launcher and it cannot just be `%{_bindir}/*`then pass in the value of `execName` into `setupSpecFile()` and use a token.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans-tools] javierllorente commented on a diff in pull request #54: Implement RPM packaging
Posted by GitBox <gi...@apache.org>.
javierllorente commented on code in PR #54:
URL: https://github.com/apache/netbeans-tools/pull/54#discussion_r1017128733
##########
nbpackage/src/main/resources/org/apache/netbeans/nbpackage/rpm/rpm.spec.template:
##########
@@ -0,0 +1,23 @@
+Name: ${RPM_PACKAGE}
+Version: ${RPM_VERSION}
+Release: 0
+Summary: ${RPM_SUMMARY}
+License: Apache License 2.0
+Group: Development/Tools/IDE
+URL: https://netbeans.apache.org/
+BuildArch: ${RPM_ARCH}
+Packager: ${RPM_MAINTAINER}
+Vendor: Apache NetBeans
+Requires: java >= 11
Review Comment:
Recommends instead of Requires as the user could already have a JDK (zip) instead of having the corresponding rpm installed?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans-tools] neilcsmith-net commented on a diff in pull request #54: Implement RPM packaging
Posted by GitBox <gi...@apache.org>.
neilcsmith-net commented on code in PR #54:
URL: https://github.com/apache/netbeans-tools/pull/54#discussion_r1018105874
##########
nbpackage/src/main/resources/org/apache/netbeans/nbpackage/rpm/rpm.spec.template:
##########
@@ -0,0 +1,23 @@
+Name: ${RPM_PACKAGE}
+Version: ${RPM_VERSION}
+Release: 0
+Summary: ${RPM_SUMMARY}
+License: Apache License 2.0
+Group: Development/Tools/IDE
+URL: https://netbeans.apache.org/
Review Comment:
> The more information, the better :)
In general, maybe. However, we need to provide options for any additional fields - eg. `${RPM_LICENSE}` if needed. Although that might be better as a global option as might be used elsewhere?
The DEB control file is just the minimum required to work well enough. User can always override the whole template. However, anything specific to NetBeans itself shouldn't be hardcoded. NBPackage is not intended just for packaging NetBeans itself.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans-tools] neilcsmith-net commented on a diff in pull request #54: Implement RPM packaging
Posted by GitBox <gi...@apache.org>.
neilcsmith-net commented on code in PR #54:
URL: https://github.com/apache/netbeans-tools/pull/54#discussion_r1018096424
##########
nbpackage/src/main/resources/org/apache/netbeans/nbpackage/rpm/rpm.spec.template:
##########
@@ -0,0 +1,23 @@
+Name: ${RPM_PACKAGE}
+Version: ${RPM_VERSION}
+Release: 0
Review Comment:
Why can no-one agree?! :laughing: OK, keep as is (pretty much solely based on the fact that SUSE was my first distro 20+ years ago and therefore is probably correct!)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans-tools] javierllorente commented on a diff in pull request #54: Implement RPM packaging
Posted by GitBox <gi...@apache.org>.
javierllorente commented on code in PR #54:
URL: https://github.com/apache/netbeans-tools/pull/54#discussion_r1026746574
##########
nbpackage/src/main/resources/org/apache/netbeans/nbpackage/rpm/rpm.spec.template:
##########
@@ -0,0 +1,23 @@
+Name: ${RPM_PACKAGE}
+Version: ${RPM_VERSION}
+Release: 0
+Summary: ${RPM_SUMMARY}
+License: Apache License 2.0
+Group: Development/Tools/IDE
+URL: https://netbeans.apache.org/
+BuildArch: ${RPM_ARCH}
+Packager: ${RPM_MAINTAINER}
+Vendor: Apache NetBeans
+Requires: java >= 11
Review Comment:
Understood. I have removed "Requires" and left "Recommends" (weak dependency); ` java-devel >= 11`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans-tools] javierllorente commented on a diff in pull request #54: Implement RPM packaging
Posted by GitBox <gi...@apache.org>.
javierllorente commented on code in PR #54:
URL: https://github.com/apache/netbeans-tools/pull/54#discussion_r1017126166
##########
nbpackage/src/main/resources/org/apache/netbeans/nbpackage/rpm/rpm.spec.template:
##########
@@ -0,0 +1,23 @@
+Name: ${RPM_PACKAGE}
+Version: ${RPM_VERSION}
+Release: 0
Review Comment:
It depends on whom you ask :)
openSUSE: 0
Fedora: 1
Do you want me to change it to 1?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans-tools] neilcsmith-net commented on a diff in pull request #54: Implement RPM packaging
Posted by GitBox <gi...@apache.org>.
neilcsmith-net commented on code in PR #54:
URL: https://github.com/apache/netbeans-tools/pull/54#discussion_r1018106960
##########
nbpackage/src/main/resources/org/apache/netbeans/nbpackage/rpm/rpm.spec.template:
##########
@@ -0,0 +1,23 @@
+Name: ${RPM_PACKAGE}
+Version: ${RPM_VERSION}
+Release: 0
+Summary: ${RPM_SUMMARY}
+License: Apache License 2.0
+Group: Development/Tools/IDE
+URL: https://netbeans.apache.org/
+BuildArch: ${RPM_ARCH}
+Packager: ${RPM_MAINTAINER}
+Vendor: Apache NetBeans
Review Comment:
As above, if we have that field it needs to be an option eg. `${RPM_VENDOR}`, or we leave it out.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans-tools] javierllorente commented on a diff in pull request #54: Implement RPM packaging
Posted by GitBox <gi...@apache.org>.
javierllorente commented on code in PR #54:
URL: https://github.com/apache/netbeans-tools/pull/54#discussion_r1026740952
##########
nbpackage/src/main/resources/org/apache/netbeans/nbpackage/rpm/rpm.spec.template:
##########
@@ -0,0 +1,23 @@
+Name: ${RPM_PACKAGE}
+Version: ${RPM_VERSION}
+Release: 0
Review Comment:
Sorry for the late reply. I have been on holidays (and without a laptop).
Indeed :laughing:
OK, let's leave it as it is; 0.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans-tools] neilcsmith-net merged pull request #54: Implement RPM packaging
Posted by GitBox <gi...@apache.org>.
neilcsmith-net merged PR #54:
URL: https://github.com/apache/netbeans-tools/pull/54
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists