[GitHub] [ignite-3] isapego commented on a change in pull request #749: IGNITE-16725 Thin client: Fix Netty buffer leaks

[GitBox <gi...@apache.org>]

isapego commented on a change in pull request #749:
URL: https://github.com/apache/ignite-3/pull/749#discussion_r834267975



##########
File path: modules/client/src/main/java/org/apache/ignite/internal/client/TcpClientChannel.java
##########
@@ -141,7 +146,12 @@ private void close(Exception cause) {
     /** {@inheritDoc} */
     @Override
     public void onMessage(ByteBuf buf) {
-        processNextMessage(buf);
+        try {
+            processNextMessage(buf);
+        } catch (Throwable t) {
+            buf.release();
+            throw t;
+        }

Review comment:
       `finally`?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org