You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by "Omnia Ibrahim (Jira)" <ji...@apache.org> on 2023/02/06 12:42:00 UTC

[jira] [Comment Edited] (KAFKA-14595) Move ReassignPartitionsCommand to tools

    [ https://issues.apache.org/jira/browse/KAFKA-14595?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17684635#comment-17684635 ] 

Omnia Ibrahim edited comment on KAFKA-14595 at 2/6/23 12:41 PM:
----------------------------------------------------------------

Hi [~nizhikov], just a note, I moved the methods `{{{}TestUtils.setReplicationThrottleForPartitions{}}}` and `{{{}TestUtils.removeReplicationThrottleForPartitions`  from `{}}}{{{}TestUtils` to `{}}}{{{}ToolsTestUtils{}}}{{{}` {}}}{{ as they are used only }} by `TopicCommand` and `ReassignPartitionCommand`.  To avoid the converting between Scala and Java collections. The changes are here [https://github.com/apache/kafka/pull/13201 |https://github.com/apache/kafka/pull/13201]


was (Author: omnia_h_ibrahim):
Hi [~nizhikov], just a note, I moved the methods `{{{}TestUtils.setReplicationThrottleForPartitions{}}}` and `{{{}TestUtils.removeReplicationThrottleForPartitions`  from `{}}}{{{}TestUtils` to `{}}}{{{}ToolsTestUtils{}}}{{{}` {}}}{{ as they are used only }} by `TopicCommand` and `ReassignPartitionCommand`.  To avoid the converting between Scala and Java collections. The changes are here https://github.com/apache/kafka/pull/13201{{{}{}}}

> Move ReassignPartitionsCommand to tools
> ---------------------------------------
>
>                 Key: KAFKA-14595
>                 URL: https://issues.apache.org/jira/browse/KAFKA-14595
>             Project: Kafka
>          Issue Type: Sub-task
>            Reporter: Mickael Maison
>            Assignee: Nikolay Izhikov
>            Priority: Major
>




--
This message was sent by Atlassian Jira
(v8.20.10#820010)