You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by wuciawe <gi...@git.apache.org> on 2017/10/25 06:58:31 UTC

[GitHub] spark issue #17190: [SPARK-19478][SS] JDBC Sink

Github user wuciawe commented on the issue:

    https://github.com/apache/spark/pull/17190
  
    @GaalDornick hi, I think
    
    ```
    def quote(colName: String): String = {
      s""""$colName""""
    }
    ```
    
    should be
    
    ```
    def quote(colName: String): String = {
      s"""`$colName`"""
    }
    ```
    (quoted in backticks instead of double quotes)?


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org