You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2022/05/15 04:56:59 UTC

[GitHub] [shardingsphere] linghengqian opened a new pull request, #17665: Update Mockito to 4.5.1 to help with GraalVM integration

linghengqian opened a new pull request, #17665:
URL: https://github.com/apache/shardingsphere/pull/17665

   Fixes #17451.
   
   Changes proposed in this pull request:
   - Update pom.xml.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] linghengqian commented on pull request #17665: Update Mockito and ByteBuddy to help with GraalVM integration

Posted by GitBox <gi...@apache.org>.

linghengqian commented on PR #17665:
URL: https://github.com/apache/shardingsphere/pull/17665#issuecomment-1126883812

   - The error in `org.apache.shardingsphere.agent.core.bytebuddy.transformer.advice.ComposeConstructorAdviceTest` confuses me, because my local test does not have `NPE`. Hope some friends can give me some hints.
   - ![image](https://user-images.githubusercontent.com/20187731/168463511-d3c85223-b940-4854-a911-b37570b48eb3.png)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] terrymanu commented on pull request #17665: Update Mockito and ByteBuddy to help with GraalVM integration

Posted by GitBox <gi...@apache.org>.

terrymanu commented on PR #17665:
URL: https://github.com/apache/shardingsphere/pull/17665#issuecomment-1127865459

   Good Job!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] linghengqian commented on pull request #17665: Update Mockito to 4.5.1 to help with GraalVM integration

Posted by GitBox <gi...@apache.org>.

linghengqian commented on PR #17665:
URL: https://github.com/apache/shardingsphere/pull/17665#issuecomment-1126871326

   - Is there any friend who can easily give some hints about `org.apache.shardingsphere.data.pipeline.api.datasource.config.impl.StandardPipelineDataSourceConfigurationTest` and `org.apache.shardingsphere.data.pipeline.api.datasource.config.impl.ShardingSpherePipelineDataSourceConfigurationTest` ? I am confused by the Error in CI/CD, because the unit test of my local corresponding class is normal.
   - ![image](https://user-images.githubusercontent.com/20187731/168460421-7d8d2d14-c12e-496a-af3a-224edcdfb33f.png)
   - ![image](https://user-images.githubusercontent.com/20187731/168460508-f49321e4-2276-4e8a-bc7a-4aa1f5392535.png)
   - ![image](https://user-images.githubusercontent.com/20187731/168460499-528d5a68-af44-411c-b682-933d9ed60821.png)
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] terrymanu merged pull request #17665: Update Mockito and ByteBuddy to help with GraalVM integration

Posted by GitBox <gi...@apache.org>.

terrymanu merged PR #17665:
URL: https://github.com/apache/shardingsphere/pull/17665


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] linghengqian commented on pull request #17665: Update Mockito and ByteBuddy to help with GraalVM integration

Posted by GitBox <gi...@apache.org>.

linghengqian commented on PR #17665:
URL: https://github.com/apache/shardingsphere/pull/17665#issuecomment-1126977604

   @Franco-H Hi friend, I noticed that `ComposeConstructorAdviceTest` was written by you, I wonder if it is possible for us to have unit tests in this place to avoid the use of `java.lang.Object`? A key change made after `Mockito` 3.5.0 makes mocking a `java.lang.*` object deprecated. Reference https://github.com/mockito/mockito/issues/2026 .


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] codecov-commenter commented on pull request #17665: Update Mockito and ByteBuddy to help with GraalVM integration

Posted by GitBox <gi...@apache.org>.

codecov-commenter commented on PR #17665:
URL: https://github.com/apache/shardingsphere/pull/17665#issuecomment-1127192782

   # [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/17665?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#17665](https://codecov.io/gh/apache/shardingsphere/pull/17665?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (7a12b68) into [master](https://codecov.io/gh/apache/shardingsphere/commit/90247fc21f6d23490f4e7d7725cedc0a0523ae10?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (90247fc) will **decrease** coverage by `0.02%`.
   > The diff coverage is `n/a`.
   
   ```diff
   @@             Coverage Diff              @@
   ##             master   #17665      +/-   ##
   ============================================
   - Coverage     58.81%   58.79%   -0.03%     
   - Complexity     2125     2126       +1     
   ============================================
     Files          3596     3599       +3     
     Lines         53536    53572      +36     
     Branches       9143     9144       +1     
   ============================================
   + Hits          31489    31497       +8     
   - Misses        19373    19400      +27     
   - Partials       2674     2675       +1     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/shardingsphere/pull/17665?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [...d/text/distsql/ral/common/hint/HintSourceType.java](https://codecov.io/gh/apache/shardingsphere/pull/17665/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtcHJveHkvc2hhcmRpbmdzcGhlcmUtcHJveHktYmFja2VuZC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvcHJveHkvYmFja2VuZC90ZXh0L2Rpc3RzcWwvcmFsL2NvbW1vbi9oaW50L0hpbnRTb3VyY2VUeXBlLmphdmE=) | `0.00% <0.00%> (-42.86%)` | :arrow_down: |
   | [...uery/ShowScalingCheckAlgorithmsQueryResultSet.java](https://codecov.io/gh/apache/shardingsphere/pull/17665/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtZmVhdHVyZXMvc2hhcmRpbmdzcGhlcmUtc2hhcmRpbmcvc2hhcmRpbmdzcGhlcmUtc2hhcmRpbmctZGlzdHNxbC9zaGFyZGluZ3NwaGVyZS1zaGFyZGluZy1kaXN0c3FsLWhhbmRsZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3NjYWxpbmcvZGlzdHNxbC9oYW5kbGVyL3F1ZXJ5L1Nob3dTY2FsaW5nQ2hlY2tBbGdvcml0aG1zUXVlcnlSZXN1bHRTZXQuamF2YQ==) | `77.77% <0.00%> (-8.89%)` | :arrow_down: |
   | [...ode/repository/standalone/file/FileRepository.java](https://codecov.io/gh/apache/shardingsphere/pull/17665/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtbW9kZS9zaGFyZGluZ3NwaGVyZS1tb2RlLXR5cGUvc2hhcmRpbmdzcGhlcmUtc3RhbmRhbG9uZS1tb2RlL3NoYXJkaW5nc3BoZXJlLXN0YW5kYWxvbmUtbW9kZS1yZXBvc2l0b3J5L3NoYXJkaW5nc3BoZXJlLXN0YW5kYWxvbmUtbW9kZS1yZXBvc2l0b3J5LXByb3ZpZGVyL3NoYXJkaW5nc3BoZXJlLXN0YW5kYWxvbmUtbW9kZS1yZXBvc2l0b3J5LWZpbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL21vZGUvcmVwb3NpdG9yeS9zdGFuZGFsb25lL2ZpbGUvRmlsZVJlcG9zaXRvcnkuamF2YQ==) | `58.53% <0.00%> (-0.99%)` | :arrow_down: |
   | [...ardingsphere/infra/properties/TypedProperties.java](https://codecov.io/gh/apache/shardingsphere/pull/17665/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtaW5mcmEvc2hhcmRpbmdzcGhlcmUtaW5mcmEtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9pbmZyYS9wcm9wZXJ0aWVzL1R5cGVkUHJvcGVydGllcy5qYXZh) | `94.44% <0.00%> (ø)` | |
   | [...ngsphere/infra/properties/PropertiesConverter.java](https://codecov.io/gh/apache/shardingsphere/pull/17665/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtaW5mcmEvc2hhcmRpbmdzcGhlcmUtaW5mcmEtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9pbmZyYS9wcm9wZXJ0aWVzL1Byb3BlcnRpZXNDb252ZXJ0ZXIuamF2YQ==) | `100.00% <0.00%> (ø)` | |
   | [...de/metadata/persist/node/DatabaseMetaDataNode.java](https://codecov.io/gh/apache/shardingsphere/pull/17665/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtbW9kZS9zaGFyZGluZ3NwaGVyZS1tb2RlLWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL21vZGUvbWV0YWRhdGEvcGVyc2lzdC9ub2RlL0RhdGFiYXNlTWV0YURhdGFOb2RlLmphdmE=) | `71.87% <0.00%> (ø)` | |
   | [...a/database/type/dialect/OpenGaussDatabaseType.java](https://codecov.io/gh/apache/shardingsphere/pull/17665/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtaW5mcmEvc2hhcmRpbmdzcGhlcmUtaW5mcmEtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9pbmZyYS9kYXRhYmFzZS90eXBlL2RpYWxlY3QvT3BlbkdhdXNzRGF0YWJhc2VUeXBlLmphdmE=) | `41.17% <0.00%> (ø)` | |
   | [.../database/type/dialect/PostgreSQLDatabaseType.java](https://codecov.io/gh/apache/shardingsphere/pull/17665/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtaW5mcmEvc2hhcmRpbmdzcGhlcmUtaW5mcmEtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9pbmZyYS9kYXRhYmFzZS90eXBlL2RpYWxlY3QvUG9zdGdyZVNRTERhdGFiYXNlVHlwZS5qYXZh) | `64.70% <0.00%> (ø)` | |
   | [...tadata/schema/builder/SystemSchemaBuilderRule.java](https://codecov.io/gh/apache/shardingsphere/pull/17665/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtaW5mcmEvc2hhcmRpbmdzcGhlcmUtaW5mcmEtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9pbmZyYS9tZXRhZGF0YS9zY2hlbWEvYnVpbGRlci9TeXN0ZW1TY2hlbWFCdWlsZGVyUnVsZS5qYXZh) | `96.87% <0.00%> (ø)` | |
   | [...distsql/rdl/rule/RuleDefinitionBackendHandler.java](https://codecov.io/gh/apache/shardingsphere/pull/17665/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtcHJveHkvc2hhcmRpbmdzcGhlcmUtcHJveHktYmFja2VuZC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvcHJveHkvYmFja2VuZC90ZXh0L2Rpc3RzcWwvcmRsL3J1bGUvUnVsZURlZmluaXRpb25CYWNrZW5kSGFuZGxlci5qYXZh) | `50.00% <0.00%> (ø)` | |
   | ... and [28 more](https://codecov.io/gh/apache/shardingsphere/pull/17665/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/shardingsphere/pull/17665?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/17665?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [90247fc...7a12b68](https://codecov.io/gh/apache/shardingsphere/pull/17665?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org