You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by David Grizzanti <da...@sungard.com> on 2013/11/01 16:52:27 UTC
Review Request 15181: CLOUSTACK-5023: Deleting Port Forwarding Rule fails
when generating usage events are enabled
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15181/
-----------------------------------------------------------
Review request for cloudstack.
Bugs: CLOUDSTACK-5023
https://issues.apache.org/jira/browse/CLOUDSTACK-5023
Repository: cloudstack-git
Description
-------
CLOUDSTACK-5023: Deleting Port Forwarding Rule fails when generating usage events are enabled
Added logic so that a correct zoneID is passed when generating usage events while deleting port forwarding rules:
- Added logic to server/src/com/cloud/network/firewall/FirewallManagerImpl.java to grab zone id and pass to publishUsageEvent
Diffs
-----
server/src/com/cloud/network/firewall/FirewallManagerImpl.java d250a08
Diff: https://reviews.apache.org/r/15181/diff/
Testing
-------
Tested on 4.2.0 tag
Thanks,
David Grizzanti
Re: Review Request 15181: CLOUSTACK-5023: Deleting Port Forwarding Rule
fails when generating usage events are enabled
Posted by David Grizzanti <da...@sungard.com>.
> On Nov. 3, 2013, 7:45 p.m., daan Hoogland wrote:
> > can you test and submit for master as well?
> >
> > d6420cd91ebb493e8b9d4220e95b7a3250272db3
>
> David Grizzanti wrote:
> do you want me to submit a separate review for the master fix?
master seems a bit different in terms of the simulator and the usage event configuration (Spring configurations were moved around). I'll close this review and open a new one once I have the master patch working. Will keep the Jira open though and update with a comment.
Thanks!
- David
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15181/#review28081
-----------------------------------------------------------
On Nov. 1, 2013, 3:52 p.m., David Grizzanti wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/15181/
> -----------------------------------------------------------
>
> (Updated Nov. 1, 2013, 3:52 p.m.)
>
>
> Review request for cloudstack.
>
>
> Bugs: CLOUDSTACK-5023
> https://issues.apache.org/jira/browse/CLOUDSTACK-5023
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> CLOUDSTACK-5023: Deleting Port Forwarding Rule fails when generating usage events are enabled
>
> Added logic so that a correct zoneID is passed when generating usage events while deleting port forwarding rules:
> - Added logic to server/src/com/cloud/network/firewall/FirewallManagerImpl.java to grab zone id and pass to publishUsageEvent
>
>
> Diffs
> -----
>
> server/src/com/cloud/network/firewall/FirewallManagerImpl.java d250a08
>
> Diff: https://reviews.apache.org/r/15181/diff/
>
>
> Testing
> -------
>
> Tested on 4.2.0 tag
>
>
> Thanks,
>
> David Grizzanti
>
>
Re: Review Request 15181: CLOUSTACK-5023: Deleting Port Forwarding Rule
fails when generating usage events are enabled
Posted by David Grizzanti <da...@sungard.com>.
> On Nov. 3, 2013, 7:45 p.m., daan Hoogland wrote:
> > can you test and submit for master as well?
> >
> > d6420cd91ebb493e8b9d4220e95b7a3250272db3
do you want me to submit a separate review for the master fix?
- David
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15181/#review28081
-----------------------------------------------------------
On Nov. 1, 2013, 3:52 p.m., David Grizzanti wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/15181/
> -----------------------------------------------------------
>
> (Updated Nov. 1, 2013, 3:52 p.m.)
>
>
> Review request for cloudstack.
>
>
> Bugs: CLOUDSTACK-5023
> https://issues.apache.org/jira/browse/CLOUDSTACK-5023
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> CLOUDSTACK-5023: Deleting Port Forwarding Rule fails when generating usage events are enabled
>
> Added logic so that a correct zoneID is passed when generating usage events while deleting port forwarding rules:
> - Added logic to server/src/com/cloud/network/firewall/FirewallManagerImpl.java to grab zone id and pass to publishUsageEvent
>
>
> Diffs
> -----
>
> server/src/com/cloud/network/firewall/FirewallManagerImpl.java d250a08
>
> Diff: https://reviews.apache.org/r/15181/diff/
>
>
> Testing
> -------
>
> Tested on 4.2.0 tag
>
>
> Thanks,
>
> David Grizzanti
>
>
Re: Review Request 15181: CLOUSTACK-5023: Deleting Port Forwarding Rule
fails when generating usage events are enabled
Posted by daan Hoogland <da...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15181/#review28081
-----------------------------------------------------------
Ship it!
can you test and submit for master as well?
d6420cd91ebb493e8b9d4220e95b7a3250272db3
- daan Hoogland
On Nov. 1, 2013, 3:52 p.m., David Grizzanti wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/15181/
> -----------------------------------------------------------
>
> (Updated Nov. 1, 2013, 3:52 p.m.)
>
>
> Review request for cloudstack.
>
>
> Bugs: CLOUDSTACK-5023
> https://issues.apache.org/jira/browse/CLOUDSTACK-5023
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> CLOUDSTACK-5023: Deleting Port Forwarding Rule fails when generating usage events are enabled
>
> Added logic so that a correct zoneID is passed when generating usage events while deleting port forwarding rules:
> - Added logic to server/src/com/cloud/network/firewall/FirewallManagerImpl.java to grab zone id and pass to publishUsageEvent
>
>
> Diffs
> -----
>
> server/src/com/cloud/network/firewall/FirewallManagerImpl.java d250a08
>
> Diff: https://reviews.apache.org/r/15181/diff/
>
>
> Testing
> -------
>
> Tested on 4.2.0 tag
>
>
> Thanks,
>
> David Grizzanti
>
>