You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ranger.apache.org by Nikhil P <np...@gmail.com> on 2019/06/19 13:21:42 UTC
Re: Review Request 70821: Improvement in setting cluster Name in
RangerAccessRequest
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70821/
-----------------------------------------------------------
(Updated June 19, 2019, 6:51 p.m.)
Review request for ranger, Abhay Kulkarni and Madhan Neethiraj.
Changes
-------
Required changes found during internal testing
Bugs: RANGER-2466
https://issues.apache.org/jira/browse/RANGER-2466
Repository: ranger
Description
-------
handling Clustername setting part during Policy engine instantiation.
instead of requiring each plugin implementation to do clusterName setting , it is handled by passing RangerPluginContext (a new class) to policyEngine during instantiation.
This patch contains change for clusterName setting part, new policy condition i.e clusterType change will be handled in https://issues.apache.org/jira/browse/RANGER-2467
Diffs (updated)
-----
agents-common/src/main/java/org/apache/ranger/plugin/policyengine/RangerAccessRequestImpl.java fd4122269
agents-common/src/main/java/org/apache/ranger/plugin/policyengine/RangerPluginContext.java PRE-CREATION
agents-common/src/main/java/org/apache/ranger/plugin/policyengine/RangerPolicyEngineCache.java 4a41e6292
agents-common/src/main/java/org/apache/ranger/plugin/policyengine/RangerPolicyEngineImpl.java e0043ff8f
agents-common/src/main/java/org/apache/ranger/plugin/service/RangerAuthContext.java e854e052f
agents-common/src/main/java/org/apache/ranger/plugin/service/RangerBasePlugin.java ddf181c16
agents-common/src/test/java/org/apache/ranger/plugin/policyengine/TestPolicyACLs.java 1abd209d3
agents-common/src/test/java/org/apache/ranger/plugin/policyengine/TestPolicyDb.java 85ea679be
agents-common/src/test/java/org/apache/ranger/plugin/policyengine/TestPolicyEngine.java c3b31bbd0
hbase-agent/src/main/java/org/apache/ranger/authorization/hbase/AuthorizationSession.java d51f0fb83
hbase-agent/src/main/java/org/apache/ranger/authorization/hbase/RangerAuthorizationCoprocessor.java 449d77d7f
hbase-agent/src/test/java/org/apache/ranger/authorization/hbase/TestPolicyEngine.java 6efe2e3ff
hdfs-agent/src/main/java/org/apache/ranger/authorization/hadoop/RangerHdfsAuthorizer.java f204c15c0
hive-agent/src/main/java/org/apache/ranger/authorization/hive/authorizer/RangerHiveAccessRequest.java df379c306
hive-agent/src/main/java/org/apache/ranger/authorization/hive/authorizer/RangerHiveAuthorizer.java 625b7bb0e
knox-agent/src/main/java/org/apache/ranger/authorization/knox/KnoxRangerPlugin.java 814aedd20
knox-agent/src/main/java/org/apache/ranger/authorization/knox/RangerPDPKnoxFilter.java e75f314d5
plugin-atlas/src/main/java/org/apache/ranger/authorization/atlas/authorizer/RangerAtlasAuthorizer.java b52a22ed2
plugin-elasticsearch/src/main/java/org/apache/ranger/authorization/elasticsearch/authorizer/RangerElasticsearchAuthorizer.java a6b024ff0
plugin-kafka/src/main/java/org/apache/ranger/authorization/kafka/authorizer/RangerKafkaAuthorizer.java 8a661d8f2
plugin-kms/src/main/java/org/apache/ranger/authorization/kms/authorizer/RangerKmsAuthorizer.java 07921a99a
plugin-kylin/src/main/java/org/apache/ranger/authorization/kylin/authorizer/RangerKylinAuthorizer.java a745b87ff
plugin-solr/src/main/java/org/apache/ranger/authorization/solr/authorizer/RangerSolrAuthorizer.java 6c0201d3e
plugin-sqoop/src/main/java/org/apache/ranger/authorization/sqoop/authorizer/RangerSqoopAuthorizer.java 17a7a6314
plugin-yarn/src/main/java/org/apache/ranger/authorization/yarn/authorizer/RangerYarnAuthorizer.java 54f230c3c
ranger-tools/src/main/java/org/apache/ranger/policyengine/PerfTestEngine.java 590c1e7db
ranger-tools/src/test/java/org/apache/ranger/policyengine/RangerPolicyEnginePerformanceTest.java 7a39396d5
storm-agent/src/main/java/org/apache/ranger/authorization/storm/StormRangerPlugin.java 88ea05e9d
storm-agent/src/main/java/org/apache/ranger/authorization/storm/authorizer/RangerStormAuthorizer.java 0fe658e24
Diff: https://reviews.apache.org/r/70821/diff/5/
Changes: https://reviews.apache.org/r/70821/diff/4-5/
Testing
-------
1.Tested for hive plugin, whether clusterName is getting set properly in RangerAccessRequest.
Thanks,
Nikhil P
Re: Review Request 70821: Improvement in setting cluster Name in
RangerAccessRequest
Posted by Mehul Parikh <me...@freestoneinfotech.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70821/#review216085
-----------------------------------------------------------
Ship it!
Ship It!
- Mehul Parikh
On June 19, 2019, 1:21 p.m., Nikhil P wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70821/
> -----------------------------------------------------------
>
> (Updated June 19, 2019, 1:21 p.m.)
>
>
> Review request for ranger, Abhay Kulkarni and Madhan Neethiraj.
>
>
> Bugs: RANGER-2466
> https://issues.apache.org/jira/browse/RANGER-2466
>
>
> Repository: ranger
>
>
> Description
> -------
>
> handling Clustername setting part during Policy engine instantiation.
>
> instead of requiring each plugin implementation to do clusterName setting , it is handled by passing RangerPluginContext (a new class) to policyEngine during instantiation.
>
> This patch contains change for clusterName setting part, new policy condition i.e clusterType change will be handled in https://issues.apache.org/jira/browse/RANGER-2467
>
>
> Diffs
> -----
>
> agents-common/src/main/java/org/apache/ranger/plugin/policyengine/RangerAccessRequestImpl.java fd4122269
> agents-common/src/main/java/org/apache/ranger/plugin/policyengine/RangerPluginContext.java PRE-CREATION
> agents-common/src/main/java/org/apache/ranger/plugin/policyengine/RangerPolicyEngineCache.java 4a41e6292
> agents-common/src/main/java/org/apache/ranger/plugin/policyengine/RangerPolicyEngineImpl.java e0043ff8f
> agents-common/src/main/java/org/apache/ranger/plugin/service/RangerAuthContext.java e854e052f
> agents-common/src/main/java/org/apache/ranger/plugin/service/RangerBasePlugin.java ddf181c16
> agents-common/src/test/java/org/apache/ranger/plugin/policyengine/TestPolicyACLs.java 1abd209d3
> agents-common/src/test/java/org/apache/ranger/plugin/policyengine/TestPolicyDb.java 85ea679be
> agents-common/src/test/java/org/apache/ranger/plugin/policyengine/TestPolicyEngine.java c3b31bbd0
> hbase-agent/src/main/java/org/apache/ranger/authorization/hbase/AuthorizationSession.java d51f0fb83
> hbase-agent/src/main/java/org/apache/ranger/authorization/hbase/RangerAuthorizationCoprocessor.java 449d77d7f
> hbase-agent/src/test/java/org/apache/ranger/authorization/hbase/TestPolicyEngine.java 6efe2e3ff
> hdfs-agent/src/main/java/org/apache/ranger/authorization/hadoop/RangerHdfsAuthorizer.java f204c15c0
> hive-agent/src/main/java/org/apache/ranger/authorization/hive/authorizer/RangerHiveAccessRequest.java df379c306
> hive-agent/src/main/java/org/apache/ranger/authorization/hive/authorizer/RangerHiveAuthorizer.java 625b7bb0e
> knox-agent/src/main/java/org/apache/ranger/authorization/knox/KnoxRangerPlugin.java 814aedd20
> knox-agent/src/main/java/org/apache/ranger/authorization/knox/RangerPDPKnoxFilter.java e75f314d5
> plugin-atlas/src/main/java/org/apache/ranger/authorization/atlas/authorizer/RangerAtlasAuthorizer.java b52a22ed2
> plugin-elasticsearch/src/main/java/org/apache/ranger/authorization/elasticsearch/authorizer/RangerElasticsearchAuthorizer.java a6b024ff0
> plugin-kafka/src/main/java/org/apache/ranger/authorization/kafka/authorizer/RangerKafkaAuthorizer.java 8a661d8f2
> plugin-kms/src/main/java/org/apache/ranger/authorization/kms/authorizer/RangerKmsAuthorizer.java 07921a99a
> plugin-kylin/src/main/java/org/apache/ranger/authorization/kylin/authorizer/RangerKylinAuthorizer.java a745b87ff
> plugin-solr/src/main/java/org/apache/ranger/authorization/solr/authorizer/RangerSolrAuthorizer.java 6c0201d3e
> plugin-sqoop/src/main/java/org/apache/ranger/authorization/sqoop/authorizer/RangerSqoopAuthorizer.java 17a7a6314
> plugin-yarn/src/main/java/org/apache/ranger/authorization/yarn/authorizer/RangerYarnAuthorizer.java 54f230c3c
> ranger-tools/src/main/java/org/apache/ranger/policyengine/PerfTestEngine.java 590c1e7db
> ranger-tools/src/test/java/org/apache/ranger/policyengine/RangerPolicyEnginePerformanceTest.java 7a39396d5
> storm-agent/src/main/java/org/apache/ranger/authorization/storm/StormRangerPlugin.java 88ea05e9d
> storm-agent/src/main/java/org/apache/ranger/authorization/storm/authorizer/RangerStormAuthorizer.java 0fe658e24
>
>
> Diff: https://reviews.apache.org/r/70821/diff/5/
>
>
> Testing
> -------
>
> 1.Tested for hive plugin, whether clusterName is getting set properly in RangerAccessRequest.
>
>
> Thanks,
>
> Nikhil P
>
>