You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by GitBox <gi...@apache.org> on 2022/08/29 18:53:24 UTC
[GitHub] [cloudstack] BryanMLima opened a new pull request, #6684: Add message upon network offering creation to warn user of VR creation
BryanMLima opened a new pull request, #6684:
URL: https://github.com/apache/cloudstack/pull/6684
### Description
This PR aims to improve the user experience upon creation of Network Offerings warning the user of the scenarios in which a VR is created. For this, the service offering field is always shown in the form and a warning message is displayed if the user's configuration does not require the creation of a VR. These scenarios include a network offering with guest type L2, and a with a guest type Shared or Isolated when none of the following services are enabled: (VPN, DHCP, DNS, Firewall, LB, UserData, SourceNat, StaticNat and/or PortForwarding). Finally, the message for the Isolated and Shared networks disappear when one of the aforementioned services are selected.
### Types of changes
- [ ] Breaking change (fix or feature that would cause existing functionality to change)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Bug fix (non-breaking change which fixes an issue)
- [x] Enhancement (improves an existing feature and functionality)
- [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
### Feature/Enhancement Scale or Bug Severity
#### Feature/Enhancement Scale
- [ ] Major
- [x] Minor
#### Bug Severity
- [ ] BLOCKER
- [ ] Critical
- [ ] Major
- [ ] Minor
- [ ] Trivial
### Screenshots (if appropriate):
Message if the guest type is **Isolated or Shared**:
Message if the guest type is **L2**:
### How Has This Been Tested?
This was tested in a local lab using the networking offering form. The message for Shared/Isolated type was only displayed if the none of the following services (VPN, DHCP, DNS, Firewall, LB, UserData, SourceNat, StaticNat and/or PortForwarding) were not selected.
For the L2 message, it was always displayed, unless the guest type was changed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] codecov[bot] commented on pull request #6684: Add message upon network offering creation to warn user of VR creation
Posted by GitBox <gi...@apache.org>.
codecov[bot] commented on PR #6684:
URL: https://github.com/apache/cloudstack/pull/6684#issuecomment-1230785336
# [Codecov](https://codecov.io/gh/apache/cloudstack/pull/6684?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#6684](https://codecov.io/gh/apache/cloudstack/pull/6684?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (02092d8) into [main](https://codecov.io/gh/apache/cloudstack/commit/9f7e0cc2d57585168e9571393f9fa4113344b89f?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (9f7e0cc) will **decrease** coverage by `0.00%`.
> The diff coverage is `n/a`.
```diff
@@ Coverage Diff @@
## main #6684 +/- ##
============================================
- Coverage 5.87% 5.87% -0.01%
+ Complexity 3936 3934 -2
============================================
Files 2454 2454
Lines 242683 242683
Branches 37978 37978
============================================
- Hits 14265 14261 -4
- Misses 226839 226843 +4
Partials 1579 1579
```
| [Impacted Files](https://codecov.io/gh/apache/cloudstack/pull/6684?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...apache/cloudstack/syslog/AlertsSyslogAppender.java](https://codecov.io/gh/apache/cloudstack/pull/6684/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGx1Z2lucy9hbGVydC1oYW5kbGVycy9zeXNsb2ctYWxlcnRzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9jbG91ZHN0YWNrL3N5c2xvZy9BbGVydHNTeXNsb2dBcHBlbmRlci5qYXZh) | `56.49% <0.00%> (-2.26%)` | :arrow_down: |
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] acs-robot commented on pull request #6684: Add message upon network offering creation to warn user of VR creation
Posted by GitBox <gi...@apache.org>.
acs-robot commented on PR #6684:
URL: https://github.com/apache/cloudstack/pull/6684#issuecomment-1230723480
Found UI changes, kicking a new UI QA build
@blueorangutan ui
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6684: Add message upon network offering creation to warn user of VR creation
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6684:
URL: https://github.com/apache/cloudstack/pull/6684#issuecomment-1272243616
@rohityadavcloud a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rohityadavcloud merged pull request #6684: Add message upon network offering creation to warn user of VR creation
Posted by GitBox <gi...@apache.org>.
rohityadavcloud merged PR #6684:
URL: https://github.com/apache/cloudstack/pull/6684
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6684: Add message upon network offering creation to warn user of VR creation
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6684:
URL: https://github.com/apache/cloudstack/pull/6684#issuecomment-1230724102
@acs-robot a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6684: Add message upon network offering creation to warn user of VR creation
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6684:
URL: https://github.com/apache/cloudstack/pull/6684#issuecomment-1230729471
UI build: :heavy_check_mark:
Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/6684 (SL-JID-2246)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rohityadavcloud commented on pull request #6684: Add message upon network offering creation to warn user of VR creation
Posted by GitBox <gi...@apache.org>.
rohityadavcloud commented on PR #6684:
URL: https://github.com/apache/cloudstack/pull/6684#issuecomment-1272243498
@blueorangutan ui
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on pull request #6684: Add message upon network offering creation to warn user of VR creation
Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on PR #6684:
URL: https://github.com/apache/cloudstack/pull/6684#issuecomment-1231903910
code looks good
I cannot login to the qa server to test this.
```
Error
Exception caught while discovering features.
```
cc @rohityadavcloud @davidjumani
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6684: Add message upon network offering creation to warn user of VR creation
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6684:
URL: https://github.com/apache/cloudstack/pull/6684#issuecomment-1272247860
UI build: :heavy_check_mark:
Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/6684 (SL-JID-2474)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org