You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2020/03/08 00:23:55 UTC
[GitHub] [incubator-superset] mistercrunch opened a new pull request #9256:
fix: tab ordering in TableEditor
mistercrunch opened a new pull request #9256: fix: tab ordering in TableEditor
URL: https://github.com/apache/incubator-superset/pull/9256
Unclear when this got changed, but this seems like a more natural ordering for the tabs in the table editor.
<img width="945" alt="Screen Shot 2020-03-07 at 4 21 49 PM" src="https://user-images.githubusercontent.com/487433/76154367-f679f900-608f-11ea-812f-2dc0dd3702fc.png">
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] mistercrunch commented on issue #9256: fix:
tab ordering in TableEditor
Posted by GitBox <gi...@apache.org>.
mistercrunch commented on issue #9256: fix: tab ordering in TableEditor
URL: https://github.com/apache/incubator-superset/pull/9256#issuecomment-596638425
It seems to me like the `<Alert/>` belongs above the tab bar, to put the alert in the settings tab that's now buried seems bad
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] stale[bot] commented on pull request #9256: fix: tab ordering in TableEditor
Posted by GitBox <gi...@apache.org>.
stale[bot] commented on pull request #9256:
URL: https://github.com/apache/incubator-superset/pull/9256#issuecomment-626084873
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. For admin, please label this issue `.pinned` to prevent stale bot from closing the issue.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] stale[bot] closed pull request #9256: fix: tab ordering in TableEditor
Posted by GitBox <gi...@apache.org>.
stale[bot] closed pull request #9256:
URL: https://github.com/apache/incubator-superset/pull/9256
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org