You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2021/03/01 01:52:17 UTC
[GitHub] [apisix] spacewander opened a new pull request #3703: feat: add labels to plugin_config
spacewander opened a new pull request #3703:
URL: https://github.com/apache/apisix/pull/3703
Also fix the schema validation.
Signed-off-by: spacewander <sp...@gmail.com>
### What this PR does / why we need it:
<!--- Why is this change required? What problem does it solve? -->
<!--- If it fixes an open issue, please link to the issue here. -->
### Pre-submission checklist:
* [x] Did you explain what problem does this PR solve? Or what new features have been added?
* [x] Have you added corresponding test cases?
* [x] Have you modified the corresponding document?
* [ ] Is this PR backward compatible? **If it is not backward compatible, please discuss on the [mailing list](https://github.com/apache/apisix/tree/master#community) first**
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] nic-chen commented on pull request #3703: feat: add labels to plugin_config
Posted by GitBox <gi...@apache.org>.
nic-chen commented on pull request #3703:
URL: https://github.com/apache/apisix/pull/3703#issuecomment-787611156
> > Will it support to match route and plugin_config through labels in the future?
>
> No. It is hard to implement and slow to run, and it is not obvious for the users.
OK
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] spacewander merged pull request #3703: feat: add labels to plugin_config
Posted by GitBox <gi...@apache.org>.
spacewander merged pull request #3703:
URL: https://github.com/apache/apisix/pull/3703
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] gxthrj commented on pull request #3703: feat: add labels to plugin_config
Posted by GitBox <gi...@apache.org>.
gxthrj commented on pull request #3703:
URL: https://github.com/apache/apisix/pull/3703#issuecomment-787616706
I created a [discuss](https://github.com/apache/apisix/issues/3704) about using label instead of ID, and I think we can support label match between objects in future :)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] nic-chen commented on pull request #3703: feat: add labels to plugin_config
Posted by GitBox <gi...@apache.org>.
nic-chen commented on pull request #3703:
URL: https://github.com/apache/apisix/pull/3703#issuecomment-787605650
It seems that this pr supports the definition of labels for `plugin_config`.
Will it support to match `route` and `plugin_config` through labels in the future?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] spacewander commented on pull request #3703: feat: add labels to plugin_config
Posted by GitBox <gi...@apache.org>.
spacewander commented on pull request #3703:
URL: https://github.com/apache/apisix/pull/3703#issuecomment-787608458
> Will it support to match route and plugin_config through labels in the future?
No. It is hard to implement and slow to run, and it is not obvious for the users.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org