You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@couchdb.apache.org by benkeen <gi...@git.apache.org> on 2015/12/14 19:54:55 UTC
[GitHub] couchdb-fauxton pull request: Move all React modals to use ReactBo...
GitHub user benkeen opened a pull request:
https://github.com/apache/couchdb-fauxton/pull/592
Move all React modals to use ReactBootstrap.Modal
Benefits are less custom code and all modals standardized by
default, so behaviour like clicking outside the modal or clicking
escape will close it. These are configurable, but the “out the
box” modals will be all the same.
Affects:
- Confirmation modal (e.g. full page doc editor, “are you sure you want to delete this doc?”)
- Upload file modal
- String Edit modal
- Clone Doc modal
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/benkeen/couchdb-fauxton move-modals-to-react-bootstrap
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/couchdb-fauxton/pull/592.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #592
----
commit ffdfdf45f5d92f0fc832b602969e5c3dad132813
Author: Ben Keen <be...@gmail.com>
Date: 2015-12-14T18:39:09Z
Move all React modals to use ReactBootstrap.Modal
Benefits are less custom code and all modals standardized by
default, so behaviour like clicking outside the modal or clicking
escape will close it. These are configurable, but the “out the
box” modals will be all the same.
Affects:
- Confirmation modal (e.g. full page doc editor, “are you sure you want to delete this doc?”)
- Upload file modal
- String Edit modal
- Clone Doc modal
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton pull request: Move all React modals to use ReactBo...
Posted by robertkowalski <gi...@git.apache.org>.
Github user robertkowalski commented on the pull request:
https://github.com/apache/couchdb-fauxton/pull/592#issuecomment-168763093
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton pull request: Move all React modals to use ReactBo...
Posted by benkeen <gi...@git.apache.org>.
Github user benkeen closed the pull request at:
https://github.com/apache/couchdb-fauxton/pull/592
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton pull request: Move all React modals to use ReactBo...
Posted by benkeen <gi...@git.apache.org>.
Github user benkeen commented on the pull request:
https://github.com/apache/couchdb-fauxton/pull/592#issuecomment-169059782
Merged as efc2a1e
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton pull request: Move all React modals to use ReactBo...
Posted by benkeen <gi...@git.apache.org>.
Github user benkeen commented on the pull request:
https://github.com/apache/couchdb-fauxton/pull/592#issuecomment-168778324
Will merge after rebasing.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---