You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@subversion.apache.org by Blair Zajac <bl...@orcaware.com> on 2010/11/09 16:52:43 UTC
Re: svn commit: r982355 - /subversion/branches/performance/subversion/svnserve/main.c
On Aug 4, 2010, at 11:43 AM, stefan2@apache.org wrote:
> Author: stefan2
> Date: Wed Aug 4 18:43:29 2010
> New Revision: 982355
>
> URL: http://svn.apache.org/viewvc?rev=982355&view=rev
> Log:
> Fix an issue with fulltext caching already present in production SVN:
> APR pools often won't reuse memory fragments if they are larger
> than 80kB. Using string buffers while reconstructing fulltexts does
> exactly The Bad Thing: request large buffers of various sizes that
> APR pools will often not reuse due to their differing and often just
> a tad bit too small size.
> @@ -859,10 +860,22 @@ int main(int argc, const char *argv[])
> return ERROR_SUCCESS;
> #endif
>
> + /* If we are using fulltext caches etc., we will allocate many large
> + chunks of memory of various sizes outside the cachde for those
s/cachde/cache/
Blair
Re: svn commit: r982355 - /subversion/branches/performance/subversion/svnserve/main.c
Posted by Blair Zajac <bl...@orcaware.com>.
On Nov 9, 2010, at 3:38 PM, Stefan Fuhrmann wrote:
> On 09.11.2010 17:52, Blair Zajac wrote:
>> On Aug 4, 2010, at 11:43 AM, stefan2@apache.org wrote:
>>
>>> Author: stefan2
>>> Date: Wed Aug 4 18:43:29 2010
>>> New Revision: 982355
>>>
>>> URL: http://svn.apache.org/viewvc?rev=982355&view=rev
>>> Log:
>>> Fix an issue with fulltext caching already present in production SVN:
>>> APR pools often won't reuse memory fragments if they are larger
>>> than 80kB. Using string buffers while reconstructing fulltexts does
>>> exactly The Bad Thing: request large buffers of various sizes that
>>> APR pools will often not reuse due to their differing and often just
>>> a tad bit too small size.
>>> @@ -859,10 +860,22 @@ int main(int argc, const char *argv[])
>>> return ERROR_SUCCESS;
>>> #endif
>>>
>>> + /* If we are using fulltext caches etc., we will allocate many large
>>> + chunks of memory of various sizes outside the cachde for those
>> s/cachde/cache/
>>
>> Blair
> Thanks. Committed as r1033294.
Great!
Re: svn commit: r982355 - /subversion/branches/performance/subversion/svnserve/main.c
Posted by Stefan Fuhrmann <st...@alice-dsl.de>.
On 09.11.2010 17:52, Blair Zajac wrote:
> On Aug 4, 2010, at 11:43 AM, stefan2@apache.org wrote:
>
>> Author: stefan2
>> Date: Wed Aug 4 18:43:29 2010
>> New Revision: 982355
>>
>> URL: http://svn.apache.org/viewvc?rev=982355&view=rev
>> Log:
>> Fix an issue with fulltext caching already present in production SVN:
>> APR pools often won't reuse memory fragments if they are larger
>> than 80kB. Using string buffers while reconstructing fulltexts does
>> exactly The Bad Thing: request large buffers of various sizes that
>> APR pools will often not reuse due to their differing and often just
>> a tad bit too small size.
>> @@ -859,10 +860,22 @@ int main(int argc, const char *argv[])
>> return ERROR_SUCCESS;
>> #endif
>>
>> + /* If we are using fulltext caches etc., we will allocate many large
>> + chunks of memory of various sizes outside the cachde for those
> s/cachde/cache/
>
> Blair
Thanks. Committed as r1033294.
-- Stefan^2.