You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@datafusion.apache.org by "kosiew (via GitHub)" <gi...@apache.org> on 2026/06/24 09:51:03 UTC

[PR] Add regression coverage for quoted dotted column aliases [datafusion]

kosiew opened a new pull request, #23155:
URL: https://github.com/apache/datafusion/pull/23155

   ## Which issue does this PR close?
   
   Follow up to #22917
   - Add SLT regression coverage for quoted dotted names / column-list aliasing.
   - remove redundant .clone() after columns() since it already returns Vec<Column>.
   
   
   ## What changes are included in this PR?
   
   This PR adds SLT regression coverage for quoted dotted column names used with table column-list aliasing, including qualified and unqualified references.
   
   It also removes a redundant `.clone()` call after `plan.schema().columns()`.
   
   ## Are these changes tested?
   
   Yes. Tests are added in:
   
   `datafusion/sqllogictest/test_files/alias.slt`
   
   ## Are there any user-facing changes?
   
   No user-facing changes.
   
   ## LLM-generated code disclosure
   
   This PR includes LLM-generated code and comments. All LLM-generated content has been manually reviewed.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org


Re: [PR] Add regression coverage for quoted dotted column aliases [datafusion]

Posted by "kosiew (via GitHub)" <gi...@apache.org>.
kosiew merged PR #23155:
URL: https://github.com/apache/datafusion/pull/23155


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org


Re: [PR] Add regression coverage for quoted dotted column aliases [datafusion]

Posted by "nuno-faria (via GitHub)" <gi...@apache.org>.
nuno-faria commented on code in PR #23155:
URL: https://github.com/apache/datafusion/pull/23155#discussion_r3469261693


##########
datafusion/sqllogictest/test_files/alias.slt:
##########
@@ -104,3 +104,33 @@ physical_plan
 
 statement ok
 drop table t;
+
+# Test quoted dotted column names with subquery column-list aliasing
+# (https://github.com/apache/datafusion/issues/22916)

Review Comment:
   I think we should combine these new tests with the ones above, since some parts are repeated.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org


Re: [PR] Add regression coverage for quoted dotted column aliases [datafusion]

Posted by "kosiew (via GitHub)" <gi...@apache.org>.
kosiew commented on PR #23155:
URL: https://github.com/apache/datafusion/pull/23155#issuecomment-4795305077

   @nuno-faria 
   Thanks for the feedback.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org


Re: [PR] Add regression coverage for quoted dotted column aliases [datafusion]

Posted by "kosiew (via GitHub)" <gi...@apache.org>.
kosiew commented on PR #23155:
URL: https://github.com/apache/datafusion/pull/23155#issuecomment-4787996370

   @nuno-faria 
   PTAL


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org


Re: [PR] Add regression coverage for quoted dotted column aliases [datafusion]

Posted by "kosiew (via GitHub)" <gi...@apache.org>.
kosiew commented on code in PR #23155:
URL: https://github.com/apache/datafusion/pull/23155#discussion_r3471500305


##########
datafusion/sqllogictest/test_files/alias.slt:
##########
@@ -104,3 +104,33 @@ physical_plan
 
 statement ok
 drop table t;
+
+# Test quoted dotted column names with subquery column-list aliasing
+# (https://github.com/apache/datafusion/issues/22916)

Review Comment:
   [Merged the 2 sections](https://github.com/apache/datafusion/pull/23155/commits/88258bf88d37c9559816e468ef3270ef61e25407).



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org